From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D5B1FD4 for ; Fri, 10 Jul 2026 23:47:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783727238; cv=fail; b=ecJXabnEl8NHhcNFhKR8oUcWM7qKW6z5HVcZ4iWa+UkyiALzEIZg/tGmNQc6yJsbi48WY9+lPkEceryRKo5DOeV9kpaWIHW1X81Xswg74pjDfp94giAXyuRG5ftkaJNtNQZsdW3rH+l9DEbusIsclCuKG68nbYwFai+Nl0gINm8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783727238; c=relaxed/simple; bh=DsSfA28190XeH3swMROdVfgy9ipTOiPt0LyELPQaE4A=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=HZJPufsSqGD/PlW4jaHNTZ9uPh00lw/I4uIC4KDaAwJjh9kkKtNqvwrEwBC60HL1AD2yphRj0UWleTBuHJ9NB6sd24UIToqT+XCvQMT4aDglrb2OWNSWFfqadg70P342lO6OpvTb7xdjkx6Xw6OECtFo5OKN3VfEfwR4Df7S5lk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HXM0LDn5; arc=fail smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HXM0LDn5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783727237; x=1815263237; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=DsSfA28190XeH3swMROdVfgy9ipTOiPt0LyELPQaE4A=; b=HXM0LDn5bn3iXqg4QzO0N0xrGYw4Yl5ItY4NFIQxCigC06t1Z6lHFCN+ AEB6EJj9YSmETx7c1JOA5u65VTMf6b+G/29Nz8PHDOmoWTX+0XbIVv2kL D6+FUMEKuz86lbnM0q1yxregsqy+HSeui9Q+707WraMLDZ9OpO9bSgVA3 Vi7YChVgfKmR+ZeTkvh8MceYSX/i0KP2P9cr/FJ16s2UnFYrr4Ed7dZ2D 7pPOpU5fSPTJY0lYjUgSxLEVSbB8TEBgWxA11Sjhk0Ud4JdwD2oWOQy4G Rrpfy7cYQPRLipRWg5g9t+zL+WMKa6Beip20uqguq4iBAsJGyIFw4yO1z A==; X-CSE-ConnectionGUID: p/rYbu7ERpyLPSOdF7iJwA== X-CSE-MsgGUID: DvWKe9BeRk+y8P/hm7WA6Q== X-IronPort-AV: E=McAfee;i="6800,10657,11841"; a="84449638" X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="84449638" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2026 16:47:17 -0700 X-CSE-ConnectionGUID: B1zzcpIVTz2aXa30y9lGRw== X-CSE-MsgGUID: d/CEDHWDSjCIps4kHePXsg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="279421524" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2026 16:47:16 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Fri, 10 Jul 2026 16:47:15 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43 via Frontend Transport; Fri, 10 Jul 2026 16:47:15 -0700 Received: from BL2PR02CU003.outbound.protection.outlook.com (52.101.52.69) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Fri, 10 Jul 2026 16:47:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D87tdMupxdlrAwKTxCozJuXejTuIoHie1rqfF6H4UZg502Nb+lTmCu0j7doNo/bV+w+M2tNHayxsM4ktTlcYJy6miaVi9TnnaSX9aGW+zNTs7UKYyyKwNJWDaC8WZIhBh8vA30ucAMHFvvVkLTD/Bc5ajLDQnY/99pASXhGyj6WLi8TKmn3NNsTOVF81o0nMwZcV5Nt+jgC2Z0eL7bE2lvqbYCTiKaCqqEhcrjFbHJRQ75+tOOFM++2vXSxwcFja1ur68L2izASkAdVHxO+vnlHo5DSJB9Pi0Ycfw9KiqGW40DcK+JpvEPZUTOM+PiSnqXwLKLBu5m/d38lrl3CwPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7YK4r3leHwUyAf6DsdQFM3kr30OepkhJF8NrdIGG6Fk=; b=RGZlwQm8NskKIyppgr/qXvoZaR+H3Pw4u0xHoCoi3gREhBpOr6A0WxXr0PlcvPY8B9RB1EcSZXJ/m+vEaIj9JF9rQgMViu5hhRXQWHFUDlAP/xr+0QbndMhYCk8pMsoIdxSmE46MQ1/z1si6ZhZtpt1GjfiyQ7zx0JpSHEW39pBR8VCa9Qfatf88PmOVhNt4gs095EZansHNyM5CDS536f7LfAW5qT7WNVwDNf52c6UoQR9MwfkyTVk12KeTlqN9JRps3hdTGkZzf9Axh4cXJIov1cExf/E2OneZTFg3E0M4AsVeykfRrT/SfLvrUZ1bZY7qAQBT+kzTwg4ZSABxqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) by CH2PR11MB8833.namprd11.prod.outlook.com (2603:10b6:610:282::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Fri, 10 Jul 2026 23:47:10 +0000 Received: from SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc]) by SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc%5]) with mapi id 15.21.0181.014; Fri, 10 Jul 2026 23:47:10 +0000 Message-ID: <8b05c01b-c313-4b19-8590-9d2eee9ed61a@intel.com> Date: Fri, 10 Jul 2026 16:47:08 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/10] x86/resctrl: Replace "msr" in monitoring data identifiers To: Chen Yu , CC: , , , , , , , , , , , Hongyu Ning References: <1b1c5784dea02365b27bb81799a76bb7d789149e.1782866200.git.yu.c.chen@intel.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <1b1c5784dea02365b27bb81799a76bb7d789149e.1782866200.git.yu.c.chen@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0016.namprd03.prod.outlook.com (2603:10b6:303:8f::21) To SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB8370:EE_|CH2PR11MB8833:EE_ X-MS-Office365-Filtering-Correlation-Id: becbf5e5-b69f-45a3-b41b-08dededd8f20 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024|23010399003|18002099003|22082099003|11063799006|56012099006|4143699003; X-Microsoft-Antispam-Message-Info: IRYg9bagFFGLp3+uvIl5MkihHctv2YQW9JJPpM0UJoojTsRaDgeYEb3m0NJHLynCNQnoSmJrIsz0Sw3V0OMyOwPiOpDI4h3d0xS/mauPRebk0oOiPGbMatnZVn5ioQjFColG7UOAjXvn3iX7/catRhQ0Q/vRUr5IKEPRlTdzhzrVu8PpG9UNhjYsk5OggUFxDmBKuaCGkeDOBKUjib1gw/RDbaBIPeF9EMg18+w/pbfn4HxpNt3bIJSFm/anTOijgCpka8MOi7FzDefVPGbCemaJtBcbbCpCwe0gvX0U8+oNth5+pu0MaEtCnUVbsysKl7DcLHFD0XzKlxeeT0pXnPq3tpXcGTxf+N7H+ZzkwEq6kUK6k3eMxysCo4j8kgx/00ITSerKhCPCqL3OYj5mHxwlk7/jP2nLX7CCJFRzOsofkjGgNhDQEMQxkvph5YNrvz14zOSuxpejiTA7mNCUAE7Cp/rgakXKQSaGVR4ctx0VrT9DzRGdmudZaXQJS3KuDCVsfhEf4+nUb5HGH+Xr4A6WUqWCnhSuQDW3vyCGFrWtWBKJE0AUG47w7r+TkDvNC31y94m/glacCsUsKws7Wl31WPK3d8LwHFpJcLWeVISRKWECHf77mFoXyNzd8pe13onqlQxL2EpF8ealokyygb1k7idrLu583VgpouAtCK8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB8370.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024)(23010399003)(18002099003)(22082099003)(11063799006)(56012099006)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTZMakt1d0Q3WDVacHJlVFVDVk5KOUtqd0ZZREFwL20wR3ZDczBwbTlxRnpP?= =?utf-8?B?Z0ZMaGt2eFM3MVViSHF2ZWZ3OWtma1hheTBnR294K1BaRzhpZDBkcEZhZnlL?= =?utf-8?B?QmxNVEZocWxON21GaG45Nm5xOXFsNW5hT3c4ODlDUktmbHhkYVdMMmJZQ05x?= =?utf-8?B?TUhGbzhaQ0tiUTZLV1k2Y2FXSVJEZnNNeVZ1bXliMFQrcysvOXIxK0FiVndH?= =?utf-8?B?b2NFZXNJUmRhWVVtOE1TRlRwVDlpeDBkdWUzTXErblV1aW83WnlKbkRibjhj?= =?utf-8?B?K0RtMVB5cnhKQ1F5RDN3ZGI0QVR5TXIzd1BFTG1FQW9La1lQa09hUGU0SWhB?= =?utf-8?B?VXUvbHUzeGc5NDYvdWRTTmFmOEczSmdNWjNjaFZ6ckxERjgvNFpLb083UUhy?= =?utf-8?B?S1d3bFE1QUZuTWdKTzVLdkdoVnloZzdpeFpQNTNHcVlvR3JtNzcvTFRSZHVM?= =?utf-8?B?ZFo5TVo3Q3g1MXgyaDgvSmlUTExsK3NBY3BaclVzakwyRks5SE9pYmdQcmhy?= =?utf-8?B?RGVtbHlZekNHWWVtc01uTXRMbmYvbUx0T0J3R2RHNzhQQ2FBc3VYVi81RXRq?= =?utf-8?B?cnRaWXVxb3liUmp2QVQ4QzRLTXNZZWhUSXhzU2NFTGlIL3FYeStWODlCN2Yr?= =?utf-8?B?aGV1NkVmanVZUnZUWlZqcEhMbzBuR1EzaTFGS2twUU5qd3hwVVMxY3JXN2ti?= =?utf-8?B?TXZiZGhrcnVUbXhab3ZWamg4NEg0RS9nZ3lwb0oyS2dGMG5JU0N0T28wRFBF?= =?utf-8?B?L3ZjaVQ0eUFSNHIvU2lzdHJkekxGeXlhWWxRMnhqaFhQTVJtZHFHRUpKa3Rs?= =?utf-8?B?dnMxTjNBZmZhTU1QakxmRERGYmdwZzNrckJSWW9WVVgya0ZmUGZ0eDJOSVJi?= =?utf-8?B?NDFZSTRZMG92eGtmVk1aQk8yMUdveThMaTdLVXQ2VUJERzNyWjRwMHZTekpX?= =?utf-8?B?UGIzQUtvVEYzNlVOY3lnU2FjTHRjSjBwNzlTNnpGaklGZ05zOU1DSjQzOUlm?= =?utf-8?B?dHNsaUJlS2FWNmViek01S1ZYY2tnak1FYklwY0lMeW82WFlIUk5QRXJnS0V0?= =?utf-8?B?VXJWcDNkT2hrZGdRZWZ1S3JHb3hhOWdTN3kwRldLczQ5Z0RLd2hMckcvWlh6?= =?utf-8?B?a2YxTnlOSXdGUnJWeUFHYlZEbDIwL2VjSHFYcFNESkh3SjI0QXljeEcxc3BU?= =?utf-8?B?MlEyYkoyMkYxR25mM0NFZkpacm4yMUQ0UWticmdRVkFsdkJBOS9OazdHVkY5?= =?utf-8?B?cDNVclJFNGpZRkdFZGZsRUFDQUE1Q04vam1Va3U1cWNtcFNEc3pDMFl0ZURp?= =?utf-8?B?ODFwYlArQ040a3VsSE1BaGNsRE9rVWtqV3BIZ2FMMmZlRDBxck5aVXA4eUsw?= =?utf-8?B?dlFUS3FPTWZtMVlWcDgzYmtNbmFZeXZFNU5ueDB0VlJvdXFqRlJ5cmZvYjNi?= =?utf-8?B?YStiZEFWTXhMVk9ibE5ydnVSVkRNN1k5Q3NReVZHWDNRbFE0RnZQSUhzTzFO?= =?utf-8?B?Z29RdXg0RVFPaTFDZWtWaUcxcW1NOXdvNUMxeWxJMUlOVXR3UGxXb1k0d2pF?= =?utf-8?B?bjEyV0pYUk5KMXBKeTJnOHRDTFU2V2EwRmdSSk9UeWREMDFBemJER3pVNTF4?= =?utf-8?B?bXNTQWRLU0gwL0VROXB6aWs0OVZPMkplM2hqemdjVkhhMUc5L2FwNVRRVkZh?= =?utf-8?B?K1Zra2JIVWRtVXFzWElHenhhRUNHTHR4Y0tEQ1k2UGhHQlZCeVFyay9nS21J?= =?utf-8?B?MGhCWVVRT2NMa0dPdXRDcmtjdmpLeGhkRUdVS3hFdTV5ZmJBVUp3UUhEZ0xD?= =?utf-8?B?R0lpbTVZaUIwa3lUQmFrQUllRk4yK3NKV29kTEpFTU9ONTVaOHhzV3J2Rk1q?= =?utf-8?B?STVLQU5XcTF6K3JIOEtZQld1ZWhxbmY1RWtwYnp0VzM3bktMOUtCQUpBOHBw?= =?utf-8?B?L3YxY01JZUFKajl3anJKay9IZFZHUjgxR29JYUZNVDBYbWUvTXZESFREMnl4?= =?utf-8?B?ckZncXVwR1FTMXVwc1NwS0NkZDBDWUVPdFpQV1hCVE1xVXJRM1dsdWt3Y3Vq?= =?utf-8?B?YnNQaXA5MHNGbDEwSE1DQWFpRlZsVFRVT1FGQVV0S2IyR1BtSllBVE9zeHJN?= =?utf-8?B?cnJnb2JIK3ZOY0loSEFDRk81YTlkWS93M2w2ejJmQ1pJS0RadjdjQTZUK3R1?= =?utf-8?B?RFhDeUFZbzRmdTBkNGgzQ05DU3VLeDBnODh3RXQ3U1BhQ2tydnpqVWlCNmpS?= =?utf-8?B?R2ZhcUxqSDZFYW11SjJqSE1UUFl4aURiUFFCQ1ZQS2o1bWVjUGRUMElWdTRQ?= =?utf-8?B?SkY4V0pZZ2JMOUZ2OHp4eGJEa0gyMkJURVp1VVVxZDhyeUN3ZWxBdlBVZXZE?= =?utf-8?Q?U8AczHdMNiCyVua8=3D?= X-Exchange-RoutingPolicyChecked: QvGT3e/NoiYCHcOLlF168NTlNRw8/fzbYIaDvtPYhO7sp36h7sSOR04owJJbY5AZft+F7b8Jgztli8zAx8kMEBo+MOJt0zhRO0pG1J+7VvH92IzhwjhP1nJ2rk9EjLqq/zh+8r4I0zH9pnC/cMNXGkx4p/vUO5ydyxffW3x9vVpOHx1J4AlZGy0JYRmbyUB7VpEezriVIlGEOkJx3vGs37Os78N439VIQm4M0eeO08KFZF8ZI+b9yIrbJsvF1AvsQWV+M6yOgGzakCT6AnPoX+Lk8KbZGCGqSJapA+4OtY33aOWLcEvRAMglwmdS6jXi2U3frB1XLrptOfPR+N/HTQ== X-MS-Exchange-CrossTenant-Network-Message-Id: becbf5e5-b69f-45a3-b41b-08dededd8f20 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB8370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 23:47:10.4815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J7ogpoA6j6X7TXqgr9W94q/THt5jBbtNq/nafWW5jsprVwnZBL1QklOmkdOqMgE1hkxVQQ8vRmIv8t2PYn/EA5f4keO5nxfa/Zi2O1XxzTA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB8833 X-OriginatorOrg: intel.com Hi Chenyu, On 7/1/26 6:46 AM, Chen Yu wrote: > Monitoring counter values are currently obtained via MSR and many > identifiers involved in processing these values contain "msr" > as part of their names, for example "prev_msr" and "msr_val". > > The ERDT ACPI table describes MMIO registers for monitoring data > access. Rename "msr"-based identifiers to be interface-agnostic > to support their upcoming use for MMIO-read values. Are any of the identifiers renamed by this patch actually used by the MMIO reading code introduced by this series? > > No functional change. > > Reviewed-by: Thomas Gleixner > Tested-by: Hongyu Ning > Signed-off-by: Chen Yu > --- ... > diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h > index 3dab05c38003..6eb0fdea6b63 100644 > --- a/arch/x86/kernel/cpu/resctrl/internal.h > +++ b/arch/x86/kernel/cpu/resctrl/internal.h > @@ -52,13 +52,13 @@ struct erdt_domain_info { > /** > * struct arch_mbm_state - values used to compute resctrl_arch_rmid_read()s > * return value. > - * @chunks: Total data moved (multiply by rdt_group.mon_scale to get bytes) > - * @prev_msr: Value of IA32_QM_CTR last time it was read for the RMID used to > - * find this struct. > + * @chunks: Total data moved (multiply by rdt_group.mon_scale to get bytes) One renaming that does seem warranted is mon_scale that is a per-resource value that currently claims to "cqm counter * mon_scale = occupancy in bytes" but this implementation does not use it and instead uses a value private to ERDT. Reinette