From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C70A33121F for ; Mon, 16 Mar 2026 21:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773696117; cv=none; b=iiN0CPAGUcVPm8o7n+ZC8/P9DGCrgTcWNUpMC47cy8SjNuopHIaD1PxFtI+QY1YQ/4KcrUKO4aEr38Tn4+Z3n0dfZ+5rS+gCM2A1dvjsTq3B6mr9H4u5UCHV9XoqozEjTwpKLzdJ5lh4pBCBHhWgS0eeUM/JRSNpJIkixe8HAs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773696117; c=relaxed/simple; bh=9JS1Euum17JWQ8mWMsbya80wwUnSHtPpcynM37NTo1Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WWRxrLb20NjeQKXrsShPgPfCdGGDrJ6nZlpMUzch/mXjHKJrhfNjlG8k4bFUi8cxtg0mAJEsBnRK5S0puJNYUdl7KcvcgtaKXMJO9HvbyQfqz5MH3opQkk8NKlr/IKDt80wkHFZi3ntdVgjOzAubsVaCA7ucrN5/E4fX2Zfir+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G48Wk/y/; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G48Wk/y/" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-126ea4b77adso6161684c88.1 for ; Mon, 16 Mar 2026 14:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773696114; x=1774300914; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DOZ8t3Rj5dlKpUY985hxlvkSKTBIFVvaOU6e7SGFF3w=; b=G48Wk/y/zyVQz3GYGHeEtquHfiq7rbTtHcnp3vgeWFf7uInsQN6pag4QgVUZgEwxUv r/o/TDqLnj0d4RQTTo5WWp2mMvPnOKgB+s+qXveFJ+O9r2yWw85iZo6klG8gs6ZHXX4S +yfVZkT4+oFASVHtWqzPlX/nc49K2G0m4ips6hjLBx8o7Yyfws0NSUpuvTfugeAIuMpc 1vROmkfoYCHstB3KXATiWUv+2dMIZmiamC0LRDvwCIV2h9y95DzGmoUIO+nN373iTVTt Hj4ROkC+WxuZ4aGaW70oRKSfvw1wSFjAv3Y1dZ6on0VIdsT7Y/Y1v0+uPI0egj7A+M6j Atgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773696114; x=1774300914; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DOZ8t3Rj5dlKpUY985hxlvkSKTBIFVvaOU6e7SGFF3w=; b=cuZhGTEqtxoIPPxjDtyC5h313nJ8dR6qotyGWXyV4Hqk/sQf7dj9c31jVn0a0o/fBC mTYFbADnFGcPzPy/xYfjD1igx3rvVMV4yywFMW9Lj03tGkqL57+VPMEQZ7AG1CQ+nACw /KWXchp9MmD1BUoL6jhhHN/Y9X44WFBhgqtBs3bizstIm97/r1cgt03qca6jQB2/oy2w vW9Oxzwbrn5V5JUyUktn3I25SJyu2jeWd9ZJg0bhtEH3u1eZaUgK/PHRKr+48IXAkQ9f YMBvEa20Pm0wHBdOEG6cAxqXlJkA30SXreh0NaK7BRVvIw2W7muCNLq0TCBGTN72lY50 DCBQ== X-Forwarded-Encrypted: i=1; AJvYcCXmEe6DibJB9pePM3Hysbj2jZlGYPzVGHJq8Wxtg8aM+1D4qA5VAY95nOMTehFm1ZNzLNyUwXxCxI7gMT8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd+Ix2hppySV20qxeX6hywc10w7jC0jBVom1u+ELxyDoGchY04 6aC73zidFUs6GUaVm0IR8f0p0K+E4L9qxFOvOUx4Q/d82Yg1F7VPTuyA X-Gm-Gg: ATEYQzy3NfjvYfFqZA+yOJRnNjV7Rutq/dPR2YtrBJkSAp7zYAmIu72BfNqs4EYXLzj wE3LjCm0xUXPaSV3zatmTb4d5lyPrt0ztLb2GBx+gBd02NB09vyLycCW2jS04fnC1CZ9WkwkyER NxE6zcdOYcURxuFNj1QxLjDeB5wptLUhkyZ/5vSg09/im17k018jKk8SGO3ovazcHjUrcS+r7y3 LwuM/BVk1Y8XrmED2kpofVZeYAiGaN1l9M6NFln0uEnVpzkd+FMnhCkJHZftlN1Hk5RN5LF88Xn ktYbS3f+tA/Yt3EWzCtifp/wTQew2hihTKFDF0gbD9TWxEaggT0Jrn85ATkwV3ZoyBmhefuIz1M +xi5UBoV5O8LGQqk9HWRhsIxY92vCQAhWTx425F8CmQywRiJbfQ9nkqznQAZqTWmUPJ2ujlaOUD yO/3cqDWltergTxCTLb76wVwE74khQduY6mSvcYEtq/s4LnFZgGA== X-Received: by 2002:a05:7022:23a9:b0:122:2f4:b251 with SMTP id a92af1059eb24-128f3dc5578mr6453854c88.21.1773696114378; Mon, 16 Mar 2026 14:21:54 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-128f62991c7sm13728522c88.5.2026.03.16.14.21.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 14:21:53 -0700 (PDT) Message-ID: <8b086643-44e1-4c02-9d88-aba369d7d9b7@gmail.com> Date: Mon, 16 Mar 2026 14:21:51 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: bcmgenet: enable EEE TX LPI by default To: Jakub Kicinski , Florian Fainelli Cc: Nicolai Buchwitz , Doug Berger , Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260303160225.542613-1-nb@tipi-net.de> <997daf22-260b-40c4-a2d6-8c63f59df9a7@broadcom.com> <20260316135915.28c64ec8@kernel.org> Content-Language: en-US, fr-FR From: Florian Fainelli In-Reply-To: <20260316135915.28c64ec8@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/16/26 13:59, Jakub Kicinski wrote: > On Mon, 16 Mar 2026 12:54:46 -0700 Florian Fainelli wrote: >> On 3/3/26 08:02, Nicolai Buchwitz wrote: >>> GENET never initializes priv->eee.eee_enabled or >>> priv->eee.tx_lpi_enabled to true, so the link-change callback in >>> bcmgenet_mac_config() always calls bcmgenet_eee_enable_set() with >>> enable=false. The result is that EEE is negotiated at the PHY level >>> but the MAC never enters Low Power Idle, wasting the power savings >>> that EEE is designed to provide. >>> >>> Users can work around this with 'ethtool --set-eee eth0 eee on tx-lpi >>> on tx-timer 250', but the MAC should enable TX LPI out of the box when >>> the hardware supports it, consistent with how phylink-managed MACs >>> behave (phylink calls phy_support_eee() which sets eee_enabled=true and >>> tx_lpi_enabled=true by default). >>> >>> Initialize EEE software state during bcmgenet_open() on GENET v2+ so >>> that the link-change path activates EEE in hardware once the PHY >>> negotiates it. Use an LPI timer of 250 us, matching the default used >>> by other MAC drivers (mvneta, mvpp2). >>> >>> Signed-off-by: Nicolai Buchwitz >> >> Reviewed-by: Florian Fainelli > > FWIW this patch is set to Changes Requested, I _think_ based on this > reply from Andrew: > > https://lore.kernel.org/all/d352039f-4cbb-41e6-9aeb-0b4f3941b54c@lunn.ch/ > > LMK if the patch is good as is. It is good after 908c344d5cfac4160f49715da9efacdf5b6a28bd ("net: bcmgenet: fix broken EEE by converting to phylib-managed state") reaches net/next which is what Andrew was commenting on. -- Florian