From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759381AbdACQXi (ORCPT ); Tue, 3 Jan 2017 11:23:38 -0500 Received: from mail-pg0-f43.google.com ([74.125.83.43]:36582 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964944AbdACQXU (ORCPT ); Tue, 3 Jan 2017 11:23:20 -0500 Subject: Re: [PATCH 6/7] perf record: Add switch-output size option argument To: Arnaldo Carvalho de Melo References: <1483431600-19887-1-git-send-email-jolsa@kernel.org> <1483431600-19887-7-git-send-email-jolsa@kernel.org> <24608e6a-d744-8124-26c0-33d73f690477@gmail.com> <20170103161211.GA6259@kernel.org> Cc: Jiri Olsa , Namhyung Kim , Peter Zijlstra , Wang Nan , lkml , Ingo Molnar From: David Ahern Message-ID: <8b0f2091-bad0-951c-9571-5a0e46d7f971@gmail.com> Date: Tue, 3 Jan 2017 09:23:18 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170103161211.GA6259@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/3/17 9:12 AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 03, 2017 at 08:33:35AM -0700, David Ahern escreveu: >> On 1/3/17 1:19 AM, Jiri Olsa wrote: >>> It's now possible to specify the threshold size for >>> perf.data like: >>> >>> $ perf record --switch-output=2G ... >>> >>> Once it's reached, the current data are dumped in to the >>> perf.data. file and session does on. >> >> How about something like max-file-size instead of switch-output? > > Well, I think he wants to use the "switch-output" semantic, which will > go on "slicing" the output into multiple files according to the > specified criteria, be it the existing signal one or a file size. > > "max-file-size" looks like a hard limit, no hint about producing > multiple files. Sure, my point is that switch-output is an odd name for the option. file-slice?