From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 427822D837C for ; Wed, 10 Jun 2026 06:16:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781072211; cv=none; b=ThY+6/GXCgpRga9iy7XAbOt/zeXbiuIB1LNuvp+6PNiDBtS+BIUBEPrnm1FaBGU6XZSOE8uL28aehJGEVBDw9uqf9a2HwShIKZ3z1Qj9OIfOfeA/2a11FFzqOvO2yIMr00yoPzuJJD2zlgYdmaTjaY5qXBd9qaS5apXnsgFP5X0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781072211; c=relaxed/simple; bh=eRdB9IcExeSuHVeD4iZ6KuqU/GRLMfDP/J7Iq/x5/Ok=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tafE7f5wRE8F3sd14rdtio9IMlBlhLoRH+yvopWdbfj+D/9b/+d4f+S62EQKUNUAS0ATlsQYdUynUK9whw2hNzREMvEU0XBAeUiTjLQr4H9lOphvBe3R7j6J6X7k2No+FdQtqiJ+mrPvzbmee6zW9xpESADgqxzIXc2UMC92kGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JJ2nS2wn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f57F/sDo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JJ2nS2wn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f57F/sDo" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A2f8P4323976 for ; Wed, 10 Jun 2026 06:16:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TFJyzzVwH204oZf0Zg9D/JDdPLwjY1lv4WhKivVcE3A=; b=JJ2nS2wnDcbLNzEp MeWnFjGDML5Dcd50WyQkOhOulgMRAX1Zfkx190kXhHHuAaOhKmHwxC5CwK1gISpL d1w0gsEK8HTMFU+pUdY7G8wxijIvQE3foEfoDa0D+gyKIJJOelMlCK82xO+s1MtL 50HZSuTTvyddKQUHSaCa8wueKM28knuHUnj91BIJ0IlFA86aiGObIjisDb/mxFAf wRIcmPp2FlXFUm1+b70u1TOIuefevAXmMeW6kNJScW/cOYckJE/vYqg/mI4jtqJb APipRJVXmIqBQJqbZt7+KxkCX/UZ086sY9iLbOtpD+oIA1/PeAJYyGHPY02k4Asb J3Ti1g== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epeeawpqj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 06:16:48 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36d97415004so12409991a91.2 for ; Tue, 09 Jun 2026 23:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781072207; x=1781677007; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TFJyzzVwH204oZf0Zg9D/JDdPLwjY1lv4WhKivVcE3A=; b=f57F/sDoxScGnxE2ksN7aHuc9fIXQYZrGvn3PSn59VwNZZp9IbVIoijCL/BNrX4K6h 5F4H31o2gvFYStek631q8HGkVh9LymVlD6sKNNvVjXtcs1dRoMwxK/EW7fLUfY2h2ve2 wk2D2je8M1LozTHd1k1BtM2svb5LeassT7C6/s1rwLhNOuqmfRR3sN4+/gs5FW9Czf11 ijIHES73t0q1bwd1yx2r/gZs0ckmekSCnGcebJv9pyThz3rpE/tEihhEO1CGshrFnMO6 oTYptmzUjRLabu7pSwCqsxSeknExOfYewoh5/+3kJoCI4fK2xc8OASUnhNAYd+SGwhuH mEkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781072207; x=1781677007; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TFJyzzVwH204oZf0Zg9D/JDdPLwjY1lv4WhKivVcE3A=; b=j1ur25e5yuVdzR0WkEqoIBhCZAk4h9bezzXVUuF2iaWaGUfnbyjNyOXLdr/bu5As/Y JaJACJyMcq7moeJXHA727p8RzCXAWHL7FB/nc72y3kspR6DF8zbD2axX1bitQ13QLGjA B5uJPebeF3Q7LEnldhXljMJc/hQe2yjoRpP35GQMN0slbB4FBqF/Lq6nr6Nq2/RgTG+f IAvX1xmt6jSzZ9/yZXPYfhP01zMMDzH76X4gmfG8kdaj5nwVNR7rnGgCGpOJHy0pXDBm DU5FnxUZg4CrgtHnoQmQxCl5dSAICRoJCO1KzBlJeEns56HnYqMICxaHf00QORt3VXeQ fyFg== X-Forwarded-Encrypted: i=1; AFNElJ93OLyX1uyPhJBWiq0DPGYIVQT62k4vmu+XeVdqXfaORVBbMs8mCeU9o/98ReGWe3TsyAFDALD1J59VjyE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4rSBiJecGzLq7smheDQZTRjm2sEB8bqmR/rm4xiQxWZyPanns QZ370JlQ1WccpQOXeQ1PVY/BVELJcvBQv9aEXoNotLf0grIN1IxFUHV4Z/T2FVwEAuKArM8EKtJ ZOddMpsBAMEFJcfUCprUUGEADH4B6nXdmXqrqRFhGhmmdDHDmkTyTlmD0v+oPLEBCW9Q= X-Gm-Gg: Acq92OFsxEqGUoXnbH3IibTuuDfN1+A2ODPMGGd2YcRYb1K7qs9ExBGtXC8S12+Wafd WWAfR6niTND30Q38Vr3UWByviQQlC4YA6E7OK0fHhndFD8QuPLjSYGpWiNrJmYI0igYCw10dRa8 Huj1Io/r/M/5GI78jlEp5jXnQvZ0rAvC10VmcsfD5DjfKVwiWxqZWyTl6TYKi/slH/pHMyr506d ukfbLim1QlK5A12HrkF+Rkwb+AVr+pNnmsR4uEwpUocguxui4jfXvictO1bUBLaRJ0ln8JnFfLS ttf7yxuskfCpebgzdwqbwwOjnfXujVSlDOZLH18IYUGBtw4jk1adM+7sW/tjNSP5DyszlnlEX2g mxbhU0CFnuVo1HA4DeF86gDsL7FCoL3+QP9I8y3zHSuOrh9kvk9OCXOiG3Do6 X-Received: by 2002:a17:90b:54cd:b0:36e:2106:ded8 with SMTP id 98e67ed59e1d1-370f1333f8fmr23429115a91.25.1781072206887; Tue, 09 Jun 2026 23:16:46 -0700 (PDT) X-Received: by 2002:a17:90b:54cd:b0:36e:2106:ded8 with SMTP id 98e67ed59e1d1-370f1333f8fmr23429087a91.25.1781072206473; Tue, 09 Jun 2026 23:16:46 -0700 (PDT) Received: from [10.218.15.172] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37624b83589sm1779078a91.16.2026.06.09.23.16.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 23:16:46 -0700 (PDT) Message-ID: <8b110f90-2001-4655-856d-ec8cff98fc0a@oss.qualcomm.com> Date: Wed, 10 Jun 2026 11:46:41 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] pinctrl: qcom: Avoid assigning thread_op_remain in unthreaded test To: Konrad Dybcio , Bjorn Andersson , Linus Walleij , Yuanjie Yang Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260529-tlmm_test_changes-v1-0-88bfdccb4369@oss.qualcomm.com> <20260529-tlmm_test_changes-v1-3-88bfdccb4369@oss.qualcomm.com> Content-Language: en-US From: Sneh Mankad In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: JkYjkCpbREy5SkcWCcFI4i5XqHgBjjyS X-Authority-Analysis: v=2.4 cv=Iey3n2qa c=1 sm=1 tr=0 ts=6a290150 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=86_BQXzD9sKH6W767hAA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDA1NyBTYWx0ZWRfX0yUlC0IsZabp Q/zh6YvxBrmu7uoyX7q/K25z2zsXzQ/Vt+w1ZSKIr1wbSPXJFFaa9Y6XABXqDxK0CO+99vbBv3w /cQneL9sg4ZLdyYyAsG9B09TsQJAk7yqxjfk5WJwfXGeo/Zqiywo8UE2Np00B1iPOPo6ayvF+SR j3sx7xdTDjwuXBwYQqh9iqVHjR0wKdETODe35GUQlXpjo4hs9PxytGOz1wLIVUlrwH3o/OBarQr agRYSZdHck4F/3UZJLaT30T/NV7N5yh2yVTPFxAOcHfl0czyL7uvV3XI5n92V0KHKnPzAsEasVG gcslh9eDoQwUVwhiKDJ8gNOS67zHG4Qw7UmaCkTR+o7tIsKoEiFV2vcguKg+bRynhz9/D1T8yqX wLQLFt9Q3X5xq8/tcUCo9wFXjb9H9t9C4Uup1j02MIoXTnp6Cq+HdfIoZ2uX37IpFGDLzY0uJDo j0yfpQ9QO+Idgi86tlw== X-Proofpoint-GUID: JkYjkCpbREy5SkcWCcFI4i5XqHgBjjyS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100057 On 03-Jun-26 7:28 PM, Konrad Dybcio wrote: > > > On 29-May-26 14:55, Sneh Mankad wrote: >> tlmm_test_rising_while_disabled() sets thread_op_remain to 10, but this >> variable is only used by the threaded IRQ handler to control the number >> of GPIO pin toggles. Since tlmm_test_rising_while_disabled() does not >> register a threaded IRQ handler, the assignment is never used. >> >> Remove the thread_op_remain assignment from >> tlmm_test_rising_while_disabled(). >> >> This does not cause any change in functionality. >> >> Signed-off-by: Sneh Mankad >> --- >> drivers/pinctrl/qcom/tlmm-test.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/pinctrl/qcom/tlmm-test.c b/drivers/pinctrl/qcom/tlmm-test.c >> index 007d6539ceced294e81cfbe93a00c75a98c858de..e9e04300ab3687825255885821ebde0f3ee586a8 100644 >> --- a/drivers/pinctrl/qcom/tlmm-test.c >> +++ b/drivers/pinctrl/qcom/tlmm-test.c >> @@ -521,7 +521,6 @@ static void tlmm_test_rising_while_disabled(struct kunit *test) >> unsigned int before_edge; >> >> priv->intr_op = TLMM_TEST_COUNT; >> - atomic_set(&priv->thread_op_remain, 10); > > Should this be setting priv->intr_op_remain instead? Should not be needed. priv->intr_op_remain is to indicate the hard IRQ handler how many times to toggle the GPIO line within the irq handler. Here the test case does not require any toggles within IRQ handler. I also found other test cases where intr_op_remain is assigned but never used. Will remove them in v2. Thanks, Sneh