From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 414EEC54EE9 for ; Tue, 13 Sep 2022 09:00:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231555AbiIMJAy (ORCPT ); Tue, 13 Sep 2022 05:00:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231409AbiIMJAp (ORCPT ); Tue, 13 Sep 2022 05:00:45 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D7A835282E for ; Tue, 13 Sep 2022 02:00:34 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9BDAA1063; Tue, 13 Sep 2022 02:00:40 -0700 (PDT) Received: from [10.162.42.9] (unknown [10.162.42.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E31C3F73B; Tue, 13 Sep 2022 02:00:31 -0700 (PDT) Message-ID: <8b115b79-f21b-645f-f1d2-faa493003b8a@arm.com> Date: Tue, 13 Sep 2022 14:30:29 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 11/16] mm/page_alloc: make boot_nodestats static Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org Cc: david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-12-linmiaohe@huawei.com> From: Anshuman Khandual In-Reply-To: <20220909092451.24883-12-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/9/22 14:54, Miaohe Lin wrote: > It's only used in mm/page_alloc.c now. Make it static. > > Signed-off-by: Miaohe Lin Reviewed-by: Anshuman Khandual > --- > mm/internal.h | 2 -- > mm/page_alloc.c | 2 +- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 2424fcde6538..43a441d35baf 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -864,8 +864,6 @@ int migrate_device_coherent_page(struct page *page); > */ > struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags); > > -DECLARE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > - > extern bool mirrored_kernelcore; > > static inline bool vma_soft_dirty_enabled(struct vm_area_struct *vma) > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3417232afa45..7a8a6bb08a15 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6571,7 +6571,7 @@ static void per_cpu_pages_init(struct per_cpu_pages *pcp, struct per_cpu_zonesta > #define BOOT_PAGESET_BATCH 1 > static DEFINE_PER_CPU(struct per_cpu_pages, boot_pageset); > static DEFINE_PER_CPU(struct per_cpu_zonestat, boot_zonestats); > -DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > +static DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > > static void __build_all_zonelists(void *data) > {