mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: "Aleksandar Rikalo" <arikalo@gmail.com>,
	"Chao-ying Fu" <cfu@wavecomp.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greg Ungerer" <gerg@kernel.org>,
	"Hauke Mehrtens" <hauke@hauke-m.de>,
	"Ilya Lipnitskiy" <ilya.lipnitskiy@gmail.com>,
	linux-kernel@vger.kernel.org,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	"Marc Zyngier" <maz@kernel.org>,
	"paulburton@kernel.org" <paulburton@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Serge Semin" <fancer.lancer@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Tiezhu Yang" <yangtiezhu@loongson.cn>
Subject: Re: [PATCH v4 07/14] clocksource: mips-gic-timer: Always use cluster 0 counter as clocksource
Date: Tue, 09 Jul 2024 09:47:52 +0800	[thread overview]
Message-ID: <8b133053-247f-414b-9c01-e0e5291e347d@app.fastmail.com> (raw)
In-Reply-To: <bf4a45e9-4ed3-4d3b-bb96-add20a71b04c@linaro.org>



在2024年7月9日七月 上午12:36,Daniel Lezcano写道:
> On 11/05/2024 12:43, Aleksandar Rikalo wrote:
>> From: Paul Burton <paulburton@kernel.org>
>> 
>> In a multi-cluster MIPS system we have multiple GICs - one in each
>> cluster - each of which has its own independent counter. The counters in
>> each GIC are not synchronised in any way, so they can drift relative to
>> one another through the lifetime of the system. This is problematic for
>> a clocksource which ought to be global.
>> 
>> Avoid problems by always accessing cluster 0's counter, using
>> cross-cluster register access. This adds overhead so we only do so on
>> systems where we actually have CPUs present in multiple clusters.
>> For now, be extra conservative and don't use gic counter for vdso or
>> sched_clock in this case.
>> 
>> Signed-off-by: Paul Burton <paulburton@kernel.org>
>> Signed-off-by: Chao-ying Fu <cfu@wavecomp.com>
>> Signed-off-by: Dragan Mladjenovic <dragan.mladjenovic@syrmia.com>
>> Signed-off-by: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
>> ---
>
> Applied patch 7 and 8

I think it won't compile without patch 1 being applid.

Thomas, do you mind to apply patch 1 for now? Given that it's just some extra
function definitions.

Thanks
- Jiaxun

>
> Thanks
>
> -- 
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog

-- 
- Jiaxun

  reply	other threads:[~2024-07-09  1:48 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-11 10:43 [PATCH v4 00/14] MIPS: Support I6500 multi-cluster configuration Aleksandar Rikalo
2024-05-11 10:43 ` [PATCH v4 01/14] MIPS: CPS: Add a couple of multi-cluster utility functions Aleksandar Rikalo
2024-07-09  8:50   ` Thomas Bogendoerfer
2024-05-11 10:43 ` [PATCH v4 02/14] MIPS: GIC: Generate redirect block accessors Aleksandar Rikalo
2024-07-09  8:51   ` Thomas Bogendoerfer
2024-05-11 10:43 ` [PATCH v4 03/14] irqchip: mips-gic: Introduce for_each_online_cpu_gic() Aleksandar Rikalo
2024-06-21 18:58   ` Thomas Gleixner
2024-05-11 10:43 ` [PATCH v4 04/14] irqchip: mips-gic: Support multi-cluster in for_each_online_cpu_gic() Aleksandar Rikalo
2024-06-21 20:21   ` Thomas Gleixner
2024-05-11 10:43 ` [PATCH v4 05/14] irqchip: mips-gic: Setup defaults in each cluster Aleksandar Rikalo
2024-06-21 20:23   ` Thomas Gleixner
2024-05-11 10:43 ` [PATCH v4 06/14] irqchip: mips-gic: Multi-cluster support Aleksandar Rikalo
2024-05-11 10:43 ` [PATCH v4 07/14] clocksource: mips-gic-timer: Always use cluster 0 counter as clocksource Aleksandar Rikalo
2024-07-08 16:36   ` Daniel Lezcano
2024-07-09  1:47     ` Jiaxun Yang [this message]
2024-07-09  8:53       ` Thomas Bogendoerfer
2024-07-09 14:44         ` Daniel Lezcano
2024-07-09 14:56           ` Thomas Bogendoerfer
2024-05-11 10:43 ` [PATCH v4 08/14] clocksource: mips-gic-timer: Enable counter when CPUs start Aleksandar Rikalo
2024-05-27 12:31   ` Philippe Mathieu-Daudé
2024-05-11 10:43 ` [PATCH v4 09/14] MIPS: pm-cps: Use per-CPU variables as per-CPU, not per-core Aleksandar Rikalo
2024-05-11 10:43 ` [PATCH v4 10/14] MIPS: CPS: Introduce struct cluster_boot_config Aleksandar Rikalo
2024-05-11 10:43 ` [PATCH v4 11/14] MIPS: CPS: Boot CPUs in secondary clusters Aleksandar Rikalo
2024-05-11 10:43 ` [PATCH v4 12/14] mips: Enable FDC on MIPS R6 platforms Aleksandar Rikalo
2024-05-11 10:43 ` [PATCH v4 13/14] mips: Move FDC driver to a separate directory Aleksandar Rikalo
2024-05-11 10:43 ` [PATCH v4 14/14] mips: FDC driver refactor Aleksandar Rikalo
2024-06-20 17:56 ` [PATCH v4 00/14] MIPS: Support I6500 multi-cluster configuration Thomas Bogendoerfer
2024-06-20 23:05   ` Jiaxun Yang
2024-06-21  8:21     ` Thomas Bogendoerfer
2024-06-21  9:13       ` Serge Semin
2024-06-24  1:28         ` Serge Semin
2024-06-21 11:04       ` Jiaxun Yang
2024-06-24 20:12 ` Serge Semin
2024-06-25  8:22   ` Aleksandar Rikalo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b133053-247f-414b-9c01-e0e5291e347d@app.fastmail.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=arikalo@gmail.com \
    --cc=cfu@wavecomp.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=fancer.lancer@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=ilya.lipnitskiy@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=paulburton@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome