From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F06C31E5B for ; Tue, 18 Jun 2019 15:56:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B441220873 for ; Tue, 18 Jun 2019 15:56:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="gLp1WFIl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729593AbfFRP4o (ORCPT ); Tue, 18 Jun 2019 11:56:44 -0400 Received: from smtprelay-out1.synopsys.com ([198.182.47.102]:44622 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729246AbfFRP4o (ORCPT ); Tue, 18 Jun 2019 11:56:44 -0400 Received: from mailhost.synopsys.com (badc-mailhost2.synopsys.com [10.192.0.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 3FFF8C01A5; Tue, 18 Jun 2019 15:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1560873403; bh=1CMFfyJ7KaqXsTwHeD0j2YtsPsIQr6LJJY2pE9Kcd60=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=gLp1WFIlY0uITGiBUv9seLfszYyDfOeKylsQABZ2qhGKRm70yCVDLOC2NJlg7bM+5 +JMjx860EQZ58XxmfMDDGp7ehxdfkvOhQ+JpVGzZDWhJgJLPbC3/fG9xaB3kUZlkJj qcutieg+xUzcla39kpZj7SzhNi3boWO5AvnpBYjnfvj+IQkhl7ipROUMdD626O0ydM Ic5gNnWgvlYjTWuxWwJ01ypiUQ6CKDrUvhC0J0ZS3EyyzWHPZyUWxhs2v91hrLy+Ms N+WX6vmDUjyJxNBmYDLddfI6TCY6097LKe850NFvCbOCub5IhpXr5EDm5bEF/RTh5B sMWOPW0YcJ49Q== Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id D2325A0069; Tue, 18 Jun 2019 15:56:40 +0000 (UTC) Received: from IN01WEHTCB.internal.synopsys.com (10.144.199.106) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 18 Jun 2019 08:56:39 -0700 Received: from IN01WEHTCA.internal.synopsys.com (10.144.199.103) by IN01WEHTCB.internal.synopsys.com (10.144.199.105) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 18 Jun 2019 21:26:50 +0530 Received: from [10.10.161.66] (10.10.161.66) by IN01WEHTCA.internal.synopsys.com (10.144.199.243) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 18 Jun 2019 21:26:50 +0530 Subject: Re: [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault() To: , , Eugeniy Paltsev CC: Anshuman Khandual , Fenghua Yu , arcml , "Masami Hiramatsu" References: <1560420444-25737-1-git-send-email-anshuman.khandual@arm.com> From: Vineet Gupta Openpgp: preference=signencrypt Autocrypt: addr=vgupta@synopsys.com; keydata= mQINBFEffBMBEADIXSn0fEQcM8GPYFZyvBrY8456hGplRnLLFimPi/BBGFA24IR+B/Vh/EFk B5LAyKuPEEbR3WSVB1x7TovwEErPWKmhHFbyugdCKDv7qWVj7pOB+vqycTG3i16eixB69row lDkZ2RQyy1i/wOtHt8Kr69V9aMOIVIlBNjx5vNOjxfOLux3C0SRl1veA8sdkoSACY3McOqJ8 zR8q1mZDRHCfz+aNxgmVIVFN2JY29zBNOeCzNL1b6ndjU73whH/1hd9YMx2Sp149T8MBpkuQ cFYUPYm8Mn0dQ5PHAide+D3iKCHMupX0ux1Y6g7Ym9jhVtxq3OdUI5I5vsED7NgV9c8++baM 7j7ext5v0l8UeulHfj4LglTaJIvwbUrCGgtyS9haKlUHbmey/af1j0sTrGxZs1ky1cTX7yeF nSYs12GRiVZkh/Pf3nRLkjV+kH++ZtR1GZLqwamiYZhAHjo1Vzyl50JT9EuX07/XTyq/Bx6E dcJWr79ZphJ+mR2HrMdvZo3VSpXEgjROpYlD4GKUApFxW6RrZkvMzuR2bqi48FThXKhFXJBd JiTfiO8tpXaHg/yh/V9vNQqdu7KmZIuZ0EdeZHoXe+8lxoNyQPcPSj7LcmE6gONJR8ZqAzyk F5voeRIy005ZmJJ3VOH3Gw6Gz49LVy7Kz72yo1IPHZJNpSV5xwARAQABtCpWaW5lZXQgR3Vw dGEgKGFsaWFzKSA8dmd1cHRhQHN5bm9wc3lzLmNvbT6JAj4EEwECACgCGwMGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheABQJbBYpwBQkLx0HcAAoJEGnX8d3iisJeChAQAMR2UVbJyydOv3aV jmqP47gVFq4Qml1weP5z6czl1I8n37bIhdW0/lV2Zll+yU1YGpMgdDTHiDqnGWi4pJeu4+c5 xsI/VqkH6WWXpfruhDsbJ3IJQ46//jb79ogjm6VVeGlOOYxx/G/RUUXZ12+CMPQo7Bv+Jb+t NJnYXYMND2Dlr2TiRahFeeQo8uFbeEdJGDsSIbkOV0jzrYUAPeBwdN8N0eOB19KUgPqPAC4W HCg2LJ/o6/BImN7bhEFDFu7gTT0nqFVZNXlOw4UcGGpM3dq/qu8ZgRE0turY9SsjKsJYKvg4 djAaOh7H9NJK72JOjUhXY/sMBwW5vnNwFyXCB5t4ZcNxStoxrMtyf35synJVinFy6wCzH3eJ XYNfFsv4gjF3l9VYmGEJeI8JG/ljYQVjsQxcrU1lf8lfARuNkleUL8Y3rtxn6eZVtAlJE8q2 hBgu/RUj79BKnWEPFmxfKsaj8of+5wubTkP0I5tXh0akKZlVwQ3lbDdHxznejcVCwyjXBSny d0+qKIXX1eMh0/5sDYM06/B34rQyq9HZVVPRHdvsfwCU0s3G+5Fai02mK68okr8TECOzqZtG cuQmkAeegdY70Bpzfbwxo45WWQq8dSRURA7KDeY5LutMphQPIP2syqgIaiEatHgwetyVCOt6 tf3ClCidHNaGky9KcNSQ Message-ID: <8b184218-6880-204e-a9dd-e627c5ca92ca@synopsys.com> Date: Tue, 18 Jun 2019 08:56:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.66] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +CC Masami San, Eugeniy On 6/13/19 10:57 AM, Vineet Gupta wrote: > On 6/13/19 3:07 AM, Anshuman Khandual wrote: >> Questions: >> >> AFAICT there is no equivalent of erstwhile notify_page_fault() during page >> fault handling in arc and mips archs which can call this generic function. >> Please let me know if that is not the case. > > For ARC do_page_fault() is entered for MMU exceptions (TLB Miss, access violations > r/w/x etc). kprobes uses a combination of UNIMP_S and TRAP_S instructions which > don't funnel into do_page_fault(). > > UINMP_S leads to > > instr_service > do_insterror_or_kprobe > notify_die(DIE_IERR) > kprobe_exceptions_notify > arc_kprobe_handler > > > TRAP_S 2 leads to > > EV_Trap > do_non_swi_trap > trap_is_kprobe > notify_die(DIE_TRAP) > kprobe_exceptions_notify > arc_post_kprobe_handler > > But indeed we are *not* calling into kprobe_fault_handler() - from eithet of those > paths and not sure if the existing arc*_kprobe_handler() combination does the > equivalent in tandem. @Eugeniy can you please investigate this - do we have krpobes bit rot in ARC port. -Vineet