From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4DA133F361 for ; Tue, 10 Feb 2026 09:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770714067; cv=none; b=SApcRUHAlq3EUe+tGc7f0vawuA8NNPkDO9GFaUMTTVXoljvZ1HinBXAEXyZjLWXib7mrAZiXhGxLtLeD9ojIKYJXi6o/fxKPmFEZ4wc0uhJcpevSm5ULcy0wv7ZmaGu+Yb1UFLfYaYiK+G9Jpws+R5ucdnFPnHx5x1zOVI5o2w0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770714067; c=relaxed/simple; bh=5TuK/1VHSDAvQJedSrFEg1hBDEt18y5IQCShE6I97Cs=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=amgKxgJB5/ZWNxdze3xD3bu2U6hb00H+eZSPUw0WmJ9xtGpqGIcvw8CFRb8PF4NLGGmCxoKg2p1+RHWpvGn4XgYRFf6ENN1xI9jzPLu2hHXK/MnqdFmfHpBfx4NE3GXVxLWf6wd6Dk1gFjuOws3tyt2GH1Ukc9R+9ISgQ/ejfZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KBNuy/zb; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KBNuy/zb" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-436317c80f7so1774480f8f.1 for ; Tue, 10 Feb 2026 01:01:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770714063; x=1771318863; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=BNcrRuVJbDcGsHBwzSgQQzMKr5rzXqyv5RgDCsFejSY=; b=KBNuy/zbAphcR2Y+H0B01by75cKJUhiEqlPbXu5D4Jl0mAdv2jyYi6VCOykNMHpEdG iF7Mu2Mp50SYSdGopl/wkN/M6GkKipJIVcgPma3LCAnxuJ8YkpiDXzeQ4SfKIaoNPerb w2fMcnXw3Qu44+Gy8VAOj+Ws6+aObzAjAnn12a1J6hOpOOALFF6F3rv7LnoORUxZmuXY bLaGthU0qeZfgtXo2KyY3ukJ8f8VU79qHYEHSt9tAx4kknH021SNhEpp1VpOLm2licGP UATNsfIPqOuxkfHEq7oad7l8nlnQ5d4bi/50842EBSuUY6YbJ5U2Poiw7AEHd7X6EvST P6BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770714063; x=1771318863; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BNcrRuVJbDcGsHBwzSgQQzMKr5rzXqyv5RgDCsFejSY=; b=YAAUMYOdn9mgoli7KKaPpAkDAStmzjqNTGTKZaKN6HV0Ju3rnMiJhpx+pPjSziFyVC 9MPCuUNVWnxrBggHNb0icW+SQJtLkLnmSsG4MVa13jHAXk7v2UGNkTWB17o8tm4JEGVT JJ6qQ84RdMsHTQF0EIXOqgEmZDt/SlmtxFvo1noAfGlReFa/GjRrzQPU0+VsOZQCr8Ks Duzx/vgL58QfhrxXM/q5ES0L2kboqs12kfeZMuNzvtuz8OzMPrCzyi/Ni1gMjV5fvk8m TwsBHQjQgAz1xfHcFN8dL1r3Y9ndQ0GGxv4c/pNaKnokpYU/cGYsN7IArkvPOQNwyxMc UPHQ== X-Forwarded-Encrypted: i=1; AJvYcCV3MZNMqhJKOleSFBfM+uDfAciVK48sIqX5Lq7ShbqP/1bG8vl0HE23obZYEkfjS7dDrc4UvVk1A3RSYEE=@vger.kernel.org X-Gm-Message-State: AOJu0YzRXq22ooKv+KxK2iiC/sQVxV4RqcKXY8fqKszzRXrZU2C+SESY wCbzFY9ToI4QBs5CZpRLPMkDrO0NY3O4fVlodlu5CFFqM1h7QeWytXcsskZXeCKtQB0= X-Gm-Gg: AZuq6aLUo21NRN7Xv+c9A+hxciF0npqFnwJRYdo9UdOMpddEezPmvMz6Xi4Aa2CKAet Vmq1OBMLkI7e6O/s2lprlc2q4ThAZxIT1XZWcFLZoBf6L40uGkk6sFCyU9f7b195MwbvcVP3A1y hOzkMLMYoa+Ia1Wr06wQFT0HzdydIyWNKQF0a9KbnLXGpwQjZoBTfRTSlOXL6/IIeC5WKPv+gbn AG7hG9JBn5J2GJu7eipD9B7E0Llh/sjXEFpAtVE3MmqugywWnMPFupbLalaZWn5XY9OAorqL0ak YOt0hji7MnLhzTtrs4pbiLVag2HdX2+qojnBmJAb7mGUw1iccLpLOgtS0cM98Y3gyHd+2+SAu3G k5Z0XgE1JoGUkPWMaTqK7rjsA5YWxOY2cscVGns/+u6tivA3qrYS50rJn3G+o4LDhkuYgmW7CqM DaYUVWPtMRej4gIK4rPZXfWLWLouoRJxxYzgcyxKk2Qii8KVgBDZxowWtzmds4MNTemo3xsQQyK EmNWQ== X-Received: by 2002:a5d:5d0d:0:b0:437:722d:5c66 with SMTP id ffacd0b85a97d-43779ead6acmr2868167f8f.16.1770714062899; Tue, 10 Feb 2026 01:01:02 -0800 (PST) Received: from ?IPV6:2a01:e0a:106d:1080:f60f:868a:517c:18fc? ([2a01:e0a:106d:1080:f60f:868a:517c:18fc]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436297450b4sm33534874f8f.34.2026.02.10.01.01.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 01:01:02 -0800 (PST) Message-ID: <8b18433a-5836-4a65-b790-9f51112d1f5c@linaro.org> Date: Tue, 10 Feb 2026 10:01:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v3 4/9] pci: pwrctrl: generic: support for the UPD720201/UPD720202 USB 3.0 xHCI Host Controller To: Manivannan Sadhasivam Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Bartosz Golaszewski , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260206-topic-sm8650-ayaneo-pocket-s2-base-v3-0-5b79c5d61a03@linaro.org> <20260206-topic-sm8650-ayaneo-pocket-s2-base-v3-4-5b79c5d61a03@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/10/26 09:00, Manivannan Sadhasivam wrote: > On Mon, Feb 09, 2026 at 03:59:20PM +0100, Neil Armstrong wrote: >> On 2/9/26 15:49, Manivannan Sadhasivam wrote: >>> On Mon, Feb 09, 2026 at 03:00:02PM +0100, Neil Armstrong wrote: >>>> On 2/9/26 12:30, Manivannan Sadhasivam wrote: >>>>> On Fri, Feb 06, 2026 at 03:50:32PM +0100, Neil Armstrong wrote: >>>>>> Enable the generic pwrctrl driver to control the power of the >>>>>> PCIe UPD720201/UPD720202 USB 3.0 xHCI Host Controller. >>>>>> >>>>>> Signed-off-by: Neil Armstrong >>>>>> --- >>>>>> drivers/pci/pwrctrl/generic.c | 4 ++++ >>>>>> 1 file changed, 4 insertions(+) >>>>>> >>>>>> diff --git a/drivers/pci/pwrctrl/generic.c b/drivers/pci/pwrctrl/generic.c >>>>>> index 08e53243cdbd..4a57a631362f 100644 >>>>>> --- a/drivers/pci/pwrctrl/generic.c >>>>>> +++ b/drivers/pci/pwrctrl/generic.c >>>>>> @@ -73,6 +73,10 @@ static const struct of_device_id pci_pwrctrl_slot_of_match[] = { >>>>>> { >>>>>> .compatible = "pciclass,0604", >>>>>> }, >>>>>> + /* Renesas UPD720201/UPD720202 USB 3.0 xHCI Host Controller */ >>>>>> + { >>>>>> + .compatible = "pci1912,0014", >>>>> >>>>> No need to add the compatible to the driver. Just use the existing compatible as >>>>> fallback in the binding/dts. >>>> >>>> ??? >>>> >>>> Sorry but this is insane, in no world a standalone PCIe USB controller could be qualified as >>>> compatible as a pciclass,0604 slot. >>>> >>> >>> AFAIU, 'compatibility' implies that the driver can safely fallback and would >>> still work. If we add dedicated compatibles for each endpoint devices, then we >>> will just keep adding forever. Powering up a PCIe slot and an endpoint device >>> are conceptually same. >> >> We're not speaking about driver here, but about compatible string which describes >> a device, a PCI endpoint and a PCIe slot are 2 very different devices that are >> nowhere compatible. >> >>> >>>> Technically it would work just fine, but "compatibility" has a meaning.... >>>> >>> >>> I view compatibility interms of device operation, not device as a whole. But >>> sure, I could be wrong. If the DT maintainers say so, I won't insist. >> >> In the actual way it's defined _today_, the "slot" and "endpoint" power up schemes are >> compatible, but I hope the slot bindings will get much more features to describe the >> real world slots power properties. And no, endpoints will definitely not have the same >> features as slots, using it as a fallback today is an error. >> >> On the other side, adding a "simple-pci-endpoint" compatible that enables any supply >> and clock would be a good solution, if the DT maintainers agrees of course. >> > > We do have a 'pci-host-cam-generic' compatible. So we can also have something > like 'pci-pwrctrl-generic' IMO. I don't want to into this route, I just want to powerup the USB3 controller on the Pocket S2 gaming device, not spend 6 months into _not_ modifying a driver compatible list. All this feels bulky, who a pci device would be compatible with something like 'pci-pwrctrl-generic' we're speaking about a pci device, not a power control device. It's nowhere similar to the 'pci-host-cam-generic' situation, this describes well defined host controller interface. Neil > > - Mani >