From: Vasily Averin <vvs@openvz.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
kernel@openvz.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH mm] tracing: incorrect gfp_t conversion
Date: Sun, 8 May 2022 01:28:58 +0300 [thread overview]
Message-ID: <8b1cfefa-da7d-3376-cf04-1ff77dab8170@openvz.org> (raw)
In-Reply-To: <20220507123728.f20d977eba9fbb66bddee722@linux-foundation.org>
On 5/7/22 22:37, Andrew Morton wrote:
> On Sat, 7 May 2022 22:02:05 +0300 Vasily Averin <vvs@openvz.org> wrote:
>> + {(__force unsigned long)GFP_KERNEL, "GFP_KERNEL"}, \
>> + {(__force unsigned long)GFP_NOFS, "GFP_NOFS"}, \
>
> This got all repetitive, line-wrappy and ugly :(
>
> What do we think of something silly like this?
> --- a/include/trace/events/mmflags.h~tracing-incorrect-gfp_t-conversion-fix
> +++ a/include/trace/events/mmflags.h
> @@ -13,53 +13,57 @@
> * Thus most bits set go first.
> */
>
> +#define FUL __force unsigned long
> +
> #define __def_gfpflag_names \
> - {(__force unsigned long)GFP_TRANSHUGE, "GFP_TRANSHUGE"}, \
> - {(__force unsigned long)GFP_TRANSHUGE_LIGHT, "GFP_TRANSHUGE_LIGHT"}, \
...
> + {(FUL)GFP_TRANSHUGE, "GFP_TRANSHUGE"}, \
> + {(FUL)GFP_TRANSHUGE_LIGHT, "GFP_TRANSHUGE_LIGHT"}, \
I think it's a good idea, and I regret it was your idea and not mine.
Should I resend my patch with these changes or would you prefer
to keep your patch as a separate one?
Thank you,
Vasily Averin
next prev parent reply other threads:[~2022-05-07 22:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 4:46 [PATCH] percpu: improve percpu_alloc_percpu event trace Vasily Averin
2022-05-06 7:52 ` Vasily Averin
2022-05-06 19:29 ` [PATCH v2] " Vasily Averin
2022-05-11 2:33 ` Roman Gushchin
2022-05-11 5:11 ` Vasily Averin
2022-05-11 17:30 ` Roman Gushchin
2022-05-15 22:06 ` Steven Rostedt
2022-05-06 20:38 ` [PATCH] " kernel test robot
2022-05-07 14:51 ` Vasily Averin
2022-05-07 19:02 ` [PATCH mm] tracing: incorrect gfp_t conversion Vasily Averin
2022-05-07 19:37 ` Andrew Morton
2022-05-07 22:28 ` Vasily Averin [this message]
2022-05-07 22:48 ` Andrew Morton
2022-05-07 23:00 ` Andrew Morton
2022-05-08 20:37 ` Matthew Wilcox
2022-05-08 20:51 ` Joe Perches
2022-05-11 7:20 ` [PATCH mm v2] " Vasily Averin
2022-05-15 22:09 ` Steven Rostedt
2022-05-16 20:55 ` Andrew Morton
2022-05-09 21:06 ` [PATCH] percpu: improve percpu_alloc_percpu event trace Steven Rostedt
2022-05-10 4:22 ` Vasily Averin
2022-05-10 14:16 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b1cfefa-da7d-3376-cf04-1ff77dab8170@openvz.org \
--to=vvs@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=kernel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®