From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D349030FF21 for ; Mon, 8 Jun 2026 02:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780887008; cv=none; b=LlAIhgbcauYAXvFa4H9Iq3oA2TE239t347eu2oxNssVFS02JqMBZM/r8y3UPooOcahPgBZnP9IiDXrXjSzzHjP+etobprWaYLEVb9ePgzgoyM7CvfLu47YnlnXfBUT33Xy/Ru0ucoE9Ekpzq3EQFsZMR+LTw7JiSchECq3XegeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780887008; c=relaxed/simple; bh=491fWt55/N2aTx44vs9X6kBKZdkQr3bM+n0tnZ90BXg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G6HFoma+ufgP+qdcKIJULTbtfxZIiW8UKPS6DoOhg4WM5tRiqUBLlSg0kcy1wrno3hLWEGO3MbFbOh1/daneldM54YBATnriKdu18InrjbdOP+s7eAi9CA0Wwy3ZJ31JuU4qArYQpSSzsQpPn+PIOa3DSf3+V3n2coMveNjxpDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b=MGTsitXG; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b="MGTsitXG" Message-ID: <8b2318ff-d07c-4c2d-9c2d-ef7c5c763096@packett.cool> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=packett.cool; s=key1; t=1780886993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=om3kMyjepA1gbqPe5vEK7VOqgLsCQEKydpPF0v4/Fwc=; b=MGTsitXGrXbEf9LiDSGBLKIMTNZZCYtXzz8LKWu7cOEAhNE3pMzPeHTjJAgORivqI7b2lw GL1nsLfYT4+W0KRhVJiioeeg5sdfGWjL3y5bqlN+CkX8U6wIQCCC/HKjE7KnFkuFZAS6+Q F8R5uEHL+Hh+ljff00x/8rb+0XGfXRM9syD7eX3/GhkuhFvyxaWy8eWKoZc75y4WQ3kMkm q/5SI1m3+2T7qtlgfDLumqLQAf7pV4WFKED6d+5/MOdlYc7+6PN7M0AbT024IQ72ju60ua 6v3nYJ3vtsKrlhBVT8lAeumvZQrO8DZAHtX1/Og7N5krHwj5tVr4q1EF8TW2Pg== Date: Sun, 7 Jun 2026 23:49:41 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 2/3] ASoC: qcom: q6apm-lpass-dais: Add MI2S clock control To: Mohammad Rafi Shaik , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla References: <20260608023011.942228-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260608023011.942228-3-mohammad.rafi.shaik@oss.qualcomm.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Val Packett In-Reply-To: <20260608023011.942228-3-mohammad.rafi.shaik@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 6/7/26 11:30 PM, Mohammad Rafi Shaik wrote: > Add support for MI2S clock control within q6apm-lpass DAIs, including > handling of MCLK, BCLK, and ECLK via the DAI .set_sysclk callback. > Each MI2S port now retrieves its clock handles from the device tree, > allowing per-port clock configuration and proper enable/disable during > startup and shutdown. > [..] > @@ -297,6 +373,59 @@ static const struct snd_soc_component_driver q6apm_lpass_dai_component = { > .remove_order = SND_SOC_COMP_ORDER_FIRST, > }; > > +static int of_q6apm_parse_dai_data(struct device *dev, > + struct q6apm_lpass_dai_data *data) > +{ > + struct device_node *node; > + int ret; > + > + for_each_child_of_node(dev->of_node, node) { > + struct q6apm_dai_priv_data *priv; > + int id; > + > + ret = of_property_read_u32(node, "reg", &id); > + if (ret || id < 0 || id >= APM_PORT_MAX) { > + dev_err(dev, "valid dai id not found:%d\n", ret); > + continue; > + } > + > + switch (id) { > + /* MI2S specific properties */ > + case PRIMARY_MI2S_RX ... QUATERNARY_MI2S_TX: > + case QUINARY_MI2S_RX ... QUINARY_MI2S_TX: SENARY is also a thing these days btw.. ~val