From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C17A93672B8 for ; Thu, 2 Jul 2026 08:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782980878; cv=none; b=ZHbZ6+1PVHUEOn+UCm0KUtSGVPHb7A+oBspctoMedVAkA6j388CZE7eNaw2Fwf3ZBANdP0S0CXB7j2wnH/SVVjaB2FXSqSh+/2mGgoBAAtqKEakLDOXbK8PhB6eTfSq2ZXpFfgWofUkyfhqT/dicFVLvaBAfESo4mc/p7y6prr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782980878; c=relaxed/simple; bh=mC4x6or/X+5NN6lpoYhoGSnv/sjtQL9GcnsD3yHxQ2Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HrcgzgB+MuJmEOFJNqT0rvG4zSboE+U9qv+2F3e3ahT7E9VhpJzmcN61FaS01NRUTDAUvkdHM7DIblS5DPZxzQ5OFdRdrguZirRaevtN0xtLBDJJiJNx4d1RbE9XruEUoixzqqvW2iKCu1LaqyteOKa6BLog6o6Weso1on1Jano= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cSKnM9B1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VLS4kR3M; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cSKnM9B1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VLS4kR3M" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6621KGlV3009470 for ; Thu, 2 Jul 2026 08:27:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1HVkKpzQdbeQaZnyAkJaHwqYV0JX9ZR+ROJzieyYOnE=; b=cSKnM9B1WyHdngTC fjt+oN3laX3gp6i8AAUSLqfeS15h/9eP02nXyfgH89pGxW3FWBkfVXu+a0A7+loF aU0CSMYNYppaXOQg8Ua73+svfTsCf6j39bFsPyoMGB8qbr6gJSo1/ml9Ity4h4q5 rooV+DkrBbnHaUXY+Fqc4LY/9WZG6AwXTDp14DkU902LHi4uAmCgXFhRwPPgleC6 j+3nMg/GRYYx5DJYyIxGWQ5N+6RgeSMf3pMR+slNVs9kAHPwrD3zOuIF1IwnUub9 IDn7KPEXNPUfprW7haxToUZ1CuMymnCmp3lpqxNrNQB7dQ7O0NSBLaMIP4+iRxNa c+Z3VA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f579ru1cm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 08:27:49 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c88ad1558f4so2277663a12.2 for ; Thu, 02 Jul 2026 01:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782980869; x=1783585669; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1HVkKpzQdbeQaZnyAkJaHwqYV0JX9ZR+ROJzieyYOnE=; b=VLS4kR3MwjErOVkHHQY2mEjNA19lgZ6YTzXB958/aK1KYdt/37FLvDTISmYUrUJEfj lkkkHWg1773YqzG6G/n4orknxtMckg5YmM++zQ6grMa3wSrpj40oPIjo5RCuNwQJMSQb cHrUrHfC2cxXQD77L46p15WBo7jJ4wxKtExzBGxyzgJ7Ye/yLmsrMickyLtEr3uzpkgY yJtd25KthyIpwTZpEPRnzZkj7Jdu/TzelofeJA75SGMXP/56We0Gxz59sH1ZwNA4lTu2 0FU1Ht0Vm/rI7DjDcSzqaEg6V/EXJPrjLRoQFPlp1TdiTdRKV10J5whUJn/icENlNwAz vP+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782980869; x=1783585669; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1HVkKpzQdbeQaZnyAkJaHwqYV0JX9ZR+ROJzieyYOnE=; b=ZeZ9QlXyXjiOKmmJTxLLJJPfCftS+rheub3CZ5A2vC2LPdyWnX5OkFvWgJOi68LE8+ gHhTYJ4eK3iRZUJtge5s4aFyEugr2PnSZ6XNgk26RHyncp9dSZUeOLbigLqLOvKJPWfQ i4KozQ6RMR/ArtqQab8AyScj0I4a3dyahDLeNwOkAMgGIHd8zxQ/YVeL9dfIFvm8GVDc EO+GugO496qVYuV44ZSgjrz+m7jxG8kNGgvW1OQC9mU+ThMNJR5lMSUkQ6y1dzWQChj1 cub7RhSrhjo0RckXO5TQjY7zbiv+NG1pGD2S9jEMfsbhMWccCkujCcCAHLn3nQO1gs/E ja8Q== X-Forwarded-Encrypted: i=1; AFNElJ/Pa7e+LsxgdrqaSK/LtmmAHgQnYgfJx4mM+w0Le/iIb/3m4XBwPFNiw5+ECZ8cIEQzo7DyuUOiR+5pm5A=@vger.kernel.org X-Gm-Message-State: AOJu0YwVyf4lwUE2u9NeIOQNjl8kOCfBk7x+JqL1uy20taLkdRJ/swc8 oFMZ3WMImoLlxEVO5BYelm5hONCJdcQBaOtE2dWvcKPnWJaT2kBdG30U1ZNbgbrEqZGxiWx/BWO hiRJPA5kW1APKTn45cqGDZ4J8FjrtEZ1gNHi8KCwqk9svnhIct9KwUNdJaPqN2JQZgI0= X-Gm-Gg: AfdE7cnsba6guNygKgKZNZoTPRa508F+yEBKi0GosJTq20rQ3MnkcM1V6h9OpzyAyFZ PewaBC/M9zP0KDCdymJ4hbXkUjZng8RXUNrUyb0VSPldm0bUzC4lJNoHhGoAHf8+KJnoUh9L4SD z5dM2DuVud7u+LJMLiEZ6t/vPn1IWSSwIJxkO0DQK569X6CiWuZsACFxGwPa22rBqgrgS2P5fI9 Kflu/Cv5HE3oQ9o34NXc81ne4gZgRZtXEvAnbwUoXyevw8YtAaLmanteX7upM/vJZKCM09ukPnE onJvROo7XFZ+hjvwFE10HNAgcXPAM2jnuBvMYkzBcABgMUhA+Mzr9KeZDFbgHWmTBhGVI9tGs+H RyIl7L5PgKorVBcOSgcImdDxHass+o0m0iuAZPJjZAGIOY60FykxpvBmf/86yyrnToERY4oWV02 eK3es8c4NE X-Received: by 2002:a05:6300:6713:b0:3b2:8675:4866 with SMTP id adf61e73a8af0-3bfed471c52mr6055785637.31.1782980868657; Thu, 02 Jul 2026 01:27:48 -0700 (PDT) X-Received: by 2002:a05:6300:6713:b0:3b2:8675:4866 with SMTP id adf61e73a8af0-3bfed471c52mr6055757637.31.1782980868273; Thu, 02 Jul 2026 01:27:48 -0700 (PDT) Received: from [10.133.33.211] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c9e8f5c2836sm899047a12.13.2026.07.02.01.27.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 01:27:47 -0700 (PDT) Message-ID: <8b29a6f4-0742-46f3-bc86-defa6e0faeae@oss.qualcomm.com> Date: Thu, 2 Jul 2026 16:27:44 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] wifi: ath12k: fix channel list copy on big endian To: Alexander Wilhelm , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260629-fix-channel-list-copy-v1-1-5ab826c46d7c@westermo.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260629-fix-channel-list-copy-v1-1-5ab826c46d7c@westermo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDA4NyBTYWx0ZWRfX1pLEMj5LceCT ZFyPSmgUsEbMHKay1kBIdMqKKZeW2Duo9KWc44B1Y54x9qGjsfHUItNF7svhVeslpUwRA5yR4nQ qRO+k0XeZhdk8jHKjf3NC7jLxMq5qMOyunG+1ELRKKBRJxOOdYK61gxPisiBCPV/d3XwGxj92ve 4NiIXmSEmYAM6f+JY9sCNorRIFoPCjBFcINYvEOdBcgmNwduMHxVJGV3JGj8HS32jN3LCnVpbxl dQLgkS0Q9/slaQUCeJ4mlTzwUTnKRue7FXSFm0jGgTg20mS29pskXbzyTm3XJS5Uq7ncyqJHLWT rcqJbN/Bc4OHY78T+gGQE61BaAsgo43o+Q/LC2N5+DKeffhYFQkA6+lAq+Fn2rKeRJ9wGMmgaPS LPEbaUowkjgECH2BMlzekQuHUpVZndN0aqoclhvGTcmSADpG1WiszU9EcdYehKDYiy2vK+uDPtT vw3pgznDzuRzvY9L5qg== X-Authority-Analysis: v=2.4 cv=X8pi7mTe c=1 sm=1 tr=0 ts=6a462105 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=N9GNhs4bAAAA:8 a=ywX3x0iTvHv4trEmZJsA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=PZhj9NlD-CKO8hVp7yCs:22 X-Proofpoint-GUID: l1ZvyTjAIhk-SKchU73Bof6_SnOSRbA3 X-Proofpoint-ORIG-GUID: l1ZvyTjAIhk-SKchU73Bof6_SnOSRbA3 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDA4NyBTYWx0ZWRfX0BM8kfrL2SmD xpY5N7mIzEEmDDZiNjkiG6UBkzlZXFsvK729RFWD8HKFvzZCVa17MeOJruiF46CleY39ImrzWpM 9EIjKncAd1R0yyzHuyRyVjhoIZd1zWY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020087 On 6/29/2026 3:46 PM, Alexander Wilhelm wrote: > The ath12k_wmi_scan_req_arg structure defines the channel list in > CPU-native order, while wmi_start_scan_cmd expects the values in > little-endian format. The simple memcpy causes the hardware scan to fail on > big-endian architectures. Set __le32* type for the tmp_ptr and swap channel > values to support both architectures correctly. > > Signed-off-by: Alexander Wilhelm > --- > drivers/net/wireless/ath/ath12k/wmi.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c > index 65a05a9520ff..9e1d3c662852 100644 > --- a/drivers/net/wireless/ath/ath12k/wmi.c > +++ b/drivers/net/wireless/ath/ath12k/wmi.c > @@ -2571,7 +2571,8 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar, > struct wmi_tlv *tlv; > void *ptr; > int i, ret, len; > - u32 *tmp_ptr, extraie_len_with_pad = 0; > + __le32 *tmp_ptr; > + u32 extraie_len_with_pad = 0; > struct ath12k_wmi_hint_short_ssid_arg *s_ssid = NULL; > struct ath12k_wmi_hint_bssid_arg *hint_bssid = NULL; > > @@ -2656,9 +2657,10 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar, > tlv = ptr; > tlv->header = ath12k_wmi_tlv_hdr(WMI_TAG_ARRAY_UINT32, len); > ptr += TLV_HDR_SIZE; > - tmp_ptr = (u32 *)ptr; > + tmp_ptr = (__le32 *)ptr; > > - memcpy(tmp_ptr, arg->chan_list, arg->num_chan * 4); > + for (i = 0; i < arg->num_chan; i++) > + tmp_ptr[i] = cpu_to_le32(arg->chan_list[i]); > > ptr += len; > > seems hint_s_ssid and hint_bssid at the last also need the endian conversion? > --- > base-commit: 702847e8cfd51856836a282db2073defd7cfd80c > change-id: 20260317-fix-channel-list-copy-cef5cad24fb6 > > Best regards,