From: Michael Walle <michael@walle.cc>
To: Lee Jones <lee.jones@linaro.org>
Cc: Robert Marko <robert.marko@sartura.hr>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: simple-mfd-i2c: Select MFD_CORE to fix build error
Date: Tue, 02 Nov 2021 13:28:51 +0100 [thread overview]
Message-ID: <8b2b9e6f61107b79f93dd191c3fc2918@walle.cc> (raw)
In-Reply-To: <YYEeS8gz8TBW63X8@google.com>
Am 2021-11-02 12:17, schrieb Lee Jones:
> On Tue, 02 Nov 2021, Robert Marko wrote:
>
>> MFD_SIMPLE_MFD_I2C should select the MFD_CORE to a prevent build
>> error:
>>
>> aarch64-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function
>> `simple_mfd_i2c_probe':
>> drivers/mfd/simple-mfd-i2c.c:55: undefined reference to
>> `devm_mfd_add_devices'
>
> What is your use-case?
>
> How are you enabling this symbol?
Mh? drivers/mfd/simple-mfd-i2c.c is using devm_mfd_add_devices which
is provided by drivers/mfd/core.c. So select MFD_CORE is clearly
missing here, no? I mean most of the MFD drivers do a "select MFD_CORE".
-michael
next prev parent reply other threads:[~2021-11-02 12:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 10:04 Robert Marko
2021-11-02 11:17 ` Lee Jones
2021-11-02 11:20 ` Robert Marko
2021-11-02 11:35 ` Lee Jones
2021-11-02 11:37 ` Robert Marko
2021-11-03 7:33 ` Lee Jones
2021-11-02 12:28 ` Michael Walle [this message]
2021-11-03 7:32 ` Lee Jones
2021-11-03 7:36 ` Michael Walle
2021-11-24 15:49 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b2b9e6f61107b79f93dd191c3fc2918@walle.cc \
--to=michael@walle.cc \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.marko@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®