From: Tim Lunn <tim@feathertop.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
KyuHyuk Lee <lee@kyuhyuk.kr>, Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Chris Morgan <macromorgan@hotmail.com>,
Tianling Shen <cnsztl@gmail.com>, Jagan Teki <jagan@edgeble.ai>,
Ondrej Jirman <megi@xff.cz>, Andy Yan <andyshrk@163.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board bindings
Date: Tue, 16 Jan 2024 13:00:15 +1100 [thread overview]
Message-ID: <8b31ae29-b88b-4ded-95b4-c2d9bbad24e1@feathertop.org> (raw)
In-Reply-To: <b4f97202-43ec-4f04-af95-b1ccd3b5d203@linaro.org>
On 1/16/24 01:58, Krzysztof Kozlowski wrote:
> On 15/01/2024 15:51, KyuHyuk Lee wrote:
>> The vendor in ODROID-M1 is hardkernel, but it was incorrectly written
>> as rockchip. Fixed the vendor prefix correctly.
>>
>> Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
>> ---
>> Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> You need to start testing your patches. Your last M1 fails as well in
> multiple places.
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> The DTS change will break the users, so would be nice to mention this in
> its commit msg.
I notice there are a couple of other boards that incorrectly use
rockchip as the vendor also:
- const: rockchip,rk3399-orangepi
- const: rockchip,rk3568-bpi-r2pro
Perhaps these should also be fixed at the same time?
Regards
Tim
>
> Best regards,
> Krzysztof
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-01-16 2:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 14:51 KyuHyuk Lee
2024-01-15 14:58 ` Krzysztof Kozlowski
2024-01-15 15:48 ` KyuHyuk Lee
2024-01-16 2:00 ` Tim Lunn [this message]
2024-01-16 7:24 ` Krzysztof Kozlowski
2024-01-16 8:31 ` Heiko Stübner
2024-01-16 19:26 ` Rob Herring
2024-01-16 19:55 ` Heiko Stübner
2024-01-17 10:03 ` Tim Lunn
2024-02-13 19:31 ` Heiko Stuebner
2024-02-14 4:00 ` Tim Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b31ae29-b88b-4ded-95b4-c2d9bbad24e1@feathertop.org \
--to=tim@feathertop.org \
--cc=andyshrk@163.com \
--cc=cnsztl@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kyuhyuk.kr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=megi@xff.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®