From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D367630AD10 for ; Thu, 9 Apr 2026 10:16:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775729783; cv=none; b=FtDc/eo2b0zl5UWSAOEvYbhQvl1mGTVpVI4u6+WiicaV9pcbyuW+0w84I4TqlTL9gdTXbMlqMlwJy/zFP2aR5VJ0FRAhZ/T5Ues7WKohZHnvKnoYPckxxDmU0EBNuXxbfGYqr6N03uRENwrBMup+uGVbKkducBunLCW594ow5vQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775729783; c=relaxed/simple; bh=tPoH8ZTaoSLNvELAvyvP8MQ/Rt54p7t7LAvAWJqKfs8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MtAUGyojHxyOFhQVNqIo1ZXWdQw7jRFUxGBm0DquNwwVwMdEDjc5eahxWSuJ081nI22vaLZ8kEm/IBivbY0gdzeNowaqf5IwQQnVT7Qm5mUUEdbi5H/Svx0SpP1ixlt4567lUoozjjj2ZHuebCHufRcQzUgTRTUpuPltMNg9e/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hABVwwfF; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cZGwbLtp; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hABVwwfF"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cZGwbLtp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775729780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Keu4pEUQjOK9n4bWIn3PAdEj+U9xTzXwK6+g1cFUBIM=; b=hABVwwfFRTTOrGutiZ5m4FsyaEpW4K2Wqd1YLFe49CH3Nz38teUIhQ3qupBd7YKodUV2sC xZan+5TL0OKCVw3qW0pZOT2c+pfORXyzchhxC6M/yRtUAyl1U74QY3nnOrMjhm4ArfwjId TzK0hEk7oJpAx2yrKXjxjCu3Pc7Ay7Y= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246--5GEHAAtPl-cFh0F4t8Mrg-1; Thu, 09 Apr 2026 06:16:18 -0400 X-MC-Unique: -5GEHAAtPl-cFh0F4t8Mrg-1 X-Mimecast-MFC-AGG-ID: -5GEHAAtPl-cFh0F4t8Mrg_1775729778 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-43d177fb157so861973f8f.0 for ; Thu, 09 Apr 2026 03:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775729777; x=1776334577; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Keu4pEUQjOK9n4bWIn3PAdEj+U9xTzXwK6+g1cFUBIM=; b=cZGwbLtpvWToJ7J2HwluoH6kfOj+m0viMuNDSnJvEeGjMZpMooAFRLFfFkc+TfL6PA HSJ0cArGrddJTK6sJm38Hwzn4I8hqAQ0LKRpHlwDHNr32ZRRTeVDLW4VeCeZAx6XDvij Jc0OUJNu23xXaqfU8zWJiUrgnfQRv6DOM5JqATbORRNBEEpMJ/jOYaanHjEkc6Fksf2L QemEa39+sn8Zw+6sns7r1GNbgjKPqdevyjrbm4foA5ld28/LivMop4Ew/mQgfgrlm+9h eUPD2hc5Smqxsw2zumnQVipF2JK3LoW5T3cUZD9DfkvtsHHVaaW/k/TWw54sI5TY4MdD x68A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775729777; x=1776334577; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Keu4pEUQjOK9n4bWIn3PAdEj+U9xTzXwK6+g1cFUBIM=; b=XWdS2HUvf0HSMGxIeo/YXjljwJokk5ZN4z81jqmP5bSncWapuovLQ/cGot5NXTbM3m 2MS3jFu58RcNZ8AdGewKbG5afKvxB/AGuJdXuwMMbm0BLmTrFjrRXT/Mo0HkVp/EGaOB a1UBGTZicK1vRQzMY2CVhOeKmoY2L5HFilNcg4yTXTIbjMgm/evGHakIjAXChL5+uPz3 cs+MeTbsTwfRWT42hjY7sPa5xuEbOYxb/aXmau4OHJMUdRHqTCFjtLXK0YPunxtVkIeo LzLbw2VclwykIJbf0Rwf+kdBymVoVKCSnPq2Z+aQiejJVyPVux/3jYfqKo150k7n0ceV 5R0w== X-Forwarded-Encrypted: i=1; AJvYcCUpoX25pLKIfUTGjilZxHCknr5CCtK5dXxOG9BK8VqKnBQZ+RxwgWWs23oipxIoYzVXYziY9dZLIhr8ges=@vger.kernel.org X-Gm-Message-State: AOJu0Yw02aWqGAzedNYIGUpGym3Krkl/Zyw5/p//tKJZk1Mj5EHMaVQi PXFKe9Ez8yaQNOVk+wLVJ16NoKAYSpAQmBmkzTgYlGYDLCb2E7w4fiO7zhbqM9u+BSciX9bp5Sw /ab4LbudVLj51SDhvNiE4UjYmb0G9o7bim9Db1u2XWTSyyiKdA6qxvktpVsveumG4C0ywQy97yw == X-Gm-Gg: AeBDievIvp+0RTu3YvCjmpBz8xuy57vw3PdJ/MXUxr5ddIe0XtUmrA//CbCDewzY9Q7 y9QGRmXBiMnUtFL1owDNcQbz+3+8ylHcm0Az+t85E1QDMpQ7ahsdUUEGgoCRiPNh5JJPpEIodds W71sYbHH9UwOdG9pYJ0iXDAvnCe4acQ/563c4PWU+i5ZuWgbJEI4Tkg4eaXDxaho8XaZH/4z2TZ Pw2zOUcJcwOxs9oevNZL1d1L3NcHDG48uAFetQhLR/ANSV/VBnqxO0Mg5kWfva6jYn+964wGcYa 4rOxTVhQ9XixSZiqWo0+3uKs5EyPtKGqbXXR9TpxV+bzRtBQlpe+p8logImsyo9jebeKbreWcBz 1+47IFzdBo1RyeS4LmlXgy9tqLpZ6Bphw3Lmiqj4BwFK0m8Uz3UcpcpFM X-Received: by 2002:a05:6000:22c4:b0:43c:f66e:f31 with SMTP id ffacd0b85a97d-43d5a18bd4bmr3637621f8f.27.1775729777128; Thu, 09 Apr 2026 03:16:17 -0700 (PDT) X-Received: by 2002:a05:6000:22c4:b0:43c:f66e:f31 with SMTP id ffacd0b85a97d-43d5a18bd4bmr3637585f8f.27.1775729776698; Thu, 09 Apr 2026 03:16:16 -0700 (PDT) Received: from [192.168.88.32] ([150.228.25.243]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2a6f1esm64126034f8f.2.2026.04.09.03.16.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2026 03:16:16 -0700 (PDT) Message-ID: <8b324f8c-f4f8-4e90-b5d6-9b87ec3daf2b@redhat.com> Date: Thu, 9 Apr 2026 12:16:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 2/2] r8152: Add support for the RTL8157 hardware To: Birger Koblitz , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chih Kai Hsu References: <20260404-rtl8157_next-v7-0-039121318f23@birger-koblitz.de> <20260404-rtl8157_next-v7-2-039121318f23@birger-koblitz.de> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260404-rtl8157_next-v7-2-039121318f23@birger-koblitz.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/4/26 9:57 AM, Birger Koblitz wrote: > @@ -6534,8 +6842,11 @@ static void rtl8156_up(struct r8152 *tp) > ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, > PLA_MCU_SPDWN_EN); > > - ocp_word_clr_bits(tp, MCU_TYPE_USB, USB_SPEED_OPTION, > - RG_PWRDN_EN | ALL_SPEED_OFF); > + ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN); AI review notes that the above leads to 2 consecutive: ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN); with slightly different formatting, likely C&P error?!? I think this is better handled with a follow-up, if needed, as I don't see any possible issue out of it. Other AI comments look not relevant. /P