From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1956091AbdDZGdB (ORCPT ); Wed, 26 Apr 2017 02:33:01 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:58443 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1951949AbdDZGcw (ORCPT ); Wed, 26 Apr 2017 02:32:52 -0400 Subject: Re: [PATCH] iio: hid-sensor: fix return of -EINVAL on invalid values in ret or value To: Colin King , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Srinivas Pandruvada , Song Hongyan , hock.leong.kweh@intel.com, linux-iio@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170419143548.14130-1-colin.king@canonical.com> From: Jonathan Cameron Message-ID: <8b33d431-4c3b-fb94-539c-a35cb3a123cc@kernel.org> Date: Wed, 26 Apr 2017 07:32:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170419143548.14130-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GH Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/17 15:35, Colin King wrote: > From: Colin Ian King > > Ensure that when an invalid value in ret or value is found -EINVAL > is returned. A previous commit broke the way the return error is > being returned and instead caused the return code in ret to be > re-assigned rather than be returned. > > Fixes: 5d9854eaea776 ("iio: hid-sensor: Store restore poll and hysteresis on S3") > Signed-off-by: Colin Ian King Given the 'fun' we have had with this on recently Srinivas, could you sanity check what looks like an obviously correct patch? I'm being overly paranoid for a while ;) Jonathan > --- > drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c > index 1c0874cdf665..aeb09a85d7a8 100644 > --- a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c > +++ b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c > @@ -230,7 +230,7 @@ int hid_sensor_write_samp_freq_value(struct hid_sensor_common *st, > ret = sensor_hub_set_feature(st->hsdev, st->poll.report_id, > st->poll.index, sizeof(value), &value); > if (ret < 0 || value < 0) > - ret = -EINVAL; > + return -EINVAL; > > ret = sensor_hub_get_feature(st->hsdev, > st->poll.report_id, > @@ -283,7 +283,7 @@ int hid_sensor_write_raw_hyst_value(struct hid_sensor_common *st, > st->sensitivity.index, sizeof(value), > &value); > if (ret < 0 || value < 0) > - ret = -EINVAL; > + return -EINVAL; > > ret = sensor_hub_get_feature(st->hsdev, > st->sensitivity.report_id, >