From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D788EC4167D for ; Thu, 2 Nov 2023 08:02:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234532AbjKBICN (ORCPT ); Thu, 2 Nov 2023 04:02:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234386AbjKBICL (ORCPT ); Thu, 2 Nov 2023 04:02:11 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56E7B12C; Thu, 2 Nov 2023 01:02:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 19C12219FA; Thu, 2 Nov 2023 08:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698912122; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/brGDXSMfRavGLZk4X1Kx601f4jreCwXXA9x4uQvWNY=; b=ThIUncR7PRELu5w928CgSa03If3wOhs85zOnES/hoGFSB4+pXhwygBXrzfG+SqtzRzDxOW n0K8d6zU6VuSUn6ssg0Dm8QeTleXkMMMi8/XoPGTmmOo3c+M0AIHi21AWdhR+QCfgBMUEE iPUI5d5rmbp8BSuzmWeFzOSMFjG7yc0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698912122; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/brGDXSMfRavGLZk4X1Kx601f4jreCwXXA9x4uQvWNY=; b=doLQAYV7jOpnbplof03/yxesy1ZGE+qa5Rn+4Qga9qZN4w9Fag5iNvZsDomXTAS5DaFAlP bfAP9Z5cfpfWI5BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9C70113584; Thu, 2 Nov 2023 08:02:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id B+AdJXlXQ2W4PwAAMHmgww (envelope-from ); Thu, 02 Nov 2023 08:02:01 +0000 Message-ID: <8b367642-1669-4c61-b40f-17030e19a2e0@suse.de> Date: Thu, 2 Nov 2023 09:02:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/13] scsi: fnic: Use fnic_lock to protect fnic structures in queuecommand Content-Language: en-US To: Karan Tilak Kumar , sebaddel@cisco.com Cc: arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com, mkai2@cisco.com, satishkh@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231027180302.418676-1-kartilak@cisco.com> <20231027180302.418676-12-kartilak@cisco.com> From: Hannes Reinecke In-Reply-To: <20231027180302.418676-12-kartilak@cisco.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/23 20:03, Karan Tilak Kumar wrote: > fnic does not use host_lock. fnic uses fnic_lock. > Use fnic lock to protect fnic members in fnic_queuecommand. > Add log messages in error cases. > > Reviewed-by: Sesidhar Baddela > Reviewed-by: Arulprabhu Ponnusamy > Signed-off-by: Karan Tilak Kumar > --- > drivers/scsi/fnic/fnic_scsi.c | 28 +++++++++++++++++++++++++--- > 1 file changed, 25 insertions(+), 3 deletions(-) > Please merge this patch with the previous one which removes the use of 'host_lock', seeing that you need a lock after all. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman