From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010054.outbound.protection.outlook.com [52.101.61.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C62613EDAB5 for ; Wed, 6 May 2026 15:05:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.54 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778079948; cv=fail; b=ij43wGGmiDPLbCI2aicIvjUC7wOGZaUWQNZNuVrht81qZfGZc/fGZO0vQO9hMNUKwPYpEw4h1AwFjquQ+xE8MRNTPJm1PWT3GxP/9RoCQPw3G5O21oonb2QgN48Qlw7p6oyTn2n2yUnoVxppdt6r1bG7G7o1sUnl2pYgRewWyyo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778079948; c=relaxed/simple; bh=Pv6ruyPDqmONCkpzHkLmk0KXyhey3oj5JmONPnuMTiM=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=PK7Fzg4X3oLLGOFntUTqP0HSOQuNuGifJLfm6rC9RVUskI1mT8KIPf2nbF0YGfhg7L69fAy397M444hxXoGhCSdwL3jTzxoALAWjtALEKZYXyW5T4nrHfSnQOxYBd9OwdM3uoltG2gXqv0xA7GsEqo5kdryjLhu01JX6Svv+6C4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=V/IeBfT3; arc=fail smtp.client-ip=52.101.61.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="V/IeBfT3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HG8AcxYBxbebN01H5QDmYFar0Bmp07RQ9xQB0SzJVAWeJ9zuVVNa4KKVP6Sd/1IwyVWAIrEayrAP2OzRq1ZDa2bbvkzJGqqOE+i68IECaVZXlI8bfGfCVSz5FJv6yKjTsSI442CXNYnYyBSj2eS3IXa2UOfxm9jecF5WfVlc7tCww+DOIaDYin/BHISg019o9EFfVcRB2HWcgRLJp/rTsVicDqrYDhWfrxCJpJi8RZc15bcVNy2AQdEeMmu/ZjE+UN3sX8LIKvJQ4d3NeCQAcj+eS31I4+RklD+weSt0MzWdmXJhCOnB1t6vS01lI/7knqWYOknWzAeHunsOFcSAQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9TfiMUeQk9uFZYk12v3m1XulNBvGH46WF9UkYQ4hr98=; b=Wq6y3gQ50wYlao1hXMMvS3Bxg2BalhJBsd0p6i42xu4LxmYQwK3xKYLue+qJ1kUHpTqFwiqBtJKEhoCh+1lDUpKmLeMdVxIF7T57qur0fxliudtIU6ZTUq0VWgSBLz0JimUHvkru2EBDXiMmsW0XtOuid53BBTK/XpZMNKLiCqC6t6RaInYkJfT1lw2v6JiC1IAuOWXALkQBt5py0THcZ5AyR9tuNUW5eY+wRMyOC8iNN4RAexPuV4UQkWNxnAYZNK7+2Rcs2Xv0FegvJ/5SZv1cat/lXyDGmLOAr+/bYN38d6Jxh31X/cn80fptmx25VraOZoqyzr65bizT0eSY7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9TfiMUeQk9uFZYk12v3m1XulNBvGH46WF9UkYQ4hr98=; b=V/IeBfT3z/g+3CRFxj5el+QWaHsa557RLyNJFBgb56KXh7ephecG+90uUlQWH3OTgYaJxa90LPbMhVU2cF1qs3OT1rJnULPNbV6Oq4aF/M4wpb/98I/dHdOnVgXU6WtXPETzBgaVVpLWbmaufjFfuo1p/bBDQ7a2DOwyk8qSwXk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DS1SPRMB0042.namprd12.prod.outlook.com (2603:10b6:8:495::13) by PH7PR12MB6719.namprd12.prod.outlook.com (2603:10b6:510:1b2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Wed, 6 May 2026 15:05:39 +0000 Received: from DS1SPRMB0042.namprd12.prod.outlook.com ([fe80::45f7:30b0:7d91:e262]) by DS1SPRMB0042.namprd12.prod.outlook.com ([fe80::45f7:30b0:7d91:e262%4]) with mapi id 15.20.9891.008; Wed, 6 May 2026 15:05:39 +0000 Message-ID: <8b36ee47-3661-477b-94be-0d83b2273f26@amd.com> Date: Wed, 6 May 2026 10:05:36 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() To: Ben Horgan , linux-kernel@vger.kernel.org Cc: tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, fenghuay@nvidia.com, tan.shaopeng@fujitsu.com References: <20260506082855.3694761-1-ben.horgan@arm.com> <20260506082855.3694761-2-ben.horgan@arm.com> Content-Language: en-US From: "Moger, Babu" In-Reply-To: <20260506082855.3694761-2-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA1P222CA0065.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2c1::16) To DS1SPRMB0042.namprd12.prod.outlook.com (2603:10b6:8:495::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1SPRMB0042:EE_|PH7PR12MB6719:EE_ X-MS-Office365-Filtering-Correlation-Id: b94c52cd-ece8-40ef-d2c1-08deab80ef5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: qlgYFrjecpHmjx3YHSFmJkLOfuI3EFNS6TXWi7MyrfCCoU5FPQiD1iCtJrVSxBpjDrLDgcGNoyqIBIs2nXQ+dn+8EvcPCaAwG0dQDjLKZSmA0hGn9TMecKXXh/V1hOHPQKbmDSk4Otx9dJ/U2LqXbT/yre13xbh6GXtsWLurSPIPz9PEBSXrYGVJtooeQZE9y1xKeGg9h0eVO931+ZvABs2U+aYsI30TUqkWlZcqqFxu00AAyCX+ry+lQzuEKFr0Oq6cPnrJaJl8QDRLRp/brdaKlAaeVBrW/cqZB/FThArBDvT5eGu5bke9y8VDETZ3h8mUxNkXRQmGMsZe8dkbnkx5hmdWOn6mun6ay+bAgCo9KT9jqewf/RAw6mLpN9R8B9XMGZrGo29lSLV2VzSv+RkLBSqHNhUGPAvRyt9FrKHJccoIE63LPPVU0rCht1wUbV+MWaLGnBuDsngp/Fts4tQk5x4NH3X3dNFhYSQ7h5UtQRMxkB8iOcJCkTBgfUznU27UcHoitJOM/cSHLCHea/fQ2g39YfBvnlud05En1IQpl2To2bwksAapBYwakQEVwYn+Xt4aim/jBY0MF4OfhQz1dmFum9UjP/CtAFXvVVGc0iR8R/2VmjYH8nxzyfTO+QdN8SknvLZrBW7jxUQXT+XwGW1EQ4TiW2UM+vHxUY0EcNixJlVwxhqqD7Djhvgp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS1SPRMB0042.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck5WWEdVbDloR09mT0ZDbHVjN1IrazRRSlJjZTJFRDZ5dEkwUFcyQkJBVHRS?= =?utf-8?B?RW9uQ1doV1FwOGsxMG5TWUlvZEhHQlM3ajlmTENldzY1MnRKQlVTTm9oVHRi?= =?utf-8?B?cVNhRXVuVHFndzZqK1FORnNLYjc3MmZlT1Arb1NucXBZbDcwYjgyUmRTOXBG?= =?utf-8?B?TnpuVVRzK2hWL0RJVzFEcWJ2Zm1uZWpmNnY1eUhKZk8yVDdmUFk3ZjJEY0hY?= =?utf-8?B?S1NTQUw4UmxxV003NlBJU0Q4WityNEJ0NFpkVDdpWXN5dlBPZ2F6R0hMSnM5?= =?utf-8?B?SzhYZVJ4aGpQajBWVWY1aWY3VjJFNlBNV0pma29GdVdxM0JnYVRFSzRpN0FD?= =?utf-8?B?SU1QTi9ucDZUaGE5MXhpN3RpZkJ2MjdhT2JtOUlDNFBJTXpaSzhYV2h5eHFU?= =?utf-8?B?Um9BYVVmVUJlaHZjOVJEcjBLbjBVOFQ2aHRobmNqbnZkZ0pHdUhFSXBTK25L?= =?utf-8?B?bklUeDNSMkk0QUxXbytyTjNLclpremhKOWcrRkozWUhZbmx4SGt3SFJyQUJh?= =?utf-8?B?WmhSZytENTNLZTQwdDR1Rklram9selcxZUNObXFLbjRSSmhjek9BRzhvOS9k?= =?utf-8?B?VVd3ZjJSZW1mREdRTnZPN01ZTEZUY1NzSmpRUmxiZWJrN3ozUURSTmpYVy9y?= =?utf-8?B?OWNiL0FzSVVZaDEvSXFTM0ZCQjlLcVF5SlhNVG9DQ0VSUVVVbis5aEhFczZm?= =?utf-8?B?emJubWp3UHBjRzg2bkgzQWZISjd0cXdXNjZmaFBXbU9QRnpmN3o1YXZreWFL?= =?utf-8?B?aFdlbjFaamFtM1VMSmhubGVBVDVOZHVMM1BsaUxSZUMzZFZWOUJaNEpSWHdy?= =?utf-8?B?Q0g3M2tuaFRTZG9FUzJlTDVaS0xtK01QWFd4UmhzS1B0Q1VZZXZXYWJzeTB0?= =?utf-8?B?QUwrWnlaWnVWeDRqamZINGJLSEtOYjRWSS8vVWtTdzNPN2QxbkZ0T05qeFlm?= =?utf-8?B?bUlFZ2VNcHhoV2FlQTMyY0F3dGtJTzV4Qi9VVHFESkJqTUJNQkFFVHBrcjBJ?= =?utf-8?B?dDVkeDZhQW1pcU93aFA1QXpteU9FeGtQeHpJVmFzb1BDUkg5VDJ3M0tSSitU?= =?utf-8?B?Zkc1RXdhci9GWEtYS0JPaUI5UTJ0RkQ3UWNFOEZ4QmlLQ1dhRGN4M0NZSDg0?= =?utf-8?B?Qjg4S3pVeHZ0Q0x2Zmk3VXdsNDRvbFVEdDV5V25GeFR4RnlCVGJ2ZzVHenRl?= =?utf-8?B?dHZvMXZYWjdXbW5NbWNGSnBwMWJlMWNDZVdBalNDTHRSdXlxYk14WUkyS1c4?= =?utf-8?B?UWNsdDB5ck9jNWp4emxkTFNyNzliOEVWREh6MDlGR0RyRnByZ2E0MEpic1VP?= =?utf-8?B?QUVlanZtMVZBaXlBZ09UYXVzRjhLZDBRc2I5WnJldTJvVXZzc21VWDV4VDlE?= =?utf-8?B?ZnZLQXlWQzRFcXhodjYyTUxnLzRzTFZjdlRBRElzM0gxajE1aE1nTmRsNmgz?= =?utf-8?B?Uzd4YkRUMEdqT2d5ZlEyVDBxVnNWeVl2QTNMbTNISGxhNnZ2djhYa3pCb2ph?= =?utf-8?B?VDJidWdQKzdxMzdIR3VYSFZZSnM1cVBIVW56UFpkamhJNkV4L040KzQ3VnVa?= =?utf-8?B?WHE5M3dSMi9pallJVWJvdkVKSWcvamd4YjJaeXpoeVl2OG5OZzRUVUdSQU82?= =?utf-8?B?aHk0b1ZBNFpFM0g3b204WTNiNU5qdksvVlJ6d3VlVVpLQVAwSzlxWnFBMFFm?= =?utf-8?B?L0Rqd0ZWZFh5VGtFRU1YOWUrK1FuQmRuSldMdGJpWjJiMjV2bFRIekptZFFy?= =?utf-8?B?cVY1M1VCZFFzb2JEck1VcXNJRXpPb3JuMWZObUVLUUg2a1N4SmZKRm9MVjVz?= =?utf-8?B?Y2NIOWYrR0lMeWdxNFdVWmFEL3NyN0E4bGxVVzlMMXh5THBuOFZ6WmlkOVg0?= =?utf-8?B?Zld5YmVTc2JLL29hRmVidzh0cUd2ZE1IaFppRzlCcUc2aVk4ZSs4Y1FQYkJm?= =?utf-8?B?RFhPcm5oRTF3L3ZIRWJjMjFraHhnanFMQ2cwcGxCUFpvLzAyWnB0VWMvZmR4?= =?utf-8?B?U2VFSER4cGxOQXZCUUVzWlJzVnlFN3kxR0dpVVZ4M2dFcVB3cVMvbnoreER2?= =?utf-8?B?bisrSG90cWZ3MzB3NC8xdkpkbUpuSGx4MTR4SkQ4THlIaE5SK1lPN00vMDF6?= =?utf-8?B?N2ptU09NdXFlTjNFQUZjVFZPR3poYjM1Vkt5TjZVcHUweVNMeWdSejFRdU5B?= =?utf-8?B?V3RqZ0xkcS8wWHkwSkg1TklNbjcyRGM0a0NQSjlhb1hyZ0w1ZHJqYmdCQkE1?= =?utf-8?B?dWMzdFJmOVFiYW0rL1lnTzVHZXdvTlBVUzdnYUI0cWU4RTRod08wWGFFL1hS?= =?utf-8?Q?/bnNmrCbFB6ExcpSU9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b94c52cd-ece8-40ef-d2c1-08deab80ef5e X-MS-Exchange-CrossTenant-AuthSource: DS1SPRMB0042.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2026 15:05:39.3806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nge/xK8OJVNVjO58NqAJuvZ7qOjQewDb5BM0QnXvv8FNTbb+TyXeNsNQgLVg1bCn X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6719 Hi Ben, On 5/6/2026 3:28 AM, Ben Horgan wrote: > The error path in resctrl_mkdir_event_configs() is unnecessarily > complicated. Simplify it to just return directly on error. > > Signed-off-by: Ben Horgan > Reviewed-by: Reinette Chatre > --- > Changes since v5: > Correct order of the tags > > Changes since v6: > Add missing commit message separator,--- > --- > fs/resctrl/rdtgroup.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c > index 5dfdaa6f9d8f..fb6999178fe2 100644 > --- a/fs/resctrl/rdtgroup.c > +++ b/fs/resctrl/rdtgroup.c > @@ -2333,20 +2333,19 @@ static int resctrl_mkdir_event_configs(struct rdt_resource *r, struct kernfs_nod > kn_subdir2 = kernfs_create_dir(kn_subdir, mevt->name, kn_subdir->mode, mevt); > if (IS_ERR(kn_subdir2)) { > ret = PTR_ERR(kn_subdir2); > - goto out; > + return ret; Minor nit. You can directly return like below. return PTR_ERR(kn_subdir2); Optional, only if there is another version. Thanks Babu