From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Griffin <peter.griffin@linaro.org>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
alim.akhtar@samsung.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
tudor.ambarus@linaro.org, andre.draszik@linaro.org,
saravanak@google.com, willmcvicker@google.com,
kernel-team@android.com
Subject: Re: [PATCH v4 3/4] arm64: dts: exynos: gs101: Add ufs and ufs-phy dt nodes
Date: Mon, 29 Apr 2024 19:30:38 +0200 [thread overview]
Message-ID: <8b3c9d34-15d5-4aac-b725-4cc25e469a58@kernel.org> (raw)
In-Reply-To: <20240429111537.2369227-4-peter.griffin@linaro.org>
On 29/04/2024 13:15, Peter Griffin wrote:
> + ufs_0: ufs@14700000 {
> + compatible = "google,gs101-ufs";
> + reg = <0x14700000 0x200>,
> + <0x14701100 0x200>,
> + <0x14780000 0xa000>,
> + <0x14600000 0x100>;
> + reg-names = "hci", "vs_hci", "unipro", "ufsp";
> + interrupts = <GIC_SPI 532 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&cmu_hsi2 CLK_GOUT_HSI2_UFS_EMBD_I_ACLK>,
> + <&cmu_hsi2 CLK_GOUT_HSI2_UFS_EMBD_I_CLK_UNIPRO>,
> + <&cmu_hsi2 CLK_GOUT_HSI2_UFS_EMBD_I_FMP_CLK>,
> + <&cmu_hsi2 CLK_GOUT_HSI2_QE_UFS_EMBD_HSI2_ACLK>,
> + <&cmu_hsi2 CLK_GOUT_HSI2_QE_UFS_EMBD_HSI2_PCLK>,
> + <&cmu_hsi2 CLK_GOUT_HSI2_SYSREG_HSI2_PCLK>;
> + clock-names = "core_clk", "sclk_unipro_main", "fmp",
> + "aclk", "pclk", "sysreg";
> + freq-table-hz = <0 0>, <0 0>, <0 0>, <0 0>, <0 0>, <0 0>;
> + pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>;
> + pinctrl-names = "default";
> + phys = <&ufs_0_phy>;
> + phy-names = "ufs-phy";
> + samsung,sysreg = <&sysreg_hsi2 0x710>;
> + status = "disabled";
> + };
> +
> + ufs_0_phy: phy@0x14704000 {
Drop 0x from unit address.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-29 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 11:15 [PATCH v4 0/4] Enable UFS on gs101 / Pixel 6 (Oriole) Peter Griffin
2024-04-29 11:15 ` [PATCH v4 1/4] dt-bindings: soc: google: exynos-sysreg: add dedicated hsi2 sysreg compatible Peter Griffin
2024-04-29 17:30 ` (subset) " Krzysztof Kozlowski
2024-04-29 11:15 ` [PATCH v4 2/4] arm64: dts: exynos: gs101: Add the hsi2 sysreg node Peter Griffin
2024-04-29 17:30 ` Krzysztof Kozlowski
2024-04-29 11:15 ` [PATCH v4 3/4] arm64: dts: exynos: gs101: Add ufs and ufs-phy dt nodes Peter Griffin
2024-04-29 17:30 ` Krzysztof Kozlowski [this message]
2024-04-30 11:06 ` Peter Griffin
2024-04-29 11:15 ` [PATCH v4 4/4] arm64: dts: exynos: gs101: enable ufs, phy on oriole & define ufs regulator Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b3c9d34-15d5-4aac-b725-4cc25e469a58@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®