From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CDF12E228D for ; Wed, 31 Dec 2025 21:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767215315; cv=none; b=CXvz6hQ7+BqlYhT1pfEQtll7m5g3fzDE/3tCTm7FPsw4fPP/9kiHvdUH9ukARolVXzptuRMtAV9ww8Z5pla0QVB4iv7O3d4l5Shhc7AWnKJY0g1qIxEDPPJzPTD7Xb+4/272AQupVbOMdsjpAILxCu927pG4Q+vivUNoOxSGfRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767215315; c=relaxed/simple; bh=/fpSGKCMZ84Yv6KlVUKGe8MIPvLGKfxJMy99z/GEhKE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aUV9sRmnAkMHgHA5ykMzLrk9oy7rOqMQxzg3v2f8vs07ov/NWUUBxbwDYY/9c3qYJ6DRUZFiL4iCgSycBpfgNJ7a07IglY2Op9zD42VvNnBz2N7Q1Mtpae55GsMzdgU6U8pG6Nr+PFgsVpLRR13eOAJnxqn73oXgxbBDxKSCvWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Odh0sm/3; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Odh0sm/3" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-4510974a6bbso3371395b6e.3 for ; Wed, 31 Dec 2025 13:08:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1767215311; x=1767820111; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xtR7PK39BaSx2GpuhvAfss4ZTutnP9LImpMPJNr7WtI=; b=Odh0sm/3ewt9g2YwVP7y754mMB6rXILXiYIcxEred0B9OabaFzUy7cldkFiSzkPdHz NX04tc7vFy8/ktSoF9GJUZ20uDSXiWZVxKodbUOY1AR6Bw/fk+60aSNBk3ZHGU2uiRAJ oddk0iop2JzeyAcUUszgwkIp7I7VB8p3Vpaic= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767215311; x=1767820111; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xtR7PK39BaSx2GpuhvAfss4ZTutnP9LImpMPJNr7WtI=; b=oFkI7I81pRZH2W3R/zCo9OAW1trcf87H7Le+r3Ppx2EmZ+al1dICkO4MHbVTum0V+b d28C3ckHD8xYRxgknm4Wh56TNeXsfo8NagoL2O5gg4ksH/LlrA1IWa2dwEJ7mv/5pRNg xuwHDjV5BzeEQOzStwk0Sbr59hvuiCtn0pyiq8jg3/ad4BSorofgSLqPDzZIip8tUMaa m3nEJj10lc0L8bAXgNrfibVkUd4Ub+L1sF5uM2OYulzYI6oTS8ns+LnZE0d6663ZztP7 OZn7mmByL+u1obXm2cGRyZZ4HJsYVYxvBddBgPezFjTlYk+cLwnMI/bcV3Gno2f/Crr9 QkpA== X-Forwarded-Encrypted: i=1; AJvYcCV5X/4VQED1XKmAOKdJDHPT7insO/CO3CliFgpDARcmTbWf2sPJO8amxFl/LrgyjbqrZUTkX3mqreLtELA=@vger.kernel.org X-Gm-Message-State: AOJu0YzQr2HHnTzF4bwVAvVM02adbxklhqrlN03F4HMdr6cfa7k6N2lj Blhkc2AiiFV+fmQQWWaMgo9TaOvYVErEhAle/yioZQACQUAiJMk7r5usf/n0jbEfR3U= X-Gm-Gg: AY/fxX7mZQivVuzqcelXXa7sm7AKZWhyw2K8ck2O0HPowXobuPszn8uaR5pBQyxTC5i 0qbh6VYWg2YHHayAPVnbfnF9JWPuJC0lmIWhqFJgrKLuTjll433UPMS1YI553LNNlUlrYheGVpM ZUjeL3jjKKCghBmgo4Aps+pz45IXCsM6DIc/ae6+e4sM6YRu/jch3hv+b3ppgKgckMaQHG+MxSJ LXkV9gEPSImsw7IVf6PnTB/X0xvyTo3IuapHeY5E7RKlhNAnBzXxZPfYF0B6T+nbpdLFRPiia5E 1fnSg9a5FYJ5qbGnn+m2vP3QD4CuKckmY1ZN5vAt0/edAhsP9BuC2lJhRC+gvC/mLVgxiCRNjRS L3aB1DPJgpuJQEXuBWYxsW6c/YxuE9Ny+JBUQswXYYvd3T0lWtluUMP0X83H2fJyds59cCDI70b uUsBBXZ8nzgoCmSLU9n0cgSyU= X-Google-Smtp-Source: AGHT+IHTwHn1nXDjbjmhskjWx+MgiaHwYI6WYS1jGtnZhB7g8+LiP9lF5g92eNpfucMrdW9R4flOrA== X-Received: by 2002:a05:6808:1526:b0:450:3ff9:f4dd with SMTP id 5614622812f47-457b20b7730mr18285141b6e.24.1767215311322; Wed, 31 Dec 2025 13:08:31 -0800 (PST) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4598c356623sm12481094b6e.2.2025.12.31.13.08.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Dec 2025 13:08:30 -0800 (PST) Message-ID: <8b3d207c-76a2-4312-a149-724e55fbd0cb@linuxfoundation.org> Date: Wed, 31 Dec 2025 14:08:29 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Linux 6.19-rc1 mediatek mt7921e broke badly To: Eric Biggers , Linus Torvalds , Mario Limonciello Cc: Matthew Schwartz , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Mikhail Gavrilov , Mario Limonciello , Johannes Berg , quan.zhou@mediatek.com, Felix Fietkau , lorenzo@kernel.org, ryder.lee@mediatek.com, linux-wireless@vger.kernel.org, Linux Kernel Mailing List , Linux ARM , linux-mediatek@lists.infradead.org, shuah References: <756e3f65-b2f2-4da3-985a-17754a7a872d@t-8ch.de> <6fc04df5-b753-4b2d-b978-0e59a7f48ff7@linux.dev> <20251231015712.GA2299@sol> <30d14c51-3325-49be-9510-43f4661ff6c4@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: <30d14c51-3325-49be-9510-43f4661ff6c4@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/30/25 21:07, Shuah Khan wrote: > On 12/30/25 21:00, Shuah Khan wrote: >> On 12/30/25 18:57, Eric Biggers wrote: >>> On Tue, Dec 30, 2025 at 05:27:13PM -0800, Linus Torvalds wrote: >>>> On Tue, 30 Dec 2025 at 15:57, Shuah Khan wrote: >>>>> >>>>> I would recommend reverting f804a5895eba instead of trying >>>>> fix it. Then find a better way to eliminate extra newline that >>>>> shows up in dmesg when firmware build date happens to have >>>>> a newline. >>>> >>>> Yeah. Let's revert it. >>>> >>>> And the way to fix the extra newline is trivial: just remove it from >>>> the "dev_info()" format string. >>>> >>>> Our kernel printing logic will add a newline for the next line anyway >>>> if it is missing (unless somebody explicitly uses PR_CONT). >>>> >>>> Can whoever saw the problem confirm that just a revert and a "remove >>>> \n from that dev_info()" fixes the output for them? >>> >>> That works for me.  The revert by itself makes the FORTIFY_SOURCE crash >>> go away and reintroduces a blank line in the log.  Removing the \n from >>> the string passed to dev_info as well makes the blank line go away. >>> >> >> I just sent the revert. I will try removing \n from dev_info() >> later on tomorrow. >> >> My quick trial still showed extra line which didn't make sense >> to me. More trials have to wait for tomorrow. >> > > Hmm - there are 3 places that print build_date in  mt76_connac2_load_ram() > > 3022         dev_info(dev->dev, "WM Firmware Version: %.10s, Build Time: %.15s\n     ", > 3023                  hdr->fw_ver, hdr->build_date); > > > 3051         dev_info(dev->dev, "WA Firmware Version: %.10s, Build Time: %.15s\n     ", > 3052                  hdr->fw_ver, hdr->build_date); > > 3127         dev_info(dev->dev, "HW/SW Version: 0x%x, Build Time: %.16s\n", > 3128                  be32_to_cpu(hdr->hw_sw_ver), hdr->build_date); > > The last one prints %.16s and other two do %.15s - is the fix simply > changing last one on line 3127 to print %.15s - this avoids printing > the extra \n? > The following change fixed the blank line problem on my system. Mario, if you want to send this patch after testing on your system, let me know. Otherwise I will send it. ============================================== diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c index fba7025ffd3f..0457712286d5 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c @@ -3019,7 +3019,7 @@ int mt76_connac2_load_ram(struct mt76_dev *dev, const char *fw_wm, } hdr = (const void *)(fw->data + fw->size - sizeof(*hdr)); - dev_info(dev->dev, "WM Firmware Version: %.10s, Build Time: %.15s\n", + dev_info(dev->dev, "WM Firmware Version: %.10s, Build Time: %.15s", hdr->fw_ver, hdr->build_date); ret = mt76_connac_mcu_send_ram_firmware(dev, hdr, fw->data, false); @@ -3048,7 +3048,7 @@ int mt76_connac2_load_ram(struct mt76_dev *dev, const char *fw_wm, } hdr = (const void *)(fw->data + fw->size - sizeof(*hdr)); - dev_info(dev->dev, "WA Firmware Version: %.10s, Build Time: %.15s\n", + dev_info(dev->dev, "WA Firmware Version: %.10s, Build Time: %.15s", hdr->fw_ver, hdr->build_date); ret = mt76_connac_mcu_send_ram_firmware(dev, hdr, fw->data, true); @@ -3124,7 +3124,7 @@ int mt76_connac2_load_patch(struct mt76_dev *dev, const char *fw_name) } hdr = (const void *)fw->data; - dev_info(dev->dev, "HW/SW Version: 0x%x, Build Time: %.16s\n", + dev_info(dev->dev, "HW/SW Version: 0x%x, Build Time: %.16s", be32_to_cpu(hdr->hw_sw_ver), hdr->build_date); for (i = 0; i < be32_to_cpu(hdr->desc.n_region); i++) { ======================================== thanks, -- Shuah