From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3A922F5491; Mon, 30 Mar 2026 14:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774881189; cv=none; b=M6Yh0YJCfilz9Ifznpc37gK92XY82Y8QsKj285BopgpxrhK3YivoyCGMm7gEQHfbq4zwcdNUHCxyV6ey1nw8WD7/l5lgNBV6FAYkJAOfrOnjaxHEEhqeLWVZodi1XoYk7d/fko+OPz/jB22sLoFGHyw6JWLuqA6swuys6vW3Moc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774881189; c=relaxed/simple; bh=N9y0x55MeIUDuj/970TQa0+5Agph4ZoIsLckCPZfjMU=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=pdofcLLGOX+4Uo7RHAvWRmMYJbqZW7fd3+lmAF3jDAIWVkqPrW9KcaihlSDlG/4/H8jFFmCGtluJRSi6Kp8Y83/nuSfnZJWX8yQEoqQ7qekq35r0Oz3yH1iFihHtN6GGNW5j2x5sG8Lph3s6UPCTIKwQVCWbjz5khTzS1+ERRZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BkKntV3J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BkKntV3J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E102C19423; Mon, 30 Mar 2026 14:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774881189; bh=N9y0x55MeIUDuj/970TQa0+5Agph4ZoIsLckCPZfjMU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=BkKntV3Jhvr98iWM1n5sF1FhzawD+hyCYgqy3kxQqXurscMFVhJ4nOzjkYhI5/5o4 5hTIJioCL3gBueIHd1rgTeXJ9RrKUZEkgcEWnQcB2nBm4Bm6+nNeGFC+1/5P1mm3ah /H8ZpeTMmxS/Ir+wxi50m0aZOx2ZsbIIxKV5Dw7Pg7ZmLk16kXFfoN4ROaNgq8SADN bbQf/UEVBxtw54HjvPwmCkxQIxCHhZ2Apci2kV+9LYE26ekVZWAMdlCz3W2mcJjz2d qoPJQOxv6U0378A7rDyC5BDkZSk01m7/rxsx20wwEGkbuggXa02BIRF60ioyLciGEV od0GV0G/Zaskg== Message-ID: <8b3eae05-046a-4413-ae56-f70e1b1dfc83@kernel.org> Date: Mon, 30 Mar 2026 16:33:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] mm/page_alloc: Optimize free_contig_range() To: Muhammad Usama Anjum , Andrew Morton , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Uladzislau Rezki , Nick Terrell , David Sterba , Vishal Moola , linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Ryan.Roberts@arm.com, david.hildenbrand@arm.com References: <20260327125720.2270651-1-usama.anjum@arm.com> <20260327125720.2270651-2-usama.anjum@arm.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260327125720.2270651-2-usama.anjum@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > > +static void free_prepared_contig_range(struct page *page, > + unsigned long nr_pages) Prefer two-tab indent in MM land. > +{ > + while (nr_pages) { > + unsigned int order; > + unsigned long pfn; > + > + pfn = page_to_pfn(page); I'd just do above const unsigned long pfn = page_to_pfn(page); unsigned long order; > + /* We are limited by the largest buddy order. */ > + order = pfn ? __ffs(pfn) : MAX_PAGE_ORDER; > + /* Don't exceed the number of pages to free. */ > + order = min_t(unsigned int, order, ilog2(nr_pages)); > + order = min_t(unsigned int, order, MAX_PAGE_ORDER); > + > + /* > + * Free the chunk as a single block. Our caller has already > + * called free_pages_prepare() for each order-0 page. > + */ > + __free_frozen_pages(page, order, FPI_PREPARED); > + > + page += 1UL << order; > + nr_pages -= 1UL << order; > + } > +} > + > +static void __free_contig_range_common(unsigned long pfn, unsigned long nr_pages, > + bool is_frozen) Dito. > +{ > + struct page *page = pfn_to_page(pfn); > + struct page *start = NULL; > + unsigned long start_sec; > + bool can_free = true; > + unsigned long i; > + > + /* > + * Contiguous PFNs might not have a contiguous "struct pages" in some > + * kernel config. Therefore, check memdesc_section(), and stop batching > + * once it changes, see num_pages_contiguous(). > + */ > + for (i = 0; i < nr_pages; i++, page++) { As Vlasta says, page++ needs a thought. (you have to redo the pfn_to_page with the next pfn in case the section changes). > + VM_WARN_ON_ONCE(PageHead(page)); > + VM_WARN_ON_ONCE(PageTail(page)); > + > + if (!is_frozen) > + can_free = put_page_testzero(page); > + > + if (can_free) > + can_free = free_pages_prepare(page, 0); > + > + if (!can_free) { > + if (start) { > + free_prepared_contig_range(start, page - start); > + start = NULL; > + } > + continue; > + } > + > + if (start && memdesc_section(page->flags) != start_sec) { > + free_prepared_contig_range(start, page - start); > + start = page; > + start_sec = memdesc_section(page->flags); > + } else if (!start) { > + start = page; > + start_sec = memdesc_section(page->flags); > + } > + } > + > + if (start) > + free_prepared_contig_range(start, page - start); > +} > + > +/** > + * __free_contig_range - Free contiguous range of order-0 pages. > + * @pfn: Page frame number of the first page in the range. > + * @nr_pages: Number of pages to free. > + * > + * For each order-0 struct page in the physically contiguous range, put a > + * reference. Free any page who's reference count falls to zero. The > + * implementation is functionally equivalent to, but significantly faster than > + * calling __free_page() for each struct page in a loop. > + * > + * Memory allocated with alloc_pages(order>=1) then subsequently split to > + * order-0 with split_page() is an example of appropriate contiguous pages that > + * can be freed with this API. > + * > + * Context: May be called in interrupt context or while holding a normal > + * spinlock, but not in NMI context or while holding a raw spinlock. Interesting that we didn't have a cond_resched() somewhere in there. -- Cheers, David