From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751141AbeAVHC5 (ORCPT ); Mon, 22 Jan 2018 02:02:57 -0500 Received: from mout01.posteo.de ([185.67.36.65]:39850 "EHLO mout01.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbeAVHCz (ORCPT ); Mon, 22 Jan 2018 02:02:55 -0500 Subject: Re: [PATCH 2/2] Input: sur40: Improve a size determination in sur40_probe() To: SF Markus Elfring , linux-input@vger.kernel.org, Dmitry Torokhov , Florian Echtler , Johan Hovold , Martin Kaltenbrunner Cc: LKML , kernel-janitors@vger.kernel.org References: <11e0b313-f8c2-93ec-0324-24b30053a586@users.sourceforge.net> From: Martin Kepplinger Message-ID: <8b3fb313-b69d-f381-dde8-212a85b5a90e@posteo.de> Date: Mon, 22 Jan 2018 08:02:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <11e0b313-f8c2-93ec-0324-24b30053a586@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-01-20 22:30, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Jan 2018 22:16:14 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Martin Kepplinger > --- > drivers/input/touchscreen/sur40.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c > index c7a0a92b2044..946e1a0328b4 100644 > --- a/drivers/input/touchscreen/sur40.c > +++ b/drivers/input/touchscreen/sur40.c > @@ -550,7 +550,7 @@ static int sur40_probe(struct usb_interface *interface, > return -ENODEV; > > /* Allocate memory for our device state and initialize it. */ > - sur40 = kzalloc(sizeof(struct sur40_state), GFP_KERNEL); > + sur40 = kzalloc(sizeof(*sur40), GFP_KERNEL); > if (!sur40) > return -ENOMEM; > >