From: Markus Elfring <Markus.Elfring@web.de>
To: Fan Wu <fanwu01@zju.edu.cn>, Song Li <songl@zju.edu.cn>,
linux-crypto@vger.kernel.org, John Allen <john.allen@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH v2] crypto: ccp - Fix use-after-free in backlog cmd advancement
Date: Tue, 29 Sep 2026 17:18:29 +0200 [thread overview]
Message-ID: <8b4458b0-a3f4-4eb4-8b85-5d4139ac3ae8@web.de> (raw)
In-Reply-To: <20260929143825.21349-1-fanwu01@zju.edu.cn>
…
> +++ b/drivers/crypto/ccp/ccp-dev.c
> @@ -177,6 +177,15 @@ void ccp_del_device(struct ccp_device *ccp)
> write_unlock_irqrestore(&ccp_unit_lock, flags);
> }
>
> +/* Prevent promotion from waking an idle queue during teardown. */
> +void ccp_halt_cmds(struct ccp_device *ccp)
> +{
> + unsigned long flags;
> +
> + spin_lock_irqsave(&ccp->cmd_lock, flags);
> + ccp->halting = true;
> + spin_unlock_irqrestore(&ccp->cmd_lock, flags);
> +}
…
May lock guards be applied in affected function implementations?
https://elixir.bootlin.com/linux/v7.3-rc5/source/include/linux/spinlock.h#L642-L645
Regards,
Markus
next prev parent reply other threads:[~2026-09-29 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 14:38 Fan Wu
2026-09-29 15:18 ` Markus Elfring [this message]
2026-09-30 7:47 ` Fan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4458b0-a3f4-4eb4-8b85-5d4139ac3ae8@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=fanwu01@zju.edu.cn \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=songl@zju.edu.cn \
--cc=stable@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®