From: Rodrigo Campos <rodrigo@sdfg.com.ar>
To: "Willy Tarreau" <w@1wt.eu>, "Thomas Weißschuh" <linux@weissschuh.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] selftests/nolibc: Add tests for strlcat() and strlcpy()
Date: Wed, 14 Feb 2024 12:52:10 -0300 [thread overview]
Message-ID: <8b469fca-e1bd-4c7b-9311-cf4d2270f8cd@sdfg.com.ar> (raw)
In-Reply-To: <20240129141516.198636-5-rodrigo@sdfg.com.ar>
On 1/29/24 15:15, Rodrigo Campos wrote:
> + /* For functions that take a long buffer, like strlcat() */
> + char buf[7] = "foo";
> +
I've improved this to not be the same length as the other buffer (we
can't catch mistakes like confusing the src and dst buffers like that)
and added some trailing chars, so we also test that the \0 is added at
the exactly right position.
prev parent reply other threads:[~2024-02-14 15:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 14:15 [PATCH 0/4] tools/nolibc: Misc fixes for strlcpy() and strlcat() Rodrigo Campos
2024-01-29 14:15 ` [PATCH 1/4] tools/nolibc/string: export strlen() Rodrigo Campos
2024-01-29 14:15 ` [PATCH 2/4] tools/nolibc: Fix strlcat() return code and size usage Rodrigo Campos
2024-02-11 10:48 ` Willy Tarreau
2024-02-12 23:16 ` Rodrigo Campos
2024-02-13 5:27 ` Rodrigo Campos
2024-02-13 6:20 ` Rodrigo Campos
2024-02-13 7:02 ` Willy Tarreau
2024-02-14 15:19 ` Rodrigo Campos
2024-02-13 6:04 ` Rodrigo Campos
2024-02-14 15:34 ` Rodrigo Campos
2024-02-14 22:03 ` Rodrigo Campos
2024-02-14 22:47 ` Rodrigo Campos
2024-02-18 10:22 ` Willy Tarreau
2024-02-18 10:20 ` Willy Tarreau
2024-02-18 19:33 ` Rodrigo Campos
2024-01-29 14:15 ` [PATCH 3/4] tools/nolibc: Fix strlcpy() " Rodrigo Campos
2024-02-11 11:08 ` Willy Tarreau
2024-02-11 11:14 ` Willy Tarreau
2024-02-14 15:50 ` Rodrigo Campos
2024-02-14 15:55 ` Willy Tarreau
2024-01-29 14:15 ` [PATCH 4/4] selftests/nolibc: Add tests for strlcat() and strlcpy() Rodrigo Campos
2024-02-11 11:09 ` Willy Tarreau
2024-02-14 15:52 ` Rodrigo Campos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b469fca-e1bd-4c7b-9311-cf4d2270f8cd@sdfg.com.ar \
--to=rodrigo@sdfg.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®