From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E133C3A59F for ; Fri, 30 Aug 2019 01:40:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 762F3208C2 for ; Fri, 30 Aug 2019 01:40:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727753AbfH3BkU (ORCPT ); Thu, 29 Aug 2019 21:40:20 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5695 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726825AbfH3BkU (ORCPT ); Thu, 29 Aug 2019 21:40:20 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id CE00A2F40678C9E7A30A; Fri, 30 Aug 2019 09:40:16 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Fri, 30 Aug 2019 09:40:12 +0800 Subject: Re: [PATCH] amd-xgbe: Fix error path in xgbe_mod_init() To: Jakub Kicinski References: <20190829024600.16052-1-yuehaibing@huawei.com> <20190829105237.196722f9@cakuba.netronome.com> CC: , , , From: Yuehaibing Message-ID: <8b480542-4ec4-03b2-4426-348ac65aa4d6@huawei.com> Date: Fri, 30 Aug 2019 09:40:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190829105237.196722f9@cakuba.netronome.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/8/30 1:52, Jakub Kicinski wrote: > On Thu, 29 Aug 2019 10:46:00 +0800, YueHaibing wrote: >> In xgbe_mod_init(), we should do cleanup if some error occurs >> >> Reported-by: Hulk Robot >> Fixes: efbaa828330a ("amd-xgbe: Add support to handle device renaming") >> Fixes: 47f164deab22 ("amd-xgbe: Add PCI device support") >> Signed-off-by: YueHaibing > > Looks correct. Thanks! > > For networking fixes please try to use [PATCH net] as a tag ([PATCH > net-next] for normal, non-fix patches). Ok. > >