From: Armin Wolf <W_Armin@gmx.de>
To: yahia <yahia.a.abdrabou@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wmi/core Fix use-after-free in parse_wdg()
Date: Mon, 22 Jun 2026 16:45:17 +0200 [thread overview]
Message-ID: <8b505aea-2c76-4868-b30c-be34ce0eb761@gmx.de> (raw)
In-Reply-To: <20260622000253.210491-1-yahia.a.abdrabou@gmail.com>
Am 22.06.26 um 02:02 schrieb yahia:
> From: yahia ahmed <yahia.a.abdrabou@gmail.com>
>
> Fix use-after-free in parse_wdg() function by
> setting wblock to null to prevent referencing
> freed memory, if wblock is freed in the if
> (retval) path and address a minor typo.
Hi,
where exactly does this UAF happen? Keep in mind that kmalloc_obj()
only "dereferences" *wblock to use sizeof() on the type pointed to by
the pointer.
Thanks,
Armin Wolf
> Signed-off-by: yahia ahmed <yahia.a.abdrabou@gmail.com>
> ---
> drivers/platform/wmi/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/wmi/core.c b/drivers/platform/wmi/core.c
> index 5a2ffcbab6af..9b5bd9ef5ba2 100644
> --- a/drivers/platform/wmi/core.c
> +++ b/drivers/platform/wmi/core.c
> @@ -1328,6 +1328,7 @@ static int parse_wdg(struct device *wmi_bus_dev, struct platform_device *pdev)
> retval = wmi_create_device(wmi_bus_dev, wblock, device);
> if (retval) {
> kfree(wblock);
> + wblock = NULL; /* Set wblock to NULL to prevent a use after free */
> continue;
> }
>
> @@ -1418,7 +1419,7 @@ static int wmi_notify_device(struct device *dev, void *data)
> return 0;
>
> /* The ACPI WMI specification says that _WED should be
> - * evaluated every time an notification is received, even
> + * evaluated every time a notification is received, even
> * if no consumers are present.
> *
> * Some firmware implementations actually depend on this
next prev parent reply other threads:[~2026-06-22 14:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 0:02 yahia
2026-06-22 14:45 ` Armin Wolf [this message]
2026-06-22 19:04 ` [PATCH v2] wmi/core: fix use-after-free in wmi_add_device() yahia
2026-06-22 19:18 ` [PATCH v3] " yahia
2026-06-22 19:45 ` Armin Wolf
2026-06-22 20:25 ` Re " yahia
2026-06-22 20:45 ` Armin Wolf
2026-06-22 20:57 ` yahia
2026-06-22 21:19 ` Armin Wolf
2026-06-23 0:12 ` yahia
2026-07-01 4:19 ` Armin Wolf
2026-07-01 9:42 ` yahia
2026-07-03 12:28 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b505aea-2c76-4868-b30c-be34ce0eb761@gmx.de \
--to=w_armin@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yahia.a.abdrabou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®