From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbeBHJm4 (ORCPT ); Thu, 8 Feb 2018 04:42:56 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:41323 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbeBHJms (ORCPT ); Thu, 8 Feb 2018 04:42:48 -0500 X-Google-Smtp-Source: AH8x225SixWdz93+7XspWlt5TjMOXwkBzXQXxT6vLD+5wSf/KcWezi/jNNGHnZCeUsJyCQTRtifNcA== Subject: Re: [PATCH 0/4] lightnvm: base 2.0 implementation To: Javier Gonzalez Cc: "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20180205121505.27563-1-mb@lightnvm.io> From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <8b50ed33-226a-760a-e888-51ff573b9557@lightnvm.io> Date: Thu, 8 Feb 2018 10:42:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2018 10:35 AM, Javier Gonzalez wrote: >> On 5 Feb 2018, at 13.15, Matias Bjørling wrote: >> >> Hi, >> >> A couple of patches for 2.0 support for the lightnvm subsystem. They >> form the basis for integrating 2.0 support. >> >> For the rest of the support, Javier has code that implements report >> chunk and sets up the LBA format data structure. He also has a bunch >> of patches that brings pblk up to speed. >> >> The first two patches is preparation for the 2.0 work. The third patch >> implements the 2.0 data structures, the geometry command, and exposes >> the sysfs attributes that comes with the 2.0 specification. Note that >> the attributes between 1.2 and 2.0 are different, and it is expected >> that user-space shall use the version sysfs attribute to know which >> attributes will be available. >> >> The last patch implements support for using the nvme namespace logical >> block and metadata fields and sync it with the internal lightnvm >> identify structures. >> >> -Matias >> >> Matias Bjørling (4): >> lightnvm: make 1.2 data structures explicit >> lightnvm: flatten nvm_id_group into nvm_id >> lightnvm: add 2.0 geometry identification >> nvme: lightnvm: add late setup of block size and metadata >> >> drivers/lightnvm/core.c | 27 ++- >> drivers/nvme/host/core.c | 2 + >> drivers/nvme/host/lightnvm.c | 508 ++++++++++++++++++++++++++++++++----------- >> drivers/nvme/host/nvme.h | 2 + >> include/linux/lightnvm.h | 64 +++--- >> 5 files changed, 426 insertions(+), 177 deletions(-) >> >> -- >> 2.11.0 > > Thanks for posting these. I have started rebasing my patches on top of > the new geometry - it is a bit different of how I implemented it, but > I'll take care of it. > > I'll review as I go - some of the changes I have might make sense to > squash in your patches to keep a clean history... > Thanks. > I'll add a couple of patches abstracting the geometry so that at core.c > level we only work with a single geometry structure. This is they way it > is done in the early patches I pointe you to before. Then it is patches > building bottom-up support for the new features in 2.0. > Yep, I was expecting that. I skipped that part since it went into pblk and you already had some patches for it. > Javier >