mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alina Yu <alina_yu@richtek.com>
Cc: broonie@kernel.org, linux-kernel@vger.kernel.org, cy_huang@richtek.com
Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC
Date: Mon, 10 Jul 2023 08:02:39 +0200	[thread overview]
Message-ID: <8b5bde1a-08e2-15ad-ebe1-08a16de00468@kernel.org> (raw)
In-Reply-To: <20230710030858.GA16636@linuxcarl2.richtek.com>

On 10/07/2023 05:08, Alina Yu wrote:
>> Yes, "0" refers to DVS0 registers, and "1" refers to DVS1.
>> and there is only DVS0 and DVS1, so I use boolean to check which one is used.
>>
>> Is it more understandable if I modify that to enum ? And description will be like this
>>
>> richtek,mtp-sel:
>>   enum: [0, 1]
>>     description: |
>>       vout register selection besed on this value.
>>       0 - Using DVS0 register setting to adjust vout
>>       1 - Using DVS1 register setting to adjust vout
>>
> 
> May I ask one more question ?
> If I modify the name into "richtek,mtp-sel-high", is that more understandable ?
> It will be like this,
> 
> richtek,mtp-sel-high:
>   type: boolean
>   description:
>   vout register selection besed on this value.
>   0 - Using DVS0 register setting to adjust vout
>   1 - Using DVS1 register setting to adjust vout

You don't have 0 or 1 values in such case. The property can be bool, but
description is not good.

Best regards,
Krzysztof


  reply	other threads:[~2023-07-10  6:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05 15:27 [PATCH v2 0/2] Add Richtek RTQ2208 SubPMIC support alina_yu
2023-07-05 15:27 ` [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC alina_yu
2023-07-05 17:58   ` Krzysztof Kozlowski
2023-07-06 10:30     ` Alina Yu
2023-07-06 11:04       ` Krzysztof Kozlowski
2023-07-10  3:08       ` Alina Yu
2023-07-10  6:02         ` Krzysztof Kozlowski [this message]
2023-07-10  7:23           ` Alina Yu
2023-07-05 15:27 ` [PATCH v2 2/2] regulator: rtq2208: Add Richtek RTQ2208 SubPMIC driver alina_yu
2023-07-18  8:40   ` Alina Yu
2023-07-18 14:16     ` Mark Brown
2023-07-19  4:29       ` Alina Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b5bde1a-08e2-15ad-ebe1-08a16de00468@kernel.org \
    --to=krzk@kernel.org \
    --cc=alina_yu@richtek.com \
    --cc=broonie@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome