From: Harry Wentland <hwentlan@amd.com>
To: Krzysztof Wilczynski <kw@linux.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: "Wentland, Harry" <Harry.Wentland@amd.com>,
"Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
"Lakha, Bhawanpreet" <Bhawanpreet.Lakha@amd.com>,
"Cheng, Tony" <Tony.Cheng@amd.com>, "Lei, Jun" <Jun.Lei@amd.com>,
"Francis, David" <David.Francis@amd.com>,
"Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>,
"Laktyushkin, Dmytro" <Dmytro.Laktyushkin@amd.com>,
"Liu, Wenjing" <Wenjing.Liu@amd.com>,
"Koo, Anthony" <Anthony.Koo@amd.com>,
Aidan Wood <Aidan.Wood@amd.com>,
"Park, Chris" <Chris.Park@amd.com>,
"Yang, Eric" <Eric.Yang2@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/amd/display: Move static keyword to the front of declaration
Date: Thu, 5 Sep 2019 18:34:01 +0000 [thread overview]
Message-ID: <8b5de881-2109-6f75-68e3-9c8c743b483e@amd.com> (raw)
In-Reply-To: <20190905183306.32670-1-kw@linux.com>
On 2019-09-05 2:33 p.m., Krzysztof Wilczynski wrote:
> Move the static keyword to the front of declaration of DC_BUILD_ID,
> and resolve the following compiler warning that can be seen when
> building with warnings enabled (W=1):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> Related: https://lore.kernel.org/r/20190827233017.GK9987@google.com
>
> drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 87ca5a290d12..a5a89bc0e1d1 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -72,7 +72,7 @@
> #define DC_LOGGER \
> dc->ctx->logger
>
> -const static char DC_BUILD_ID[] = "production-build";
> +static const char DC_BUILD_ID[] = "production-build";
>
> /**
> * DOC: Overview
>
prev parent reply other threads:[~2019-09-05 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 18:33 Krzysztof Wilczynski
2019-09-05 18:34 ` Harry Wentland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b5de881-2109-6f75-68e3-9c8c743b483e@amd.com \
--to=hwentlan@amd.com \
--cc=Aidan.Wood@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Anthony.Koo@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Chris.Park@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=David.Francis@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Dmytro.Laktyushkin@amd.com \
--cc=Eric.Yang2@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=Sunpeng.Li@amd.com \
--cc=Tony.Cheng@amd.com \
--cc=Wenjing.Liu@amd.com \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®