From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1847C43142 for ; Thu, 2 Aug 2018 14:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E2DC2151B for ; Thu, 2 Aug 2018 14:31:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WaipacC0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2DC2151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732511AbeHBQXX (ORCPT ); Thu, 2 Aug 2018 12:23:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:32918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732202AbeHBQXX (ORCPT ); Thu, 2 Aug 2018 12:23:23 -0400 Received: from [192.168.0.101] (unknown [121.229.118.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0CF121501; Thu, 2 Aug 2018 14:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1533220315; bh=fqiazS0TSRSWNgwdZv7m71umS3nUWSEM6lgo5+a7k6I=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=WaipacC02X96GgIEySFCcxFIMuOF53dQOL2IJ7oTljJvq1omyYd016FwUESvCYGat w4uVPbYQq7ms8XKxGmtplbT+S5r7U9KYibHcxdbufSaHDUHcEFbASCpa+Z8qZ4Zz9h BJDZu5OMvNgCFMge4Y4CiqWED96YoNWZjXoAAzto= Subject: Re: [PATCH v2] staging: erofs: disable compiling temporarile To: Gao Xiang , Chao Yu Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au References: <20180802093917.4796-1-yuchao0@huawei.com> <27867b85-f2d9-2562-73ab-96807ec469a9@aol.com> From: Chao Yu Message-ID: <8b5ecd46-65a4-aec4-9eb0-a38a8dfba0ba@kernel.org> Date: Thu, 2 Aug 2018 22:31:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <27867b85-f2d9-2562-73ab-96807ec469a9@aol.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xiang, On 2018/8/2 18:11, Gao Xiang wrote: > Hi Chao, > > On 2018/8/2 17:39, Chao Yu wrote: >> As Stephen Rothwell reported: >> >> "After merging the staging tree, today's linux-next build (x86_64 >> allmodconfig) failed like this: >> >> drivers/staging/erofs/super.c: In function 'erofs_read_super': >> drivers/staging/erofs/super.c:343:17: error: 'MS_RDONLY' undeclared (first use in this function); did you mean 'IS_RDONLY'? >> sb->s_flags |= MS_RDONLY | MS_NOATIME; >> ^~~~~~~~~ >> IS_RDONLY >> drivers/staging/erofs/super.c:343:17: note: each undeclared identifier is reported only once for each function it appears in >> drivers/staging/erofs/super.c:343:29: error: 'MS_NOATIME' undeclared (first use in this function); did you mean 'S_NOATIME'? >> sb->s_flags |= MS_RDONLY | MS_NOATIME; >> ^~~~~~~~~~ >> S_NOATIME >> drivers/staging/erofs/super.c: In function 'erofs_mount': >> drivers/staging/erofs/super.c:501:10: warning: passing argument 5 of 'mount_bdev' makes integer from pointer without a cast [-Wint-conversion] >> &priv, erofs_fill_super); >> ^~~~~~~~~~~~~~~~ >> In file included from include/linux/buffer_head.h:12:0, >> from drivers/staging/erofs/super.c:14: >> include/linux/fs.h:2151:23: note: expected 'size_t {aka long unsigned int}' but argument is of type 'int (*)(struct super_block *, void *, int)' >> extern struct dentry *mount_bdev(struct file_system_type *fs_type, >> ^~~~~~~~~~ >> drivers/staging/erofs/super.c:500:9: error: too few arguments to function 'mount_bdev' >> return mount_bdev(fs_type, flags, dev_name, >> ^~~~~~~~~~ >> In file included from include/linux/buffer_head.h:12:0, >> from drivers/staging/erofs/super.c:14: >> include/linux/fs.h:2151:23: note: declared here >> extern struct dentry *mount_bdev(struct file_system_type *fs_type, >> ^~~~~~~~~~ >> drivers/staging/erofs/super.c: At top level: >> drivers/staging/erofs/super.c:518:20: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] >> .mount = erofs_mount, >> ^~~~~~~~~~~ >> drivers/staging/erofs/super.c:518:20: note: (near initialization for 'erofs_fs_type.mount') >> drivers/staging/erofs/super.c: In function 'erofs_remount': >> drivers/staging/erofs/super.c:630:12: error: 'MS_RDONLY' undeclared (first use in this function); did you mean 'IS_RDONLY'? >> *flags |= MS_RDONLY; >> ^~~~~~~~~ >> IS_RDONLY >> drivers/staging/erofs/super.c: At top level: >> drivers/staging/erofs/super.c:640:16: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] >> .remount_fs = erofs_remount, >> ^~~~~~~~~~~~~ >> >> Caused by various commits creating erofs in the staging tree interacting >> with various commits redoing the mount infrastructure in the vfs tree. >> >> I have disabed CONFIG_EROFS_FS for now:" >> >> The reason of compiling error is: >> >> Since -next collects and merges developing patches including common vfs >> stuff from multi-trees, but those patches didn't cover erofs, such as: >> >> ('vfs: Suppress MS_* flag defs within the kernel unless explicitly enabled") >> https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/commit/?h=for-next&id=109b45090d7d3ce2797bb1ef7f70eead5bfe0ff3 >> >> ("vfs: Require specification of size of mount data for internal mounts") >> https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/commit/?h=for-next&id=0a191e4505a4f255e6513b49426213da69bf0e80 >> >> Above vfs related patches has not been merged in staging tree, if we >> submit those erofs patches to staging mailing list and after including >> them in staging-{test,nexts} tree, it can easily cause compiling error. >> >> We worked out some patches to adjust those vfs change, but now we just >> submit them to -next tree temporarily to avoid compiling error. >> >> For potentail conflict in between erofs and vfs changes in incoming >> merge window, Stephen suggested that we can disable CONFIG_EROFS_FS >> temporarily to pass merge window, and after that we can do restore by >> reenabling CONFIG_EROFS_FS and applying those fixing patches. Also >> Greg confirmed this solution. >> >> So, let's disable compiling erofs for a while. >> >> Suggested-by: Stephen Rothwell >> Signed-off-by: Gao Xiang >> Reviewed-by: Gao Xiang >> Signed-off-by: Chao Yu >> --- >> drivers/staging/erofs/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/erofs/Kconfig b/drivers/staging/erofs/Kconfig >> index 663b755bf2fb..96f614934df1 100644 >> --- a/drivers/staging/erofs/Kconfig >> +++ b/drivers/staging/erofs/Kconfig >> @@ -2,7 +2,7 @@ >> >> config EROFS_FS >> tristate "EROFS filesystem support" >> - depends on BLOCK >> + depends on BROKEN > > How about remaining "depends on BLOCK" but just adding "depends on BROKEN"? That's right, let me update it in v3, sorry about the mistake. Thanks, > > Thanks > Gao Xiang >> help >> EROFS(Enhanced Read-Only File System) is a lightweight >> read-only file system with modern designs (eg. page-sized >