From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6A4630BBAA for ; Tue, 14 Oct 2025 21:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760476254; cv=none; b=ujZMHB5GGwD2lhm9YMivA58Apt4tUChvNyo0Zps6DT8SsMfDSxjH6JWpFBK82eSS+0cM3xyoDV+MZi9Xxn6PKyT74Nap5mTdYxlWfbEAgxMYZxAyGKHKY3WnRReLSNDsVF4eVGbNrlZh7z94uwxwzAMqEwurd2Zuxmo5V1JnSAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760476254; c=relaxed/simple; bh=BQJLULTT/Wn1VgzHKtiLeywejDNqOrYVAnsXBZ3US70=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lxKhr1Ej14E91j/PuaOK3ovaxCILNnTZ93Pz7jO0Tyed7cnzfQnP+H6BVf2CyDUiDKkRv1BfwLDzzJ7FcHJ8nS+yYf9PjIAG9f88Wbxw6Koq+sPYerp9C1Patc/1RwEu/8gJ+nH5rJLADlTJkctQquV3H0O3F4KtK8UD/otE7RI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZbJzPl8b; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZbJzPl8b" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-42420c7de22so2715071f8f.1 for ; Tue, 14 Oct 2025 14:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760476250; x=1761081050; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OU1/mxCO0gs9pfD0TKLeg6fFAQ0zkZSd+iwsC02HbYM=; b=ZbJzPl8bPNCMym5feI7/o2aOEF/tWHhMsATv3KmaMXPx+M444TxSmAwCxW1+XYULAD mwu5exkDWQmwduqtokHm7w5lz8SQ8/RoHcZpkgQNML0saav1Qp4pc45eT77MvZdps2fW 5UF8OWAMWt6mXwnD+n7Pxy3i6vh8oHadLBVcNMW6gKgTwYfS6lFFN37m9L2Y28GR8LwY ICkGnUegvjf+0k+6M0EnSuTzj22IcXtI0wv0onIPIQAVlkfpF/Fu6Ppi/mCzfn+yKG+k mUd/TTtZKX71n9/u04tArcXcXMscXdj0tWWX9pns/q+QZ9ckqVyDoZbemuvCyxhoPJOk mo5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760476250; x=1761081050; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OU1/mxCO0gs9pfD0TKLeg6fFAQ0zkZSd+iwsC02HbYM=; b=o9U1Ws4eLLHJAhjSu69m0InJbszip7j6JwLUibV19l5ELNBVtsFy4wYDM4Y2Ebif7r /9zqSMyIh/DxUjNpQeGyKx7Tc1LYQhM1MbznpKJ9Pq0o/d+0OleDkpM9zpPwfpw3LT+9 PfQQhYVUyTqZH8eEuQm9xDZpfJ4+v6fwQlQnpuKdEhbnoL3wPdUiwwVvlnIBeX2P13kb FAzPDzT3P1JV0GLJGoEuzTDVGrpwitegauY1fjBmEZ0txNdxGs+5cpU5tHDvLFJxKMIX OTyT0sAfNgW4igCZfcbrNRMgmoP4MuYRYA5vRhSlv+QjOLcHsy9Gt6iEMvl2FwtrDDMM GVHQ== X-Forwarded-Encrypted: i=1; AJvYcCUWe7XBkVSeMRhK+V3nU1E4sR38ewUUPesMp9jWnfOBf88ZSkOInJoZJvRZN9hnn7qnu3vvX5m5H1jn4BM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2Lvjenql1dVhqkcyXvVtJ5YO1JiXT43DXbnIKnjZINSbhGV99 8hyUTAtHj3mX7uDp/0rrifVs7adcKQIpav5JvIiGXBaq8eka8cWjBR4R0sn5Q48m18A= X-Gm-Gg: ASbGncu/q1RPFlDkdUlGcMaQVYUJ/JFzt1wFtUf86PmSu+dqdcxukMMlK+0geOFkMIO BL8UOu8T3C7N0JcamIesN3V5XgVu4mUKGSxLxZvSemgQI1zpLXTW/H5J3Dl+/fdZKHXkHfCSfwv sEBgaHKyOhu5xOK3iyaOhJqm5gR38qxkoJ4DWEzvOcW7OpH3QhbJepAJT8bBYanB9a44YghIhIy C7yEKatiVUjBWroJPllsTkYpy4QFHVtXE/g1dXRNqs3PadOE9fSvJ3ANtr+dQ+dbeuTsbVyEnuo KrQXIb/yyRIolqIV6G7yaQ5xE2gLSt8uUzZ7pFwbY6AeB6DGiNh08aPdPC03Au0t5yvUuxxI24V 5NsORGIllsDLCF4uaNe3GZ9I2SxObl+tBWOvrRRkJ+Yp8K9xXnXnsv0DZC+omHkB6iY+M7tylBG CbXa0HXGDqfcZlqPDCa4l0rg== X-Google-Smtp-Source: AGHT+IG4aszTNfWkZ+8pnaYDUBRKBttfxEAtdOpVVT5WH4tPRBG36HzZa82lsANKG9dSujuWlON6Tg== X-Received: by 2002:a5d:64e8:0:b0:426:d71c:9a34 with SMTP id ffacd0b85a97d-426d71ca0b4mr7446024f8f.51.1760476250194; Tue, 14 Oct 2025 14:10:50 -0700 (PDT) Received: from [192.168.0.19] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce57d3desm25578034f8f.7.2025.10.14.14.10.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Oct 2025 14:10:49 -0700 (PDT) Message-ID: <8b64ff99-d3c3-4d5d-ad7e-1d11d0a8fcb4@linaro.org> Date: Tue, 14 Oct 2025 22:10:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/32] media: i2c: ov9282: Use %pe format specifier To: Ricardo Ribalda , Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , =?UTF-8?Q?Krzysztof_Ha=C5=82asa?= , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> <20251013-ptr_err-v1-18-2c5efbd82952@chromium.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20251013-ptr_err-v1-18-2c5efbd82952@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/10/2025 15:14, Ricardo Ribalda wrote: > The %pe format specifier is designed to print error pointers. It prints > a symbolic error name (eg. -EINVAL) and it makes the code simpler by > omitting PTR_ERR(). > > This patch fixes this cocci report: > ./i2c/ov9282.c:1133:3-10: WARNING: Consider using %pe to print PTR_ERR() > > Signed-off-by: Ricardo Ribalda > --- > drivers/media/i2c/ov9282.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c > index a9f6176e9729d500a40004de92c35b9abf89b08c..3e24d88f603c1432865b4d880670e4b67f1b5cec 100644 > --- a/drivers/media/i2c/ov9282.c > +++ b/drivers/media/i2c/ov9282.c > @@ -1129,8 +1129,8 @@ static int ov9282_parse_hw_config(struct ov9282 *ov9282) > ov9282->reset_gpio = devm_gpiod_get_optional(ov9282->dev, "reset", > GPIOD_OUT_LOW); > if (IS_ERR(ov9282->reset_gpio)) { > - dev_err(ov9282->dev, "failed to get reset gpio %ld", > - PTR_ERR(ov9282->reset_gpio)); > + dev_err(ov9282->dev, "failed to get reset gpio %pe", > + ov9282->reset_gpio); > return PTR_ERR(ov9282->reset_gpio); > } > > > -- > 2.51.0.760.g7b8bcc2412-goog > > Reviewed-by: Bryan O'Donoghue