From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24CD22D8766 for ; Fri, 21 Nov 2025 12:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763728424; cv=none; b=TvyPzbA69a2UFm9LIvwwT0O+GQQrK7WLzfGs/OeK5MAEcG9DtU4A48GNSJzxoSIvxjvs1ixQNlz18cGPvT6QOmhbLvva5OYAsWBgpKlLBSULo7YpDH0QdDYq7YMFwelqQ6PuPeuP8DIbpcM4RIkGOgqfdJSmzRIPga4iYDNeQvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763728424; c=relaxed/simple; bh=We+RK2t7L/icmLWKTcWMLB+AL1ZVy8D0dTK1FclInXE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rklazwzPj4MM5J5ok0m6RRk0B2leFJG5Zqw6KcF8d6ReHSVrq171bwbhqA1AZ08370ixJ9zK9c8aATKxmcyGQ4W41l3B4D9Stdvto/5O0GMGAxqo6RvNR86TBOWXe6jBsxO3WSjqJ0lKpbtV8gE0pfCsYDAibhkKwI3zKITV4i4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=NrBaNW01; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="NrBaNW01" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b739b3fc2a0so291396166b.3 for ; Fri, 21 Nov 2025 04:33:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763728420; x=1764333220; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=rwWokcp88y0Xy+2dctPcgYbaRe8Xf20qtSwDBPH+lwc=; b=NrBaNW01DRvi71iwRKsiLBX1nYmFW+UvB1BV1XP5TEgCoij1O/2uKcS+ewtyLAFEYy sKTrdSNxAqiwZL5tRIjnW3qRcN5G+FtYfNyN6GatnODBCFtzxg7VE6GkwcNW3M+H6H9+ nlEgp+v7Yd/b9yS0G6syDCrP5h5++eZ3ZUMnGBmxn6cyaqbqCAHC9tblQNoK+LpbzfE4 6rx/0gMvtz4M35ZRRtm14mxrZUsku6WonKfNmNLlmsIIvCtKRXb9Pwq+CNcT1ToLzl2b gu3HpFANxQ37MJbSN0oxCFk91CjnQb2ikALZf9TGunXhzuHcyDQNUhfe5PIE3udXpcdq SMmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763728420; x=1764333220; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rwWokcp88y0Xy+2dctPcgYbaRe8Xf20qtSwDBPH+lwc=; b=DYO2kpbDwfVOSgaL3t1pmicsOWGboc7IaPq3CeNqyN1y4fI9+MBB9k2qrDWU/ETW7/ MwLrWB1lRvKa7VY8ClNY5iSGSoGzS9d+loafoLQy8uUsySzwXyjxI3gBEQIB+l7bMPfM hxx+hZTGQKxLW5W+X66W0x4RA58nBlf0FTOUp2/wK0eyqhrIB7IkSLP4lDYL4/5lZM3J uuTV1hrQoh/DpYnQZmQtBxvqyiW2Em8lyaNw029tkn+jqBrBmnP6dDf1u28bZXyPBIYW Dlbf02+oHQDqR2l7EfREmeJkVY4JF4Qr2ZidGWqXB7PVJDMNT5dsIMhUm0WVaxyFtCE2 2E/A== X-Gm-Message-State: AOJu0Yz4ucw2B8ZBIx4Vj7ruep2GZjB5yVreyP/q9kCkPE0rSqgF14oA IIzyZML4vLll3J038YePqmxUxat+txIfa6VdBuy55MLQYJjsPEjufG5QsGOYy8VefJs= X-Gm-Gg: ASbGncuap1H9IJ7sQxqzk5YM75GSLqJ194hETukgOkO2uSvFcN6x0lhwTz1u4CdcyBY kfLIEQVyw0Tu3gp7FO8TXpfyeRsooTnLrzNi3WQRR7Ay0as90ab+/pgouqNHB+D1t4Js+gVHjO8 Diow4FujZlCMSna5UmGr4h2fyVaySudKvYRlRdiQILlq+NxWW64t5HEIrABNQKl/VXMcTLXAaDJ fogCVpArikIYmy7XNwOiDQ/pUYMytKGC1v2X/cFXLPXRK3x3TcOxK8/8k0MR+HN8gQmSlpjslA8 plN3Mk7S4GNMCTEhzRYjYypFDARtEVpKF5CRQYi9YrAWLG6Exg76lCCYptNFz7EmQXuv2jHVCFN i0LwUPA7U2AeWZutJI4zxLoE42SHTyIWSLJO3UTD+WDKhlUvIg16hZam236PUatgcmjBt8ci2/f Ap9HYj3NjIVOh1606lwiKhNe6L4nqqi8eCiAJ95lhjqSTKMU0= X-Google-Smtp-Source: AGHT+IGsGifeSMN2TPl3sbBA0J/iLAD0++giOZXZKBOu/HH0S8KfC6LE3T5jqoLt8s+Tj/B77xua+g== X-Received: by 2002:a17:907:3c93:b0:b72:598:2f32 with SMTP id a640c23a62f3a-b767185b3eemr258108866b.42.1763728420137; Fri, 21 Nov 2025 04:33:40 -0800 (PST) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [85.187.216.236]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64536443715sm4320598a12.26.2025.11.21.04.33.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 04:33:39 -0800 (PST) Message-ID: <8b657ef2-d9a7-4424-987d-111beb477727@suse.com> Date: Fri, 21 Nov 2025 14:33:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/11] x86/bhi: Make clear_bhb_loop() effective on newer CPUs To: Pawan Gupta , x86@kernel.org, David Kaplan , "H. Peter Anvin" , Josh Poimboeuf , Sean Christopherson , Paolo Bonzini , Borislav Petkov , Dave Hansen Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Asit Mallick , Tao Zhang References: <20251119-vmscape-bhb-v4-0-1adad4e69ddc@linux.intel.com> <20251119-vmscape-bhb-v4-4-1adad4e69ddc@linux.intel.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20251119-vmscape-bhb-v4-4-1adad4e69ddc@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/20/25 08:18, Pawan Gupta wrote: > As a mitigation for BHI, clear_bhb_loop() executes branches that overwrites > the Branch History Buffer (BHB). On Alder Lake and newer parts this > sequence is not sufficient because it doesn't clear enough entries. This > was not an issue because these CPUs have a hardware control (BHI_DIS_S) > that mitigates BHI in kernel. > > BHI variant of VMSCAPE requires isolating branch history between guests and > userspace. Note that there is no equivalent hardware control for userspace. > To effectively isolate branch history on newer CPUs, clear_bhb_loop() > should execute sufficient number of branches to clear a larger BHB. > > Dynamically set the loop count of clear_bhb_loop() such that it is > effective on newer CPUs too. Use the hardware control enumeration > X86_FEATURE_BHI_CTRL to select the appropriate loop count. > > Suggested-by: Dave Hansen > Signed-off-by: Pawan Gupta Reviewed-by: Nikolay Borisov