From: "Adrian McMenamin" <lkmladrian@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Correct use of __init and __devinit
Date: Sun, 23 Dec 2007 16:56:14 +0000 [thread overview]
Message-ID: <8b67d60712230856o73bc89d7u142b93fc47b7533b@mail.gmail.com> (raw)
Could someone here help settle this argument?
I have written a driver (for the CD Rom on the Sega Dreamcast). I have
marked various initialisation functions - including probe() and the
functions that it, and only it, calls, as __init.
Other developers tell me I should mark them as __devinit.
However I think this is wrong as:
* The CD on the Dreamcast is not and will never be a hotpluggable device
* The Dreamcast is a limited memory device and if marking various
functions as __init helps save memory that is A Good Thing
It has been put to me that while the use case (not hotpluggable) is
correct, it is still better practice to use __devinit
I have built the code with both __init and __devinit and both work, so
there is no issue of practicality as such here.
Adrian
next reply other threads:[~2007-12-23 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-23 16:56 Adrian McMenamin [this message]
2007-12-24 13:01 ` Sam Ravnborg
2007-12-26 22:50 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b67d60712230856o73bc89d7u142b93fc47b7533b@mail.gmail.com \
--to=lkmladrian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®