From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D34CEC433E9 for ; Thu, 14 Jan 2021 21:24:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82C382310F for ; Thu, 14 Jan 2021 21:24:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729594AbhANVYB (ORCPT ); Thu, 14 Jan 2021 16:24:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726123AbhANVYA (ORCPT ); Thu, 14 Jan 2021 16:24:00 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED675C061757; Thu, 14 Jan 2021 13:23:19 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1l0A57-006O3k-Sa; Thu, 14 Jan 2021 22:23:01 +0100 Message-ID: <8b6f763d3eba85f664fd05d7a3c7c311c0648da2.camel@sipsolutions.net> Subject: Re: [PATCH v6 12/16] net: tip: fix a couple kernel-doc markups From: Johannes Berg To: Jakub Kicinski , Jon Maloy , Mauro Carvalho Chehab Cc: Linux Doc Mailing List , Jonathan Corbet , "David S. Miller" , Ying Xue , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Date: Thu, 14 Jan 2021 22:22:58 +0100 In-Reply-To: <20210114103402.31946ed4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <9d205b0e080153af0fbddee06ad0eb23457e1b1b.1610610937.git.mchehab+huawei@kernel.org> <20210114103402.31946ed4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-01-14 at 10:34 -0800, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 10:59:08 -0500 Jon Maloy wrote: > > On 1/14/21 3:04 AM, Mauro Carvalho Chehab wrote: > > > A function has a different name between their prototype > > > and its kernel-doc markup: > > > > > > ../net/tipc/link.c:2551: warning: expecting prototype for link_reset_stats(). Prototype was for tipc_link_reset_stats() instead > > > ../net/tipc/node.c:1678: warning: expecting prototype for is the general link level function for message sending(). Prototype was for tipc_node_xmit() instead > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > > Acked-by: Jon Maloy > > Thanks! Applied this one to net, the cfg80211 one does not apply to > net, so I'll leave it to Johannes. Right, that was diffed against -next, and I've got a fix pending that I didn't send yet. I've applied this now, thanks. johannes