From: Tom Rix <trix@redhat.com>
To: Russ Weight <russell.h.weight@intel.com>,
sudeep.holla@arm.com, cristian.marussi@arm.com, ardb@kernel.org,
bjorn.andersson@linaro.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Cc: lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com,
matthew.gerlach@intel.com, "Gong,
Richard" <richard.gong@intel.com>
Subject: Re: [RFC PATCH 0/5] Firmware Upload Framework
Date: Mon, 15 Nov 2021 05:57:01 -0800 [thread overview]
Message-ID: <8b7bbdcd-ef48-9f48-10c0-021c41575522@redhat.com> (raw)
In-Reply-To: <20211111011345.25049-1-russell.h.weight@intel.com>
On 11/10/21 5:13 PM, Russ Weight wrote:
> The Firmware Upload framework provides a common API for uploading firmware
> files to target devices. An example use case involves FPGA devices that
> load FPGA, Card BMC, and firmware images from FLASH when the card boots.
> Users need the ability to update these firmware images while the card is
> in use.
>
> Device drivers that instantiate the Firmware Upload class driver will
> interact with the target device to transfer and authenticate the firmware
> data. Uploads are performed in the context of a kernel worker thread in
> order to facilitate progress indicators during lengthy uploads.
>
> This driver was previously submitted in the context of the FPGA sub-
> system as the "FPGA Image Load Framework", but the framework is generic
> enough to support other devices as well. The previous submission of this
> patch-set can be viewed here:
>
> https://marc.info/?l=linux-kernel&m=163295640216820&w=2
>
> The n3000bmc-sec-update driver is the first driver to use the Firmware
> Upload API. A recent version of these patches can be viewed here:
>
> https://marc.info/?l=linux-kernel&m=163295697217095&w=2
>
> I don't think I am duplicating any functionality that is currently covered
> in the firmware subsystem. I appreciate your feedback on these patches.
This may be a common api for fpga/dfl-, but it is not likely common for
general devices.
Could the scope of this patchset be reduced to just fpga/dfl for now ?
Something more like stratix10-rsu.
Tom
>
> - Russ
>
> Russ Weight (5):
> firmware: Create firmware upload framework
> firmware: upload: Enable firmware uploads
> firmware: upload: Signal eventfd when complete
> firmware: upload: Add status ioctl
> firmware: upload: Enable cancel of firmware upload
>
> .../driver-api/firmware/firmware-upload.rst | 54 +++
> Documentation/driver-api/firmware/index.rst | 1 +
> MAINTAINERS | 9 +
> drivers/firmware/Kconfig | 8 +
> drivers/firmware/Makefile | 1 +
> drivers/firmware/firmware-upload.c | 413 ++++++++++++++++++
> include/linux/firmware/firmware-upload.h | 69 +++
> include/uapi/linux/firmware-upload.h | 73 ++++
> 8 files changed, 628 insertions(+)
> create mode 100644 Documentation/driver-api/firmware/firmware-upload.rst
> create mode 100644 drivers/firmware/firmware-upload.c
> create mode 100644 include/linux/firmware/firmware-upload.h
> create mode 100644 include/uapi/linux/firmware-upload.h
>
next prev parent reply other threads:[~2021-11-15 13:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 1:13 Russ Weight
2021-11-11 1:13 ` [RFC PATCH 1/5] firmware: Create firmware upload framework Russ Weight
2021-11-17 15:15 ` Greg KH
2021-11-17 18:00 ` Russ Weight
2021-11-17 18:18 ` Greg KH
2021-11-17 18:47 ` Russ Weight
2021-11-17 18:54 ` Greg KH
2021-11-17 20:02 ` Russ Weight
2021-11-11 1:13 ` [RFC PATCH 2/5] firmware: upload: Enable firmware uploads Russ Weight
2021-11-17 19:29 ` Bjorn Andersson
2021-11-11 1:13 ` [RFC PATCH 3/5] firmware: upload: Signal eventfd when complete Russ Weight
2021-11-11 1:13 ` [RFC PATCH 4/5] firmware: upload: Add status ioctl Russ Weight
2021-11-11 1:13 ` [RFC PATCH 5/5] firmware: upload: Enable cancel of firmware upload Russ Weight
2021-11-15 13:57 ` Tom Rix [this message]
2021-11-17 19:20 ` [RFC PATCH 0/5] Firmware Upload Framework Bjorn Andersson
2021-12-09 15:15 ` Tom Rix
2021-12-09 15:34 ` Greg KH
2021-12-09 18:55 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b7bbdcd-ef48-9f48-10c0-021c41575522@redhat.com \
--to=trix@redhat.com \
--cc=ardb@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cristian.marussi@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=richard.gong@intel.com \
--cc=russell.h.weight@intel.com \
--cc=sudeep.holla@arm.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®