From: Sylwester Nawrocki <snawrocki@kernel.org>
To: Hugues Fruchet <hugues.fruchet@st.com>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Yannick Fertre <yannick.fertre@st.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 2/7] [media] ov9650: switch i2c device id to lower case
Date: Wed, 12 Jul 2017 21:18:52 +0200 [thread overview]
Message-ID: <8b84296e-b3c7-f5d1-5e90-5890b1b0ed48@kernel.org> (raw)
In-Reply-To: <1499073368-31905-3-git-send-email-hugues.fruchet@st.com>
On 07/03/2017 11:16 AM, Hugues Fruchet wrote:
> Switch i2c device id to lower case as it is
s/i2c/I2C ?
> done for other omnivision cameras.
s/omnivision/Omnivision
This is required for properly matching driver with device on DT platforms,
right? It might be worth to mention that so it is clear why we break any
non-dt platform that could be already using this driver. There seem to be
none in the mainline kernel tree though.
> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
Reviewed-by: Sylwester Nawrocki <snawrocki@kernel.org>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
> ---
> drivers/media/i2c/ov9650.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
> index 2de2fbb..1e4e99e 100644
> --- a/drivers/media/i2c/ov9650.c
> +++ b/drivers/media/i2c/ov9650.c
> @@ -1545,8 +1545,8 @@ static int ov965x_remove(struct i2c_client *client)
> }
>
> static const struct i2c_device_id ov965x_id[] = {
> - { "OV9650", 0 },
> - { "OV9652", 0 },
> + { "ov9650", 0 },
> + { "ov9652", 0 },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(i2c, ov965x_id);
next prev parent reply other threads:[~2017-07-12 19:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 9:16 [PATCH v2 0/7] [PATCH v2 0/7] Add support of OV9655 camera Hugues Fruchet
2017-07-03 9:16 ` [PATCH v2 1/7] DT bindings: add bindings for ov965x camera module Hugues Fruchet
2017-07-05 14:03 ` Rob Herring
2017-07-05 14:48 ` Hugues FRUCHET
2017-07-03 9:16 ` [PATCH v2 2/7] [media] ov9650: switch i2c device id to lower case Hugues Fruchet
2017-07-12 19:18 ` Sylwester Nawrocki [this message]
2017-07-03 9:16 ` [PATCH v2 3/7] [media] ov9650: add device tree support Hugues Fruchet
2017-07-08 23:06 ` Sakari Ailus
2017-07-18 10:26 ` Hugues FRUCHET
2017-07-12 19:33 ` Sylwester Nawrocki
2017-07-03 9:16 ` [PATCH v2 4/7] [media] ov9650: use write_array() for resolution sequences Hugues Fruchet
2017-07-08 23:08 ` Sakari Ailus
2017-07-03 9:16 ` [PATCH v2 5/7] [media] ov9650: add multiple variant support Hugues Fruchet
2017-07-03 9:16 ` [PATCH v2 6/7] [media] ov9650: add support of OV9655 variant Hugues Fruchet
2017-07-03 9:16 ` [PATCH v2 7/7] [media] ov9650: add analog power supply and clock gating Hugues Fruchet
2017-07-06 7:51 ` [PATCH v2 0/7] [PATCH v2 0/7] Add support of OV9655 camera Hugues FRUCHET
2017-07-09 16:18 ` Sylwester Nawrocki
2017-07-12 20:01 ` Sylwester Nawrocki
2017-07-18 11:59 ` Hans Verkuil
2017-07-18 12:17 ` H. Nikolaus Schaller
2017-07-18 12:53 ` Hugues FRUCHET
2017-07-18 19:52 ` Sakari Ailus
2017-07-20 8:37 ` H. Nikolaus Schaller
2017-07-20 9:17 ` Hugues FRUCHET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b84296e-b3c7-f5d1-5e90-5890b1b0ed48@kernel.org \
--to=snawrocki@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=hns@goldelico.com \
--cc=hugues.fruchet@st.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®