From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758669AbdKOR0F (ORCPT ); Wed, 15 Nov 2017 12:26:05 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:54744 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758065AbdKORZp (ORCPT ); Wed, 15 Nov 2017 12:25:45 -0500 Subject: Re: [PATCH][v3] uprobes/x86: emulate push insns for uprobe on x86 To: Oleg Nesterov CC: , , , , , , , References: <20171113221139.1516536-1-yhs@fb.com> <20171114155124.GB17667@redhat.com> <20171114160304.GA19323@redhat.com> <946788b4-e57b-c7c2-9ba8-3c6fe87c4af8@fb.com> <20171115154707.GB21275@redhat.com> <20171115170734.GA12415@redhat.com> From: Yonghong Song Message-ID: <8b85fd71-a35a-bd36-1490-cc8fd0b4dad6@fb.com> Date: Wed, 15 Nov 2017 09:25:05 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171115170734.GA12415@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:200::4:cd8f] X-ClientProxiedBy: CY4PR02CA0023.namprd02.prod.outlook.com (10.169.188.33) To CY4PR15MB1830.namprd15.prod.outlook.com (10.174.54.15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f808219-216f-4d1f-39d3-08d52c4dd203 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:CY4PR15MB1830; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1830;3:cokMsQueFEfKhV7n0sq+UbGGLG8iAgq5DtD5EK/fDwyXqeo6ykPgzJpvoce7ZeoVzXI8qtR+BqbRCzyE+bdlzMMrzWyCIEybtOVvqtOaBEoedoWYFfP/B3+kigCz07fHsNCS+W/OQR2wDdpgRvySFpQ/8Neff5gP+xc10Y+Tj49Br3Svvu+FJannH9pkYZHTBTsVZ6zgmOtARpHqGq9lqUQTxHQacjukGfRmtW60gaS3k9G9UWs41n01w44WZR0J;25:ouBQt1Dl862mGLWBDzTu7i8ny2Qt/w1676vY7U//2RKKqQScWuidQO04w70G1HiIu7Rl2BP3akUdrDIk4B0FQnt64V0yYujD83DG5A2HdeH92ABGcac0c9XitXYSRUHWr17UNTgn9OLXH6RBae4YTtZxIsl0tuqEQmq2x90hwah05ye6DSCzuSiLObZWm5qUZ77Ar/A/FQ4+wB8x84YnEMcFxOfcDv2LTk4qpZN32VWZwq5IaD47p891QYutmuk2twfpq2TWNFluUu+nPInoHbzUl/0w0ZXvQfl9K3QtZpy/Ui83xw1/nY+wzzuJB0t0kF6AcQgs8mq1NUWWu5bJtg==;31:/Y6YGvsv35g1/IZM7ltAGLylYvCM4Hupiogf/qo+FyUtoapK6NCYIIYFpjK05Le/LJGYimorO7ewjahNKkO7z6U1LZuGwNIXbq33mon+g/eEHSvqI9e/3BhsBFm/KrfYfcCyU++88q816sQrmkwvqMGJl9xNI1EH/kZcAcaZp74xO7qDKHWVO/7vlF9B6X/xFP0Ey+RSXRCPcdAq48ry+oE1H5yADzyDxQ7L6rmvdcM= X-MS-TrafficTypeDiagnostic: CY4PR15MB1830: X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1830;20:XqPnshPhds97JeNNfwA2BwqbIqbkWLCham+MFF1TdOkxusoXGfiMfUyfJcSp56xCGpP0u55N1Nd0y1dQZD6LHnMtf2799vK0R1YfN13I1QHz5HNB+yPXB4ITtPZa6WFjRVQVebHzWmjPw6AS/lGsYo0ycgyzP2YbJV2aCtevrXESpxCKmMOuezfoglfZW8mH6rNC7D/tjkOwJIU/K0R2VWhR74+vJrPFxEJOUKvyII1IIdBTJh9GNiEq+r3q6BAq2BZuK08Yj8fGhyn2GX5Xcgv7QYj7YDmBZ8FtJPdHcJU1DYKtBw9K79Mq9DDYv4r+RptWmI8ySGo01LVIyXvhLG2mLzCynNF0H8J+K5HFwmoHS5oIPQFUQIx+BV2hzwbUEQaEWq4zgMIrC4ddBcsuqu1oC81+lUtRTYxdCxSDwB71LhsHAb2BvCn+AGTJLpKBB56aKAwf70AXn6xPJU50/vR5JhjGeZjQi8Luiqrq8U7/2zhi7H8YY6r25x/+tIK3;4:2erQS/pi76VELbdNDHLmEdwfhc0eOIR9ZKSnncfW/8WhQmRyiZTLXvV3bLPI+uwbdrY9S/z7CLJxw6rTKyIeKHmVQJBiRB3i1EW8Vzj1DZBwaMb4zehq7P8hVn0pVr0DqYcdjIl9QRlq0kwAHw5Wj5umyFhsqoitTcSyCCfoXmSaRY6dFA+EMN8zIMWFpWiJtU/cPLS683zX/NiWlAb2yYDEBOKjk6Z3MJnayPJ8KUM0bt1HZj3WNXTzBuikzdYfYxlL/oO1yf78LIcVCu217Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231022)(3002001)(100000703101)(100105400095)(6041248)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR15MB1830;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR15MB1830; X-Forefront-PRVS: 0492FD61DD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(199003)(24454002)(189002)(33646002)(6116002)(31686004)(36756003)(86362001)(478600001)(6666003)(6916009)(230700001)(2906002)(2950100002)(58126008)(4326008)(68736007)(31696002)(305945005)(97736004)(7736002)(67846002)(47776003)(93886005)(81156014)(8676002)(23676003)(81166006)(8936002)(83506002)(53546010)(54356999)(76176999)(106356001)(6246003)(50986999)(25786009)(229853002)(316002)(101416001)(189998001)(53936002)(65956001)(65806001)(6512007)(6506006)(105586002)(6486002)(50466002)(64126003)(5660300001)(65826007)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1830;H:raviram-mbp.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjE1TUIxODMwOzIzOk02cnhpOS9TQ1NDTGtwai85a2xLQWlRUHVN?= =?utf-8?B?S1FvT2tpUkFvemxTekVxdFllUTJvMWNUOG5KTnRDSUg4b2VWWDVHdkFmVjRp?= =?utf-8?B?Zy9aajMyRzliMlBIeHhNSW82OXh5QVBvbVNYQ0F4R050QWp5cFg2YUxuQXBK?= =?utf-8?B?azRvRmd3Tnp1UDJMUTFETXdHdHFyUGM0bkYrRm5HZGY2RnZTbXcxb2xrYmRV?= =?utf-8?B?QXZWeC9JOGJCMGhwcGFkcE1LaHVROFViejNFUlVWR21KTmVSYzVadGlUejlw?= =?utf-8?B?YTk5RzlQdDlhWFg5NGwreSt2MGY1Rytpa0N4RW1MdnFwdXpKRmNCYkYyTVhZ?= =?utf-8?B?M0dkMndFWWRkV2xGUEFDQi9oYXd6eWMzc2FQQjFCOXJXdE05azUxd2xRUzdu?= =?utf-8?B?bDNwOTRObThTbUVaWmRQVVpndDR5NjhjWW4wRjNzYzJHMDVMNFY0SFdxNXNG?= =?utf-8?B?Ni9OYTFJbTVRTVlhQnZVUktyNzJWa2RjSWh1aHFYY0tNVUFBRVdTbGFxZXFm?= =?utf-8?B?cTB4aWlYK3g0dko5b2FIVjdlWHZvaEdoU0hSZ3BJWGhxdFZYWTJaaTZyeVZE?= =?utf-8?B?cmhuSjV4UE02U1pqbXV0WWphM1BtdnBkQ2VmRjJsKzBxZkp5QklXek5XVjRO?= =?utf-8?B?ZnpPVlhJaXB2NWNJdzdzV0pUTXlKRjRyMlBtTURyMWo2ZkNuRmJBU2NqRDBY?= =?utf-8?B?NlZLMytBZHRmVXVycE9uVmM3NWNFQlFYUGp5c3RiQjNnSzQwTkt2ZVJkZzJi?= =?utf-8?B?L0pmdjZDVENDamRhalUwZktuNWN2Z3ZIZnRzSm0vMitrSWJ2SHdicDVjQWZm?= =?utf-8?B?RzBhbzlrZ3BLM1haYVQrRWFPVmprRU0yMmRiblhkT2lVK1UyYlQxQVRQYTV1?= =?utf-8?B?MXVOcFF1N1EzRFVzL0ZDREJ3a2srZFZrMTFVVTg1L1ZDaXNhVDVSd3NaOWdj?= =?utf-8?B?c01HQjhFY0hiK0tVaXpSbkxrTEZlaXdMd2FCM2w2cEwwTmVWVHZsUmFGN1V2?= =?utf-8?B?UmlKRm5kTnFjdDQrSHNhd1FSTXFuQVZsUStoSU96bXJNdFpCTExPTVRQa2ZO?= =?utf-8?B?eU9KQmsyMkFIa0xkUXl3dkcxYUwxQ29nYmlVMk9jR2pKV2pRZ1FIaGN2ajJR?= =?utf-8?B?cUYvZXhzL29mYVVSSTBpVFdvNDBEeEN2MGcwdlE3ZklJMjVJdkFKWmFIa012?= =?utf-8?B?QnFENEN6OUxJRDBrakNSVFFhcjEyenk4cUpuZXRhbS9ZUlFTUisrYk5qTUFO?= =?utf-8?B?NThYQnFmUTRuZUxoSW5McUVNL2VCckVZWVpNYVFsKzhjQ004Rys2RkNpVjBz?= =?utf-8?B?T0hJeExiME0vVFkrVWs5TXhiVzJiUEdiVU05WE1ocGZXbk9iTnFNeGNOek9V?= =?utf-8?B?L3JCYm9yTFJFVWM0ZnJaMFZuMjQyN3ViZ1RSRS92TXVlbHpvT2NUaXhneWw3?= =?utf-8?B?M01QZzl4WmVoNWt6NEFMVFMyMUdWQ0FEMmNRZUNQM25kVmo0OHgzWE43RUpn?= =?utf-8?B?NG1FKzd6MGFTZzBRZzBnWEc2bHF4L000ZE9CRER4UEJZOFZPUFdCRHBkUGQ3?= =?utf-8?B?MGdzZkpZcFdoaXUzZUtQN2piNTRjMEpFTjJPcURvcDV4TWhCckxkZ3g3QXFY?= =?utf-8?B?eFZBZjBrZ3hIazFUK3hBcXJIdGVJOVJ5dStyUlZZd0syWForYithSWxtVVFm?= =?utf-8?B?YWpqSFcyWmhWUDBDWGlqTWtTL1ZSYnNmRHFwWXRFZDVHWUszMWtYV0RTVnF2?= =?utf-8?B?clVpWmY3bjNSMi9RSGRzZz09?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1830;6:RNMILlIhCSaEkFYR0Q84UPGbaWIUx8CPI8UH31fBOcCzc5dUi+SVH1uDM34noqeKuolKOXDNLpFAyit/xH8d2h0Luc1fZDpWCZRWx4io0OwAWF8UrCZ+Jut1ndk48ntJuBYOnWZdpMkqdCBKJRbvmMUBgFuVuBdYj1HCVcLZmBIUtwWR7QEsvUUbDwlUWXcVNIzggyb8WdMb2B5h3w/DOhZ+3cFboRVrZ8HYypnUUl8Hl1+X9HeoIQ6Fo4cetCg6qv25/CkEqQonRg7cZJxHM0UWtQlrXrZz5s1ZEJG+HcTa3RAqhojYvGWc1g5M4e1+LqcXguaAVfZbdiTA8pITXXi5Or5yp8P+IkZjY+zndPM=;5:xyskjNA4/fZal/DpXleU5vhxxvJFozTXSrG/FL9zQVTmDaFKDkTHg9f4wsencaA5fKdOxspqrJllneSpMyRKhjctXkPmbnIEGPo8q7tsMM6ucrmv7B+pIaap+WQ2YGV8DLSllHdloLbqs/ZmlPxsHPyL3MU/S2auwbcFgklVrWU=;24:ut57a7hzFbwp9M6snoKIUphpk09pF/60wJcDK1FZHaKNf56g+PjocU0EeikHAx9Iy66IsZfpGCDcbsGzVbv2nb2Sku5402Jmauyrg/xhmKI=;7:yIsNtOzGsoiQVMlQ1lIU7RwrMh34izvNjkwuEbJmlNRNlH7chAHwpSbjNaEh7KyrtgDHN+SgoSBY2YbvbljxUEhpiIi8vFBOT6pu3//J26FErIfnpZ0GDAQ8+cYu7hjxWJRdV9GU+c1gkAEvwsTK5cY2IwsNIXOfELf6GlOIsaqneeiiDct6i1FdJ19kLMW1uqklrPp3n+uA+FGcLSr7wgMTkNe4GScei+eDWrF4kUc+U9jxQmTh68/9QCqdY8Ry SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1830;20:J/sbWVrC/AZ+wUUvfKv74E3A1YW50Elsg7GGMNFvMF5MdA7zNpEdTsOoysX1ZjocYd1HHkXTCSnah3dJXCc7nUpx+XMC+4/zqX37r/624+YXs0M9H/K0OC4ZbrA5kTYI/GbOozK5teju3+rxKrkxpjtbCSwWI4TboCbYViur4Gs= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2017 17:25:08.1730 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f808219-216f-4d1f-39d3-08d52c4dd203 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1830 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-15_09:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/17 9:07 AM, Oleg Nesterov wrote: > On 11/15, Oleg Nesterov wrote: >> >> So please, check if uprobe_init_insn() fails or not in this case. After that >> we will know whether your patch needs the additional is_64bit_mm() check in >> push_setup_xol_ops() or not. > > OK, I did the check for you. > > uprobe_init_insn() doesn't fail but insn_init(x86_64 => 0) parse it as > single-byte insn with OPCODE1 == 0x41, so push_setup_xol_ops() doesn't > need to worry about compat tasks. > > In short, your "V2" should be fine except you can factor out > auprobe->push.ilen initialization (as you did in V3). Please send V4. Thanks a lot! I am just about to use inline asm or binary rewriter to create such a code for testing... I will send V4 shortly. > > Oleg. >