From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CCEC4321A for ; Fri, 28 Jun 2019 13:57:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15A5B2083B for ; Fri, 28 Jun 2019 13:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726903AbfF1N5L (ORCPT ); Fri, 28 Jun 2019 09:57:11 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:51384 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726707AbfF1N5L (ORCPT ); Fri, 28 Jun 2019 09:57:11 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hgrNE-0002pi-MB; Fri, 28 Jun 2019 15:57:08 +0200 Message-ID: <8b8c44c3ecb8626d9bb5a8f786b1d2b7488df86b.camel@sipsolutions.net> Subject: Re: [Linux-kernel-mentees][PATCH v2] nl80211: Fix undefined behavior in bit shift From: Johannes Berg To: Shuah Khan , Jiunn Chang Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 28 Jun 2019 15:57:05 +0200 In-Reply-To: (sfid-20190627_053427_689527_6C7A1CBE) References: <20190627010137.5612-4-c0d1n61at3@gmail.com> <20190627032532.18374-4-c0d1n61at3@gmail.com> (sfid-20190627_053427_689527_6C7A1CBE) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-06-26 at 21:34 -0600, Shuah Khan wrote: > On 6/26/19 9:25 PM, Jiunn Chang wrote: > > Shifting signed 32-bit value by 31 bits is undefined. Changing most > > significant bit to unsigned. > > > > Changes included in v2: > > - use subsystem specific subject lines > > - CC required mailing lists > > > > Signed-off-by: Jiunn Chang > > --- > > Move version change lines here. They don't belong in the commit log. FWIW, in many cases people (maintainers) now *do* want them in the commit log. Here, they're just editorial, so agree, but if real technical changes were made due to reviews, they can indeed be useful. johannes