From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011014.outbound.protection.outlook.com [52.101.62.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51E8614B977 for ; Mon, 2 Mar 2026 04:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.14 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772425030; cv=fail; b=RUmjBq6nAJupeH9967ZNXlHO4ah7j6BMc1qAHA9o0fWm1C4ME9hkb1oHWsw23ziSu0duWxjAFFnDaJiu47mvdXPClElnNqa4Ms4hreyKIe97315ihWQLzHVkZJCCpI2QDkI4K8BG+tzd52QdNY5X0zAbkk4OiPF+zyCb/hDtfeU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772425030; c=relaxed/simple; bh=fMlCWH8K2nL/wX5BE9Hcn8sYB5Msx/Iz5JZr8QQioZE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=iSiJesOelHbdX91cAteAPk7M0qtIIRP+QyLVFvM5cAlddCQ9KUU/D7+CiuQsM27pTdnne3XEBr8r7Gj/xdcvI5GdOQtJxf4v9lqNLIBh7Lm7ZTqvZ5rElJr9VLo7ZlmJhkyosooZ/YktwX7aJKLOB3AS7vhl4ISJGcBt+HdFFfg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=IlFQyf9s; arc=fail smtp.client-ip=52.101.62.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="IlFQyf9s" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hBEXnnxD4LrjI5BZmys/Dpq+UKHVNXren9xl8c7H3xSyNR8E2o6op02knH9Qq5T0z6WSVpPwGFCxkltZnV/gy6qimL/nOpLCg/ID+pd6vxOLWNZNdWl2GbrYTNAEF7n+wGNGpCsfb9ZomNlfI8ChVAnCQvhJemBd/Vr8AJ7JNeKhH4RqAaH/n9d5DX3B5rCEI3WqW7Si2g2jzXJ/aniGfnqx4VCVlt88eEfsl9UieV6z82Q0AODUYdKxFVPWmWrHOjxEa0jOf+HYXUrkiz1ZhMczeEQzR4fuR2o7/vLUM+Mo1MAtIlAPk/EU0Gf8enY0WQ2hDaZbt3SzV7GMhmLWUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d1lqzBo+Qbsy2Xe954aIUU1EEPQvitI7AWNwA58rGbM=; b=iMiKGOiNaAF+gOmju8J+Mmkua29XS1q98dWG8fsQLL/TPQSOZbsjd7jjhsFPO8La6lrtFmM6JLgMj6ktP9v9U71ESwD1kWCDJvpoxZMRUsnTHRAl/pkrVwhD3H4w4xF0VpmN03nFBTU19UW8Ou+DFL5Q7lItLXFb68s6bEFVzwYNW/OGuMMoV+5wm3lCPg9bOtq75+bzJAOGoYhE55dPC7m64ZZgupQYUKdLKjAWYY3KURfN0jqnmZeRXjR5Ys8inHKTyycGboda4zl8in7eSBv7uikVddQygQ8PCKLTkYkTvIEqr/Wpbvvnl1SpaQpIaS92MAIX6GdpYlGxLW4chg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d1lqzBo+Qbsy2Xe954aIUU1EEPQvitI7AWNwA58rGbM=; b=IlFQyf9sTz3Dyhn88y5/9HlPkXPIuqMOHAe6lEqDoE5yakDqJlgsJxIEApoHA9b3avKG+hCEKVyUTphje+YPyqQu1wG3qY7z8N9tUGcNk8IfPBYtF8is6VtGqHPYetWICel5UJ4SOn9g018gmWCdIDcGWnqE03QcEEyUsw7+TgE= Received: from BL1PR13CA0160.namprd13.prod.outlook.com (2603:10b6:208:2bd::15) by PH7PR12MB9176.namprd12.prod.outlook.com (2603:10b6:510:2e9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.20; Mon, 2 Mar 2026 04:17:03 +0000 Received: from MN1PEPF0000F0E4.namprd04.prod.outlook.com (2603:10b6:208:2bd:cafe::35) by BL1PR13CA0160.outlook.office365.com (2603:10b6:208:2bd::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.19 via Frontend Transport; Mon, 2 Mar 2026 04:17:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by MN1PEPF0000F0E4.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Mon, 2 Mar 2026 04:17:03 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 1 Mar 2026 22:17:02 -0600 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 1 Mar 2026 20:17:02 -0800 Received: from [10.136.33.80] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Sun, 1 Mar 2026 22:16:58 -0600 Message-ID: <8b8e7b6f-c874-48d5-8402-77eca5425b1d@amd.com> Date: Mon, 2 Mar 2026 09:46:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC][PATCH 2/6] x86/topo: Add TOPO_NUMA_DOMAIN To: Peter Zijlstra CC: , , , , , , , , , , , , , References: <20260226104909.675623579@infradead.org> <20260226105052.355756378@infradead.org> <76776da9-2552-49de-91c7-41e767c248fa@amd.com> <20260227140614.GF1282955@noisy.programming.kicks-ass.net> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260227140614.GF1282955@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E4:EE_|PH7PR12MB9176:EE_ X-MS-Office365-Filtering-Correlation-Id: f3a7ca82-da69-4b88-9bbd-08de78128ea8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: 9S8ALix8eI7oNk+JncCcUPpnOfV7TPCfRxXTo9skWSpX/aqof3Mp6tRhKq7wyCDnsBXMlKqScLS1fQMmuhae6hSASWgMKn627kQ1/P3XRCbW7Yt6fd5e4SImIEhfWIW4gl2hyENXxRw2hw6H/OCxnR24WkP44rd13LuWn7KRD+hxLXS6iwY9jTeXUvhktT54BEC+euwmxDReNRoYB5+MFnpluxBAXPxMc3NDD0oVzP3H3aBQTOBV2Y8kwG9J/fL2VLfxi6/RcLuPfo2fm20US9Y0bEImy6vca1Nmq93GsM9OMTGtI75LfW+iWC7tHyge8CKkgr3/bHnY0A9ZppUD3lWXI4iiaCW+yGX7R/4TLkzYK5lagYKRAuc0HrL23wAA0GdAXhtyOp+UI1wrjF29aFkvc2RUObBHPT81I92fj/vUq/y1bwjAHDIzIErc3NXlo+FtBoF7xgTkNwK/p919IEThjaQk+osNx45qGnO7isj0gCLvSpP6roXHzNtDekJ7v03zyf2XHL8uPLgWOJtwhcyZr41HzJxhBFGt59XMX248fPqJhQbvAOkxjq5SGV7L+2/eRratAr13MfYMIGzc1D9v4Fs6JSvqASIN4Kwse09Y1/qGIOoSHaLOhHKvlSny2nQTwzGwGQYqebZVhStWspzk/4QKShkOci77BTTVHR5Lk+Vj1lL5RdLVaib1CMVW/DzlRENcXDgERu0uV23sHbHJFYGER2lckFEuUej7UZ7eioPi885rq9SDaMiAJle7P9P3q0I/Hzslo+P1DxLTElktBC8qakRVv+W6uwhc8YwWbt/2cUmgE60tQdafFSlz6qhy8cCw7tW46i63sxJclg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bFZV5Vn63NMGM6zrHAwVmh8Z7cc885Kx8EjUf449Pjl471Dq3HuJ7Jh1OVtmg7Qzk/JUgUEqxGhtBKAnSB43KuqJWBIvGywQWoHfp131utWk2b60y9WyEzs/kTzM5HUUdFKB3A1ZX/mruMxYJo2Arf7HxqXfhbSb7kIQSYdgVChmmy1dR6qMV05P6DhNRNz80skMMwlEfXJbQqVR9r2ekFgocKjXah5gpzUknUXcG1w7qXUORFnrxFP8Ai+byNUQoTpFEfyLWZFD/HUPR6o2VlAcNDul+s50+VJ8QGwBqbUswXLriBNSJgdk+crsHc6q0iwd7HsHJxnDXW0dbfvjhoHylMv1oMRXAajxjZeWOP5Ee1glOQ3KC0W/s4BGDHX/iNglzJsPjks6d7vbflG8Z3D2PnlH+pBBqlCiljeIbTnbEJiwHCggXWrM8YZmH9Y6 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2026 04:17:03.0906 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3a7ca82-da69-4b88-9bbd-08de78128ea8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E4.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9176 Hello Peter, On 2/27/2026 7:36 PM, Peter Zijlstra wrote: >> Looking at the series, all we need is an equivalent of: >> >> domain_weight(TOPO_NUMA_DOMAIN) > > Fair enough; but then lets replace patch 1 and 2 with something like > that. > > But I must note that the nodemask API is crap; it has both node_set() and > __node_set() be the atomic version :-( > > Let me go rework the other patches to fit on this. Boots fine with a s/domain_weight(TOPO_NUMA_DOMAIN)/num_phys_nodes()/ applied to Patch 3. Topology looks fine for NPS4 on my 3rd Generation EPYC with 2 sockets, and I haven't triggered any warning even with "L3 as NUMA" turned on. Feel free to include: Tested-by: K Prateek Nayak -- Thanks and Regards, Prateek