From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58979C433DB for ; Sat, 2 Jan 2021 21:24:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 278B020795 for ; Sat, 2 Jan 2021 21:24:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbhABVYQ (ORCPT ); Sat, 2 Jan 2021 16:24:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726686AbhABVYP (ORCPT ); Sat, 2 Jan 2021 16:24:15 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18183C061573; Sat, 2 Jan 2021 13:23:35 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id c5so27108186wrp.6; Sat, 02 Jan 2021 13:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=6ghFTfIjxEctDxptPNvtSJH4UOPjMWmlT+kIsBap1jw=; b=pSZvvzezr1d8rXA0x5oYG7501vDkYBOcmRlDDOqbgcZR7FMQQjJKmoAo9TExDMpeaF BZ1x4WIXOeQV2F0TiJrs8N0CD1QQBs0RofJmaa9fSZpu8CAfYEPQmg8bVRt5x40dpBIz EevQ2h3MWvAmpuZuBrsVHRaWMk7AdscxPZSfyMSVZBR7JEmpYJiAfs9y0d9v3Ttky7gA 465o1BRB6Nr1Ofx0PC/NXoPJltq3b3pgkjRTuTSK02U0wIV3TvcVqQMlOmtAG+pfP0PS dU9FhY8y8qOTi9Ln+YMdgF6t/TDNaUQCy5Hk05mLrqQKtIJii5burr+15LOVzps6A+5J cPaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=6ghFTfIjxEctDxptPNvtSJH4UOPjMWmlT+kIsBap1jw=; b=fjNCf22AAZ7PglBljVRd5aOFmuktgAtw0ohy3y5u8H/Wjc9Gj10vuV8zpFdDRNLtjx QOBaRsnEaJsMLYhVgPaIlq/ZmuntRldE6PYyakAsUMuSTb1j5EuQ3MXKI1Ago/NadIpt uNthJjeYwceHpv7RPGaj2AK49RCA5NayaS9ZfX7iqEob1aYTP6k1VzSOh8tz7R5oUuZ4 0uJkT+x5/bLbfFUTUWUSvzNmLKc9RS1SjKQGFbfEQLv6N3RywOEqNrcBtIEGn3Sj/ITL DOo0zPTXvO4uvT+hhfV8trKOqnIPTdUNQs2he51x5Y8j2foxqHsfNSYzAOn0dXRNtq03 ASCQ== X-Gm-Message-State: AOAM5311XKfs3a3/xlDqfYQlnoR3H8iNDtRZ4ZPW5xomdSPJsaHs/1iv aVMRB4bI8QXD0zUX89aSOyM= X-Google-Smtp-Source: ABdhPJzfSvV8/SEMVa7AzTOpKW/ysf0hDNuKeGBVNyAymeQZ+kD+ilHVRlPjrsXEP/S2OiCXBAzyVg== X-Received: by 2002:adf:fd0c:: with SMTP id e12mr73510737wrr.61.1609622613430; Sat, 02 Jan 2021 13:23:33 -0800 (PST) Received: from [192.168.1.211] ([2.29.208.120]) by smtp.gmail.com with ESMTPSA id s13sm65498900wra.53.2021.01.02.13.23.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Jan 2021 13:23:32 -0800 (PST) Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver To: Sakari Ailus Cc: Andy Shevchenko , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , Jordan Hand , Laurent Pinchart References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-15-djrscally@gmail.com> <20201228170521.GZ26370@paasikivi.fi.intel.com> <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> <20210102170731.GD11878@paasikivi.fi.intel.com> <20210102172414.GF11878@paasikivi.fi.intel.com> From: Daniel Scally Message-ID: <8b999653-0cbc-b85e-6f95-729ecd66f622@gmail.com> Date: Sat, 2 Jan 2021 21:23:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210102172414.GF11878@paasikivi.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sakari On 02/01/2021 17:24, Sakari Ailus wrote: > On Sat, Jan 02, 2021 at 05:12:47PM +0000, Daniel Scally wrote: >> Hi Sakari >> >> On 02/01/2021 17:07, Sakari Ailus wrote: >>> Hi Daniel, >>> >>> On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: >>>>>>> +#define CIO2_NUM_PORTS 4 >>>>> This is already defined in ipu3-cio2.h. Could you include that instead? >>>> Yes; but I'd need to also include media/v4l2-device.h and >>>> media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the >>>> moment). It didn't seem worth it; but I can move those two includes from >>>> the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h >>>> >>>> Which do you prefer? >>> Seems you got answers already... :-) splitting the header in two seems good >>> to me. But IMO it doesn't have to be a part of this set. >>> >> Yeah I've been hesitating over this; if we chose not to do it in this >> set though, how would you want me to deal with the double definition of >> CIO2_NUM_PORTS > The patch is here: > > > > I guess Andy forgot to cc you. > Ah - thanks, I'd not read back through the list yet. I'll look at this tonight then.