From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792666485; b=5O8Vxn6z6Z6QnHNrLL8XQ4D1s5gxtUHgh7SqyMCvE/i0WFx9ls+mxebgq+O9oNfz+Tw8 7MzLnszvn8l2ca5dJiaf75nI94GHYflaaKVSNm9OQh9Mip5f+AKzHcmcEm8yHMrxVmqUQ BoI906e2E6QrShqSfSu4DOU3FeFP9nLoEXIYbgTlHpGI/I9lny7tBnHYQiSkrbc6tb48T 7aq53fJN6PD5CzbKnIRbQ0EYZ63ta8ECamu+MCVdH+mRt2kbsx1eJ60JRYxJQ/fOf8jdD xq+rKBS+MPcuwvDra3ak75FxXfYVTlGaK7uelhfSjXB7gjpAbOFbzHR05l/KRtAj/sQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792666485; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Message-ID:Date:MIME-Version:User-Agent:Subject: Content-Language:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=m02LnQqAx90iQHNTDHgW+TeOE5dUtsPN+2XnmmAiXdA=; b=4LAEaKagxQA/o9jGCQZofaM7vbWF0ag5w0yqB3J4ldog3qTtRE4GZqr9ew/V168qvpeE Wo4RS4kDNf6FlQ9HYkQEpF4+nbH7cpVTfHcyjNEK030YvpcOBGuqWuvjCCF7ByRPqM41t GvHcPY/1G2NfOaF4UCmVAyFxrC3yScJ1dpBlmZtLBedHmx1PYz3eBAaTuHNwJlc/oHvim ZS7eZ0a3hiC7TZa36UvIvV5XzAUipv1Jt9Riv5Wsc4xiA9Iin2RXHDHtKFtkOqEMs9sg8 aeacIKOT95t2SJGTcwDk0IAGgVJxZdCkUcpe93gky0OGUDSqrbMrml0kTuJUN3diWUw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fDCXQKuV; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=Y9wiS6va; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97764606A326 for ; Thu, 22 Oct 2026 10:54:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 97764606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fDCXQKuV; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=Y9wiS6va DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792666483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m02LnQqAx90iQHNTDHgW+TeOE5dUtsPN+2XnmmAiXdA=; b=fDCXQKuVYLhh8LDwZkwnc777nM4dmZetyWnBaUrAKPt7SB1awHmswgObQjd5SDcn6Iq4EM TqfyvfUZhSIPlvaMVrkYewUL8kIFL9Yj8k9hUwAtMPY3NnkcNnIyxpJIsBrBuB0vAp4b53 +xpOHYgNZu7GyA+2EkGmJR+rjvRrYCw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-5xpK1XAtMO-GZbT_jG6jHw-1; Thu, 22 Oct 2026 10:54:40 +0000 X-MC-Unique: 5xpK1XAtMO-GZbT_jG6jHw-1 X-Mimecast-MFC-AGG-ID: 5xpK1XAtMO-GZbT_jG6jHw_1792666479 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49953abe51fso13097685e9.1 for ; Thu, 22 Oct 2026 03:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1792666479; x=1793271279; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=m02LnQqAx90iQHNTDHgW+TeOE5dUtsPN+2XnmmAiXdA=; b=Y9wiS6vaFVrz3SOJ3vWMnVepwefZPmmzv5KVC6o63au9Sd3K/FYAeGDPQDdbBUT9m0 jj05j8d0qE+ClJ/rcmCtHLR3ArC1Vz18I6kKMWW43tAqocpoT6wGfd2ekdf5HVhgnqiV OCk5tqL8FNUSdDYZxTeMg1wMq3mjEiKwUkTFTjINkcJuhaovO5DtDtf54LRKSc0EQlPA HkSrQlINBD1xc5kS44zKEKAIeCGFKm3WYH5xawoH1C0on+wAqG92a3QrONm6aKx3Dq85 uEYCBu0Wx1TfKWeNpMIQDyrHVxGqdACTvn5tol5e4pILgTyOy2rCv8rmtLloH95mVMTn B2YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792666479; x=1793271279; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=m02LnQqAx90iQHNTDHgW+TeOE5dUtsPN+2XnmmAiXdA=; b=tIcAYVPOS11IE4LTZepzQb7TM/RFPD36dSukKJq6LLE4F5yf4AEebh/SJogbCYnfsX +o7+pxxseJLWvWEcPQXXpf6OeUmr6ZEAgVNEyC51HWdkSlHEqWLNXuLfuZr4h+QzXDg8 OadV5ktPZ//+jqxDgoVysKhUcMSB7d/t/5AyK3d0W2zDpFJqH0+9YzgkrLVfryyGRifM 44JijoMS/d8ElYxrKO3dCPN0gu35VFw+DXBRKSkE175mJ9rEJpny/sp4IXQlra7ofTen VQGRzWPLx/sxmOcaaU9epD0YpdIXii5ooju+KL0bdQyl0f2OoBea6kJnXO9/+rZ3MQSP QiUA== X-Forwarded-Encrypted: i=1; AKwUvBxIDsQVqaEvfoCFspdm1iFGmZQ+re/YvXOvC4ye+cr16KhON/AcIcM/hX1SBd7tZ2wDXkgGiyGKjnNI37I=@vger.kernel.org X-Gm-Message-State: AFq9FYIGIghhGdPS7XTnjYpN2LaQ78Eqcz+QHXgObPl1j7BgGl6V2HKu 7F6365DtcP1g86Cf4X/YdhrMSMtC3o8p1Wq0au4ogFc0q0QSBYsATu0ui7CzWYcDaJfp9syVUQS rb58us/zJbTpUektXS+E3dr2ylERjMpfig/byV5t2+PLCHCH5RjzMOdzvlH7ZZnbZFg== X-Gm-Gg: AYBFou1XJ9aM/p7D4jCPcYl6mTA3h3dJSTd1lRpVfLFy5yRbvW0w0Sbuyptyk4p75kI blZPcm6yPXOppnuYAn/58gAnoKFDh9ZcLi5F4430CA3fdYOSYHwbJ4/cSGaChXkJxs4EemhLY9i edgDvp26RvMGuCQgB54nMX25dYLh6I2gSWigSGVfwDhsUEiJRTvcGnLcLyHRyxzd9/1gwmSQg9m 6GbUUCblA4kwUMo1c+TUZWytZ9V/hoP2zI6uQH81bbH4pXMBdlFpoUfh5boE74YNnP4t4h1i6Ld duHJbFYgcrc2PWSAH3IM1b/IzSCEsQwPxiODYHJicV6TBwyqtKUxvoej+r4t0O6hrVhUlDOR5g= = X-Received: by 2002:a05:600c:c4a1:b0:4a1:f0bc:90b with SMTP id 5b1f17b1804b1-4a1fdd3d407mr99476145e9.29.1792666479355; Thu, 22 Oct 2026 03:54:39 -0700 (PDT) X-Received: by 2002:a05:600c:c4a1:b0:4a1:f0bc:90b with SMTP id 5b1f17b1804b1-4a1fdd3d407mr99475815e9.29.1792666478965; Thu, 22 Oct 2026 03:54:38 -0700 (PDT) Received: from [192.168.2.75] ([46.175.183.46]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e254f02f1sm12856807f8f.3.2026.10.22.03.54.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Oct 2026 03:54:38 -0700 (PDT) Message-ID: <8b9bc610-777b-4436-98a6-2428153cc5f2@redhat.com> Date: Thu, 22 Oct 2026 12:54:36 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH iwl-net 3/3] ice: do not block on the aux device lock in ndo_setup_tc Content-Language: en-US To: "Loktionov, Aleksandr" , "netdev@vger.kernel.org" Cc: "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Ertman, David M" , Shiraz Saleem , Leon Romanovsky , "Maziarz, Kamil" , Rafal Rogalski , "Schmidt, Michal" , "linux-rdma@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Mateusz Palczewski , "linux-rt-devel@lists.linux.dev" References: <20261019065301.3983537-1-poros@redhat.com> <20261019065301.3983537-4-poros@redhat.com> From: Petr Oros In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/21/26 1:22 PM, Loktionov, Aleksandr wrote: > > >> -----Original Message----- >> From: Petr Oros >> Sent: Monday, October 19, 2026 8:53 AM >> To: netdev@vger.kernel.org >> Cc: Oros, Petr ; Nguyen, Anthony L >> ; Kitszel, Przemyslaw >> ; Andrew Lunn ; >> David S . Miller ; Eric Dumazet >> ; Jakub Kicinski ; Paolo Abeni >> ; Ertman, David M ; Shiraz >> Saleem ; Leon Romanovsky ; >> Maziarz, Kamil ; Rafal Rogalski >> ; Loktionov, Aleksandr >> ; Schmidt, Michal ; >> linux-rdma@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux- >> kernel@vger.kernel.org; stable@vger.kernel.org; Sebastian Andrzej >> Siewior ; Clark Williams ; >> Steven Rostedt ; Mateusz Palczewski >> ; linux-rt-devel@lists.linux.dev >> Subject: [PATCH iwl-net 3/3] ice: do not block on the aux device lock in >> ndo_setup_tc >> >> The TC_SETUP_QDISC_MQPRIO path of ice_setup_tc() takes the auxiliary >> device lock to test whether the RDMA driver is bound, and ndo_setup_tc() >> runs with the RTNL lock held. This closes the same cycle against the >> RDMA auxiliary probe as the two preceding patches. >> >> Use device_trylock() and report the device as busy when it fails, with a >> distinct message for the same reason as in the previous patch. >> >> Fixes: 4b31fd4d77ff ("ice: Fix RDMA VSI removal during queue rebuild") >> Cc: stable@vger.kernel.org >> Signed-off-by: Petr Oros >> --- >> drivers/net/ethernet/intel/ice/ice_main.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c >> b/drivers/net/ethernet/intel/ice/ice_main.c >> index edb62606d2aae3..7b251136149615 100644 >> --- a/drivers/net/ethernet/intel/ice/ice_main.c >> +++ b/drivers/net/ethernet/intel/ice/ice_main.c >> @@ -9448,7 +9448,11 @@ ice_setup_tc(struct net_device *netdev, enum >> tc_setup_type type, >> cdev = pf->cdev_info; >> if (cdev && cdev->adev) { >> mutex_lock(&pf->adev_mutex); >> - device_lock(&cdev->adev->dev); >> + if (!device_trylock(&cdev->adev->dev)) { >> + mutex_unlock(&pf->adev_mutex); >> + netdev_dbg(netdev, "RDMA auxiliary device is >> busy, try again\n"); >> + return -EBUSY; > You return error here, but it looks like being silently dropped in mqprio_disable_offload() isn't it ? Yes, mqprio_disable_offload() ignores it, the same as it ignores the existing -EBUSY for a bound RDMA driver. Blocking there brings the deadlock back and skipping the lock races with the probe, so v2 keeps the refusal and warns about it instead of netdev_dbg(). > >> + } >> locked = true; >> if (cdev->adev->dev.driver) { >> netdev_err(netdev, "Cannot change qdisc when >> RDMA is active\n"); >> -- >> 2.56.0 >