From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34F12C43333 for ; Tue, 2 Mar 2021 11:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2B7364F0B for ; Tue, 2 Mar 2021 11:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1446383AbhCBKxU (ORCPT ); Tue, 2 Mar 2021 05:53:20 -0500 Received: from foss.arm.com ([217.140.110.172]:49078 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1838377AbhCBKgK (ORCPT ); Tue, 2 Mar 2021 05:36:10 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8851AED1; Tue, 2 Mar 2021 02:35:24 -0800 (PST) Received: from [10.57.48.219] (unknown [10.57.48.219]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 25EFF3F73C; Tue, 2 Mar 2021 02:35:20 -0800 (PST) Subject: Re: Aw: Re: Re: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling To: Frank Wunderlich , Marc Zyngier , Chuanjia Liu Cc: linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , Thierry Reding , "K. Y. Srinivasan" , Will Deacon , Marek Vasut , Rob Herring , Wei Liu , Lorenzo Pieralisi , Stephen Hemminger , Michal Simek , Jonathan Hunter , Thierry Reding , Haiyang Zhang , Ryder Lee , linux-mediatek@lists.infradead.org, Paul Walmsley , linux-tegra@vger.kernel.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Yoshihiro Shimoda , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20210225151023.3642391-1-maz@kernel.org> <20210225151023.3642391-10-maz@kernel.org> <5afd1d656299d87c43bdf31b8ced2d5f@kernel.org> From: Robin Murphy Message-ID: <8b9c013a-b5d5-9b19-f28a-4af543e47fff@arm.com> Date: Tue, 2 Mar 2021 10:35:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-03-01 14:06, Frank Wunderlich wrote: >> Gesendet: Montag, 01. März 2021 um 14:31 Uhr >> Von: "Marc Zyngier" >> >> Frank, >> >>>>> i guess it's a bug in ath10k driver or my r64 board (it is a v1.1 >>>>> which has missing capacitors on tx lines). >>>> >>>> No, this definitely looks like a bug in the MTK PCIe driver, >>>> where the mutex is either not properly initialised, corrupted, >>>> or the wrong pointer is passed. >>> >>> but why does it happen only with the ath10k-card and not the mt7612 in >>> same slot? >> >> Does mt7612 use MSI? What we have here is a bogus mutex in the >> MTK PCIe driver, and the only way not to get there would be >> to avoid using MSIs. > > i guess this card/its driver does not use MSI. Did not found anything in "datasheet" [1] or driver [2] about msi FWIW, no need to guess - `lspci -v` (as root) should tell you whether the card has MSI (and/or MSI-X) capability, and whether it is enabled if so. Robin. >>> >>>> This r64 machine is supposed to have working MSIs, right? >>> >>> imho mt7622 have working MSI >>> >>>> Do you get the same issue without this series? >>> >>> tested 5.11.0 [1] without this series (but with your/thomas' patch >>> from discussion about my old patch) and got same trace. so this series >>> does not break anything here. >> >> Can you retest without any additional patch on top of 5.11? >> These two patches only affect platforms that do *not* have MSIs at all. > > i can revert these 2, but still need patches for mt7622 pcie-support [3]...btw. i see that i miss these in 5.11-main...do not see traceback with them (have firmware not installed...) > > root@bpi-r64:~# dmesg | grep ath > [ 6.450765] ath10k_pci 0000:01:00.0: assign IRQ: got 146 > [ 6.661752] ath10k_pci 0000:01:00.0: enabling device (0000 -> 0002) > [ 6.697811] ath10k_pci 0000:01:00.0: enabling bus mastering > [ 6.721293] ath10k_pci 0000:01:00.0: pci irq msi oper_irq_mode 2 irq_mode 0 r > eset_mode 0 > [ 6.921030] ath10k_pci 0000:01:00.0: Failed to find firmware-N.bin (N between > 2 and 6) from ath10k/QCA988X/hw2.0: -2 > [ 6.931698] ath10k_pci 0000:01:00.0: could not fetch firmware files (-2) > [ 6.940417] ath10k_pci 0000:01:00.0: could not probe fw (-2) > > so traceback was caused by missing changes in mtk pcie-driver not yet upstream, added Chuanjia Liu > >>> >>>>> Tried with an mt7612e, this seems to work without any errors. >>>>> >>>>> so for mt7622/mt7623 >>>>> >>>>> Tested-by: Frank Wunderlich >>>> >>>> We definitely need to understand the above. >>> >>> there is a hardware-bug which may cause this...afair i saw this with >>> the card in r64 with earlier Kernel-versions where other cards work >>> (like the mt7612e). >> >> I don't think a HW bug affecting PCI would cause what we are seeing >> here, unless it results in memory corruption. > > > [1] https://www.asiarf.com/shop/wifi-wlan/wifi_mini_pcie/ws2433-wifi-11ac-mini-pcie-module-manufacturer/ > [2] grep -Rni 'msi' drivers/net/wireless/mediatek/mt76/mt76x2/ > [3] https://patchwork.kernel.org/project/linux-mediatek/list/?series=372885 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >