From: Xi Ruoyao <xry111@xry111.site>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>
Cc: linux-crypto@vger.kernel.org, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org, Jinyang He <hejinyang@loongson.cn>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v6 2/3] LoongArch: vDSO: Wire up getrandom() vDSO implementation
Date: Thu, 19 Sep 2024 16:31:19 +0800 [thread overview]
Message-ID: <8ba2bb15917480db5cb644570bc7f79cbd6883fd.camel@xry111.site> (raw)
In-Reply-To: <77655d9e-fc05-4300-8f0d-7b2ad840d091@csgroup.eu>
On Thu, 2024-09-19 at 09:08 +0200, Christophe Leroy wrote:
> I know nothing about Loongarch assembly and execution performance, but I
> see that GCC groups operations by 4 when building
> reference_chacha20_blocks() from vdso_test_chacha, see below.
>
> Shouldn't you do the same and group ROUNDs by 4 just like I did on
> powerpc ?
> (https://github.com/torvalds/linux/blob/master/arch/powerpc/kernel/vdso/vgetrandom-chacha.S)
Maybe. In theory the scheduling would improve the performance. I'll
measure if the scheduling will make an observable performance
improvement.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2024-09-19 8:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 6:13 [PATCH v6 0/3] LoongArch: Implement getrandom() in vDSO Xi Ruoyao
2024-09-01 6:13 ` [PATCH v6 1/3] arch: vDSO: Add a __vdso_getrandom prototype for all architectures Xi Ruoyao
2024-09-01 8:44 ` Huacai Chen
2024-09-01 13:23 ` Jason A. Donenfeld
2024-09-01 13:39 ` Jason A. Donenfeld
2024-09-01 13:45 ` Jason A. Donenfeld
2024-09-01 13:29 ` Jason A. Donenfeld
2024-09-01 18:06 ` Christophe Leroy
2024-09-01 18:13 ` Jason A. Donenfeld
2024-09-01 6:13 ` [PATCH v6 2/3] LoongArch: vDSO: Wire up getrandom() vDSO implementation Xi Ruoyao
2024-09-01 13:52 ` Jason A. Donenfeld
2024-09-19 7:08 ` Christophe Leroy
2024-09-19 8:31 ` Xi Ruoyao [this message]
2024-09-01 6:13 ` [PATCH v6 3/3] selftests/vDSO: Enable vdso getrandom tests for LoongArch Xi Ruoyao
2024-09-01 13:47 ` Jason A. Donenfeld
2024-09-01 8:48 ` [PATCH v6 0/3] LoongArch: Implement getrandom() in vDSO Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ba2bb15917480db5cb644570bc7f79cbd6883fd.camel@xry111.site \
--to=xry111@xry111.site \
--cc=Jason@zx2c4.com \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=hejinyang@loongson.cn \
--cc=kernel@xen0n.name \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®