Re: [PATCH] cgroup/cpuset-v1: Add missing support for cpuset_v2_mode

[Waiman Long <llong@redhat.com>]

On 4/14/25 2:26 PM, Michal Koutný wrote:
> Hello.
>
> On Mon, Apr 14, 2025 at 04:28:41PM +0000, "T.J. Mercier" <tjmercier@google.com> wrote:
>> Add cgroup v1 parameter parsing to the cpuset filesystem type so that it
>> works like the cgroup filesystem type:
> Nothing against 'cpuset_v2_mode' for the cpuset_fs_type (when it's
> available on cgroup v1) but isn't it too benevolent reusing all of
> cgroup1_fs_parameters? AFAICS, this would allow overriding release agent
> also for cpuset fs hierarchies among other options from
> cgroup1_fs_parameters.
>
> (This would likely end up with a separate .parse_param callback but I
> think that's better than adding so many extra features to cpuset fs.)

I concur. It should be a separate cpuset_fs_parameters() to handle it 
instead of reusing cgroup1_fs_parameters() to allow so many other maybe 
irrelevant cgroup1 parameters.

Cheers,
Longman