From: Paolo Bonzini <pbonzini@redhat.com>
To: "Sean Christopherson" <sean.j.christopherson@intel.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Adam Borowski <kilobyte@angband.pl>,
David Hildenbrand <david@redhat.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 1/2] KVM: MMU: Do not treat ZONE_DEVICE pages as being reserved
Date: Wed, 6 Nov 2019 18:14:40 +0100 [thread overview]
Message-ID: <8ba98630-9ca0-85c2-3c94-45d54a448fca@redhat.com> (raw)
In-Reply-To: <20191106170727.14457-2-sean.j.christopherson@intel.com>
On 06/11/19 18:07, Sean Christopherson wrote:
> void kvm_get_pfn(kvm_pfn_t pfn)
> {
> - if (!kvm_is_reserved_pfn(pfn))
> + if (!kvm_is_reserved_pfn(pfn) && !WARN_ON(kvm_is_zone_device_pfn(pfn)))
> get_page(pfn_to_page(pfn));
> }
> EXPORT_SYMBOL_GPL(kvm_get_pfn);
Can you call remap_pfn_range with a source address that is ZONE_DEVICE?
If so, you would get a WARN from the kvm_get_pfn call in
hva_to_pfn_remapped.
Paolo
next prev parent reply other threads:[~2019-11-06 17:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 17:07 [PATCH 0/2] KVM: MMU: Fix a refcount bug with ZONE_DEVICE pages Sean Christopherson
2019-11-06 17:07 ` [PATCH 1/2] KVM: MMU: Do not treat ZONE_DEVICE pages as being reserved Sean Christopherson
2019-11-06 17:14 ` Paolo Bonzini [this message]
2019-11-06 17:46 ` Sean Christopherson
2019-11-06 18:04 ` Dan Williams
2019-11-06 20:26 ` Sean Christopherson
2019-11-06 20:34 ` Dan Williams
2019-11-06 21:09 ` Paolo Bonzini
2019-11-06 21:30 ` Sean Christopherson
2019-11-06 23:20 ` Dan Williams
2019-11-06 23:39 ` Sean Christopherson
2019-11-07 0:01 ` Dan Williams
2019-11-07 5:48 ` Dan Williams
2019-11-07 11:12 ` Paolo Bonzini
2019-11-07 15:36 ` Dan Williams
2019-11-07 15:58 ` Sean Christopherson
2019-11-09 1:43 ` Sean Christopherson
2019-11-09 2:00 ` Dan Williams
2019-11-11 18:27 ` Sean Christopherson
2019-11-11 19:15 ` Paolo Bonzini
2019-11-12 0:51 ` Dan Williams
2019-11-12 10:19 ` Paolo Bonzini
2019-11-12 16:57 ` Sean Christopherson
2019-11-06 17:07 ` [PATCH 2/2] KVM: x86/mmu: Add helper to consolidate huge page promotion Sean Christopherson
2019-11-06 17:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ba98630-9ca0-85c2-3c94-45d54a448fca@redhat.com \
--to=pbonzini@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kilobyte@angband.pl \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®