From: Jakob Hauser <jahau@rocketmail.com>
To: Lee Jones <lee@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Beomho Seo <beomho.seo@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Stephan Gerhold <stephan@gerhold.net>,
Raymond Hackley <raymondhackley@protonmail.com>,
Pavel Machek <pavel@ucw.cz>, Axel Lin <axel.lin@ingics.com>,
ChiYuan Huang <cy_huang@richtek.com>,
Linus Walleij <linus.walleij@linaro.org>,
Henrik Grimler <henrik@grimler.se>,
Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v6 04/10 RESEND] mfd: rt5033: Apply preparatory changes before adding rt5033-charger driver
Date: Thu, 25 May 2023 19:16:48 +0200 [thread overview]
Message-ID: <8ba9bb4c-6b9f-21ea-e9fe-89d5038dff2c@rocketmail.com> (raw)
In-Reply-To: <20230525104434.GD9691@google.com>
Hi Lee,
On 25.05.23 12:44, Lee Jones wrote:
> On Mon, 15 May 2023, Jakob Hauser wrote:
...
>> diff --git a/include/linux/mfd/rt5033.h b/include/linux/mfd/rt5033.h
>> index 8f306ac15a27..e99e2ab0c1c1 100644
>> --- a/include/linux/mfd/rt5033.h
>> +++ b/include/linux/mfd/rt5033.h
>> @@ -51,7 +51,7 @@ struct rt5033_charger_data {
>> struct rt5033_charger {
>> struct device *dev;
>> struct rt5033_dev *rt5033;
>> - struct power_supply psy;
>> + struct power_supply *psy;
>
> Is this current unused?
Currently this is not in use. The rt5033 charger driver gets introduced
by this pachset.
The struct rt5033_charger was added in Dec 2014 with the mfd driver [1]
but the charger driver didn't make it [2] and further effort to
implement it phased out [3].
[1] https://lore.kernel.org/lkml/20141209140102.GZ3951@x1
[2] https://lore.kernel.org/lkml/20150122183037.GA24898@earth.universe
[3]
https://lore.kernel.org/lkml/1425864191-4121-1-git-send-email-beomho.seo@samsung.com/T/#t
>> struct rt5033_charger_data *chg;
>> };
>>
Kind regards,
Jakob
next prev parent reply other threads:[~2023-05-25 17:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1684182964.git.jahau.ref@rocketmail.com>
2023-05-15 20:57 ` [PATCH v6 00/10 RESEND] Add RT5033 charger device driver Jakob Hauser
2023-05-15 20:57 ` [PATCH v6 01/10 RESEND] mfd: rt5033: Drop rt5033-battery sub-device Jakob Hauser
2023-05-15 20:57 ` [PATCH v6 02/10 RESEND] mfd: rt5033: Fix chip revision readout Jakob Hauser
2023-05-15 20:57 ` [PATCH v6 03/10 RESEND] mfd: rt5033: Fix STAT_MASK, HZ_MASK and AICR defines Jakob Hauser
2023-05-15 20:57 ` [PATCH v6 04/10 RESEND] mfd: rt5033: Apply preparatory changes before adding rt5033-charger driver Jakob Hauser
2023-05-25 10:44 ` Lee Jones
2023-05-25 17:16 ` Jakob Hauser [this message]
2023-05-15 20:57 ` [PATCH v6 05/10 RESEND] power: supply: rt5033_charger: Add RT5033 charger device driver Jakob Hauser
2023-05-15 20:57 ` [PATCH v6 06/10 RESEND] power: supply: rt5033_charger: Add cable detection and USB OTG supply Jakob Hauser
2023-08-17 9:38 ` (subset) " Lee Jones
2023-08-22 7:07 ` Lee Jones
2023-08-22 21:29 ` Sebastian Reichel
2023-09-03 12:43 ` Jakob Hauser
2023-09-04 14:27 ` Lee Jones
2023-05-15 20:57 ` [PATCH v6 07/10 RESEND] power: supply: rt5033_battery: Move struct rt5033_battery to battery driver Jakob Hauser
2023-05-15 20:57 ` [PATCH v6 08/10 RESEND] power: supply: rt5033_battery: Adopt status property from charger Jakob Hauser
2023-05-15 20:57 ` [PATCH v6 09/10 RESEND] dt-bindings: power: supply: rt5033-battery: Apply unevaluatedProperties Jakob Hauser
2023-05-15 21:30 ` Sebastian Reichel
2023-05-16 21:28 ` Conor Dooley
2023-05-15 20:57 ` [PATCH v6 10/10 RESEND] dt-bindings: Add rt5033 mfd, regulator and charger Jakob Hauser
[not found] ` <a308cd6f-0f72-6a12-aa34-ce06290ce0bb@rocketmail.com>
2023-06-01 14:00 ` [PATCH v6 00/10 RESEND] Add RT5033 charger device driver Lee Jones
2023-06-08 17:19 ` Lee Jones
2023-06-09 6:47 ` [GIT PULL] Immutable branch between MFD and Power due for the v6.5 merge window Lee Jones
2023-06-16 20:02 ` Jakob Hauser
2023-06-19 10:35 ` Lee Jones
2023-07-30 17:58 ` Jakob Hauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ba9bb4c-6b9f-21ea-e9fe-89d5038dff2c@rocketmail.com \
--to=jahau@rocketmail.com \
--cc=axel.lin@ingics.com \
--cc=beomho.seo@samsung.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cw00.choi@samsung.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome