From: Tao Cui <cui.tao@linux.dev>
To: Shaojie Sun <sunshaojie@kylinos.cn>, Tejun Heo <tj@kernel.org>,
sched-ext@lists.linux.dev, David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>
Cc: cui.tao@linux.dev, linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] tools/sched_ext: Add "arena" BTF type tag to the __arena qualifier
Date: Thu, 19 Nov 2026 22:29:39 +0800 [thread overview]
Message-ID: <8bb22131-7f3b-4b70-a7a6-92f465027350@linux.dev> (raw)
In-Reply-To: <20261119102613.811845-1-sunshaojie@kylinos.cn>
Hello, Shaojie,
在 2026/11/19 18:26, Shaojie Sun 写道:
> tools/testing/selftests/bpf/libarena marks __arena types with
> btf_type_tag("arena") so that whether a type belongs to an arena can be
> determined from BTF alone:
>
> commit a0fa68d8ce75 ("selftests/bpf: libarena: Add "arena" BTF type
> tag to __arena qualifier")
>
> tools/sched_ext defines the same __arena qualifier but without the
> "arena" BTF type tag. Add the tag so that both describe arena types the
> same way.
>
> checkpatch reports a false positive on the new definition:
>
> ERROR: Macros with complex values should be enclosed in parentheses
>
> The macro value is a sequence of declaration attributes, not an
> expression, so it can neither be parenthesized nor wrapped in a
> do-while loop. The selftests copy of the qualifier has the very same
> definition and triggers the same warning.
>
Looks good. Tested on sched_ext for-next: all tools/sched_ext scheds
build and scx_sdt loads and runs fine with the tags present in the
BTF of the loaded program.
One nit: the patch doesn't apply to the current tree since
0a5e9cf2525f ("sched_ext: Sync common and compat headers from the scx
repo") changed the context line to "#elif", please rebase (git am -3
works meanwhile).
Also, this header also lives in the sched-ext/scx repo and the two
copies get reconciled by hand; the most recent reconciliation went
from the scx repo into the kernel tree. The scx repo copy doesn't
have the tag either, so it needs the same change there or the next
reconciliation will overwrite this one.
Tested-by: Tao Cui <cuitao@kylinos.cn>
> Signed-off-by: Shaojie Sun <sunshaojie@kylinos.cn>
> ---
> tools/sched_ext/include/scx/bpf_arena_common.bpf.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/sched_ext/include/scx/bpf_arena_common.bpf.h b/tools/sched_ext/include/scx/bpf_arena_common.bpf.h
> index 2043d66940ea..fb796b356f86 100644
> --- a/tools/sched_ext/include/scx/bpf_arena_common.bpf.h
> +++ b/tools/sched_ext/include/scx/bpf_arena_common.bpf.h
> @@ -16,7 +16,7 @@
>
> #if defined(__BPF_FEATURE_ADDR_SPACE_CAST) && !defined(BPF_ARENA_FORCE_ASM)
> #ifndef __arena
> -#define __arena __attribute__((address_space(1)))
> +#define __arena __attribute__((address_space(1))) __attribute__((btf_type_tag("arena")))
> #endif
> #define __arena_global __attribute__((address_space(1)))
> #define cast_kern(ptr) /* nop for bpf prog. emitted by LLVM */
prev parent reply other threads:[~2026-11-19 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 10:26 Shaojie Sun
2026-11-19 14:29 ` Tao Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bb22131-7f3b-4b70-a7a6-92f465027350@linux.dev \
--to=cui.tao@linux.dev \
--cc=arighi@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=changwoo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=sunshaojie@kylinos.cn \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®