From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbdHBHH1 (ORCPT ); Wed, 2 Aug 2017 03:07:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:42842 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751133AbdHBHH0 (ORCPT ); Wed, 2 Aug 2017 03:07:26 -0400 Subject: Re: [PATCH_v4.1_3/3] Make core_pattern support namespace To: Cao Shufeng , linux-kernel@vger.kernel.org Cc: containers@lists.linux-foundation.org, mashimiao.fnst@cn.fujitsu.com, ebiederm@xmission.com References: <1501655849-9149-1-git-send-email-caosf.fnst@cn.fujitsu.com> <1501655849-9149-4-git-send-email-caosf.fnst@cn.fujitsu.com> From: Aleksa Sarai Message-ID: <8bb63f0a-d0b7-edf7-6dca-4d12641074b4@suse.de> Date: Wed, 2 Aug 2017 17:07:19 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501655849-9149-4-git-send-email-caosf.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Currently, each container shared one copy of coredump setting > with the host system, if host system changed the setting, each > running containers will be affected. > Same story happened when container changed core_pattern, both > host and other container will be affected. > > For container based on namespace design, it is good to allow > each container keeping their own coredump setting. From what I can see, this is basically setting a per-pidns core_pattern (which is hierarchically applied). I'm not sure this actually solves the more general problem (that usermode helper settings aren't generally namespace-aware) -- and what happens if you have processes in the same pidns that have different mount namespaces? If we _had_ to do it like this I would think it makes more sense to pin it to mountns, but I was under the impression that someone was working on making usermode helpers play nicer with namespaces. Just my $0.02. -- Aleksa Sarai Software Engineer (Containers) SUSE Linux GmbH https://www.cyphar.com/