From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Zhangjin Wu <falcon@tinylab.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
shuah@kernel.org, stable@vger.kernel.org, w@1wt.eu
Subject: Re: [PATCH] Re: tools/nolibc: drop test for getauxval(AT_PAGESZ)
Date: Sat, 7 Oct 2023 16:53:26 +0200 [thread overview]
Message-ID: <8bb681ef-d324-4eb2-81bd-346af19ad7fc@t-8ch.de> (raw)
In-Reply-To: <20231007134202.6766-1-falcon@tinylab.org>
Hi Zhangjin,
On 2023-10-07 21:42:02+0800, Zhangjin Wu wrote:
> > The test will not work for systems with pagesize != 4096 like aarch64
> > and some others.
> >
>
> We have used EXPECT_GE() instead of EXPECT_EQ(), so this should not
> fail, do I miss something ?;-)
Indeed, I missed that, sorry for the noise.
IMO we can still remove the testcase, but drop it from the
fixes branch and adapt the commit message and Fixes tag.
> Thanks,
> Zhangjin Wu
>
> > Other testcases are already testing the same functionality:
> > * auxv_AT_UID tests getauxval() in general.
> > * test_getpagesize() tests pagesize() which directly calls
> > getauxval(AT_PAGESZ).
> >
> > Fixes: 48967b73f8fe ("selftests/nolibc: add testcases for startup code")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> [..]
prev parent reply other threads:[~2023-10-07 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 10:18 [PATCH] " Thomas Weißschuh
2023-10-07 10:36 ` Willy Tarreau
2023-10-07 10:45 ` Thomas Weißschuh
2023-10-07 13:42 ` [PATCH] " Zhangjin Wu
2023-10-07 14:53 ` Thomas Weißschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bb681ef-d324-4eb2-81bd-346af19ad7fc@t-8ch.de \
--to=linux@weissschuh.net \
--cc=falcon@tinylab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®