From: Artur Weber <aweber.kernel@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, Russell King <linux@armlinux.org.uk>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Kukjin Kim <kgene@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, linux-media@vger.kernel.org,
linux-phy@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 00/12] Re-introduce Exynos4212 support and add Samsung Galaxy Tab 3 8.0 boards
Date: Sun, 16 Apr 2023 14:37:01 +0200 [thread overview]
Message-ID: <8bb6e9a6-0143-3627-14c4-285ce2632070@gmail.com> (raw)
In-Reply-To: <d0b2868f-cade-feb1-52cd-2aacd537c9c6@linaro.org>
On 16/04/2023 12:53, Krzysztof Kozlowski wrote:
> On 16/04/2023 12:49, Artur Weber wrote:
>> On 16/04/2023 12:34, Krzysztof Kozlowski wrote:
>>> On 16/04/2023 12:26, Artur Weber wrote:
>>>> On 16/04/2023 12:16, Artur Weber wrote:
>>>>> This patches re-introduces the Exynos4212 platform and adds support
>>>>> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it:
>>>>>
>>>>> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi)
>>>>> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g)
>>>>> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte)
>>>>>
>>>>> What works:
>>>>>
>>>>> - Display and backlight
>>>>> - Touchscreen (without touchkeys)
>>>>> - GPIO buttons, hall sensor
>>>>> - WiFi and Bluetooth
>>>>> - USB, fuel gauge, charging (partial)
>>>>> - Accelerometer and magnetometer
>>>>> - WiFi model only: light sensor
>>>>
>>>> This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel
>>>> controller driver" for the display panel support for the Samsung Galaxy
>>>> 3 8.0 boards.
>>>
>>> Why? DTS and ARM code cannot depend on driver changes. Please rework
>>> your patchsets to remove any of such dependencies.
>>
>> Ah, that makes sense. I'll re-send the patchset in a second with the
>> panel node removed.
>
> I am sorry, I don't understand. Why would you remove anything from DTS?
> Are bindings NAKed?
The dependency display panel patchset introduces the panel and its
bindings, which in turn are included in the Tab3 DTSI. It was submitted
at roughly the same time as this series, and hasn't been fully reviewed
or merged as of writing. (I have seen your comments on that patchset,
and I will be addressing them shortly.) So the bindings haven't been
explicitly ACKed yet (assuming you mean the Acked-by reply).
In response to:
> Please rework your patchsets to remove any of such dependencies.
I suggested that I could remove the panel node from the DTSI for the
time being. The intent was to submit it in a separate patch later, once
the display is reviewed/merged, and thus actually available in the
kernel; this way, the two patches could be reviewed and merged separately.
I could instead wait for the display patchset to get reviewed/merged
first, then resubmit this series, if that's preferable.
I apologize for the confusion.
Best regards,
Artur Weber
next prev parent reply other threads:[~2023-04-16 12:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 10:16 Artur Weber
2023-04-16 10:16 ` [PATCH 01/12] dt-bindings: soc: samsung: add Exynos4212 PMU compatible Artur Weber
2023-04-16 10:16 ` [PATCH 02/12] dt-bindings: clock: add Exynos4212 clock compatible Artur Weber
2023-04-16 10:16 ` [PATCH 03/12] ARM: exynos: Re-introduce Exynos4212 support Artur Weber
2023-04-16 10:16 ` [PATCH 04/12] soc: samsung: " Artur Weber
2023-04-16 10:16 ` [PATCH 05/12] clk: samsung: Add Exynos4212 compatible to CLKOUT driver Artur Weber
2023-04-16 10:16 ` [PATCH 06/12] clk: samsung: Re-add support for Exynos4212 CPU clock Artur Weber
2023-04-16 10:16 ` [PATCH 07/12] Revert "media: exynos4-is: Remove dependency on obsolete SoC support" Artur Weber
2023-04-16 10:16 ` [PATCH 08/12] Revert "phy: Remove SOC_EXYNOS4212 dep. from PHY_EXYNOS4X12_USB" Artur Weber
2023-04-16 10:16 ` [PATCH 09/12] ARM: dts: Move common Exynos4x12 definitions to exynos4x12.dtsi Artur Weber
2023-04-16 10:16 ` [PATCH 10/12] ARM: dts: Re-introduce Exynos4212 DTSI Artur Weber
2023-04-16 10:16 ` [PATCH 11/12] dt-bindings: arm: samsung: Add Samsung Galaxy Tab3 family boards Artur Weber
2023-04-16 10:16 ` [PATCH 12/12] ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards Artur Weber
2023-04-16 10:26 ` [PATCH 00/12] Re-introduce Exynos4212 support and add " Artur Weber
2023-04-16 10:34 ` Krzysztof Kozlowski
2023-04-16 10:49 ` Artur Weber
2023-04-16 10:53 ` Krzysztof Kozlowski
2023-04-16 12:37 ` Artur Weber [this message]
2023-04-16 12:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bb6e9a6-0143-3627-14c4-285ce2632070@gmail.com \
--to=aweber.kernel@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®