From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB20E810CB for ; Wed, 27 Sep 2023 11:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbjI0LBM (ORCPT ); Wed, 27 Sep 2023 07:01:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbjI0LBI (ORCPT ); Wed, 27 Sep 2023 07:01:08 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84BE0FC for ; Wed, 27 Sep 2023 04:01:07 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-31427ddd3fbso9780572f8f.0 for ; Wed, 27 Sep 2023 04:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695812466; x=1696417266; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nPXcOJ1NNfynFMdPPMa7O3rR4NvIIDDgZXJyYh4uLu4=; b=k9slxVjDu67LhBRF4EukXo2qP0urAkWrijjTeNEbyQd3t0m6T4nwyGmL0mFhsUvkAW 0/ghMJxCknzUgk4dUTgFMWbX/goTTh0Z2sltx7dAhNJLknajzoVYffdXYxJFk9YLWevq N3eDezO0yGh5vR7Q+6fn/0vfg1EB67h5Klp4pRHO/Co01JVxaWCxqzdAArVpiNG9o2bv sRFAq0MyAG+xtbdu0jSpC4RYK0WWjCaQdgXYxYDKrfsiVBU7nS1K495KX71lpr5L5zRn rA9gWWWj3oo+vXgpVSKDyTFgE9qgJfuInjNkDMBFMp22BaHRCpAv0njGgW2RW6S8QOYa Ge5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695812466; x=1696417266; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nPXcOJ1NNfynFMdPPMa7O3rR4NvIIDDgZXJyYh4uLu4=; b=oniaElqrSBlgtiGczxYl7eJRI3UYkEVF4T1CwcGKf0+0PPu3kaagpEDv9HSvM8qdCE +Y3K7rnCy94nCEDOBU2zS/SRvWBDwtpSeTQnA3J7JzACUGvNMXSCxYj1Ut7hdyV8btH4 uYVcQw4WgGkkieRfglthkkoQlYkE+J/fP8SVyWOPeVd3E+BYQfqbeSFvyfVg1v2Adtug 69tSxyAkQE95yoyLAJSewBbLXo8FqxV4k/D08+o8PsZJ1lC1X32RAr1sJPadYN91jZnJ A6dsXCob/zPqS+rk+K+AWuKtuFVsaNceYF1p3KIixoMQxyrWG0jVQ8hyNzc/ttuWtwe1 lV/g== X-Gm-Message-State: AOJu0YzIt30lHKKQyLbDyhofeeXDx+P08I/xwaSAxm6YqJZpA1EbZIwr y4rMSJQoyWpBLJ383E48IWUxJ67TsnHcBX7j7iy7pA== X-Google-Smtp-Source: AGHT+IH/DZlOfmrbdqaypY2t8t+A1qF22x4H5/t02B+tTvUk9hcTKrTZ4u5D/O33X2AKZpabYcmFyg== X-Received: by 2002:a05:6000:180d:b0:313:f783:262b with SMTP id m13-20020a056000180d00b00313f783262bmr1422844wrh.26.1695812465719; Wed, 27 Sep 2023 04:01:05 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id p19-20020a05600c1d9300b0040531f5c51asm17650473wms.5.2023.09.27.04.01.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 04:01:05 -0700 (PDT) Message-ID: <8bbdf132-a007-4cb7-b842-a81de7c1629a@linaro.org> Date: Wed, 27 Sep 2023 12:01:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm6375-pdx225: Add USBPHY regulators Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230927-topic-6375_stuff-v1-0-12243e36b45c@linaro.org> <20230927-topic-6375_stuff-v1-4-12243e36b45c@linaro.org> From: Bryan O'Donoghue In-Reply-To: <20230927-topic-6375_stuff-v1-4-12243e36b45c@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/09/2023 10:21, Konrad Dybcio wrote: > To make dtbs_check happy and the software more aware of what's going > on, describe the HSUSB PHY's regulators and tighten up VDDA_PLL to match. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts > index bbec7aee60be..0ce4fa8de8b0 100644 > --- a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts > +++ b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts > @@ -243,8 +243,8 @@ pm6125_l6: l6 { > }; > > pm6125_l7: l7 { > - regulator-min-microvolt = <720000>; > - regulator-max-microvolt = <1050000>; > + regulator-min-microvolt = <880000>; > + regulator-max-microvolt = <880000>; Where did the old values come from and why are the new values better ? Consider enumerating that in the commit log. > }; > > pm6125_l8: l8 { > @@ -430,6 +430,9 @@ &usb_1_dwc3 { > }; > > &usb_1_hsphy { > + vdda-pll-supply = <&pm6125_l7>; > + vdda18-supply = <&pm6125_l10>; > + vdda33-supply = <&pmr735a_l7>; > status = "okay"; > }; Reviewed-by: Bryan O'Donoghue